Title: [193066] branches/safari-601-branch/Source/WebInspectorUI

Diff

Modified: branches/safari-601-branch/Source/WebInspectorUI/ChangeLog (193065 => 193066)


--- branches/safari-601-branch/Source/WebInspectorUI/ChangeLog	2015-12-03 18:42:24 UTC (rev 193065)
+++ branches/safari-601-branch/Source/WebInspectorUI/ChangeLog	2015-12-03 18:42:31 UTC (rev 193066)
@@ -1,5 +1,38 @@
 2015-12-02  Timothy Hatcher  <[email protected]>
 
+        Merge r188006. rdar://problem/23221163
+
+    2015-08-05  Brian Burg  <[email protected]>
+
+            Web Inspector: use super calls in more places
+            https://bugs.webkit.org/show_bug.cgi?id=147696
+
+            Reviewed by Timothy Hatcher.
+
+            A few opportunities for super calls were overlooked when converting to classes.
+
+            * UserInterface/Views/BreakpointTreeElement.js:
+            (WebInspector.BreakpointTreeElement.prototype.onattach):
+            (WebInspector.BreakpointTreeElement.prototype.ondetach):
+            * UserInterface/Views/CallFrameTreeElement.js:
+            (WebInspector.CallFrameTreeElement.prototype.onattach):
+            (WebInspector.CallFrameTreeElement):
+            * UserInterface/Views/DebuggerTabContentView.js:
+            (WebInspector.DebuggerTabContentView.prototype.showDetailsSidebarPanels):
+            * UserInterface/Views/ProfileNodeTreeElement.js:
+            (WebInspector.ProfileNodeTreeElement.prototype.onattach):
+            * UserInterface/Views/SourceCodeTextEditor.js:
+            (WebInspector.SourceCodeTextEditor.prototype.shown):
+            (WebInspector.SourceCodeTextEditor.prototype.hidden):
+            (WebInspector.SourceCodeTextEditor.prototype.canBeFormatted):
+            * UserInterface/Views/SourceCodeTreeElement.js:
+            (WebInspector.SourceCodeTreeElement.prototype.onattach):
+            * UserInterface/Views/TimelineRecordTreeElement.js:
+            (WebInspector.TimelineRecordTreeElement.prototype.onattach):
+            (WebInspector.TimelineRecordTreeElement):
+
+2015-12-02  Timothy Hatcher  <[email protected]>
+
         Merge r187986. rdar://problem/23221163
 
     2015-08-05  Brian Burg  <[email protected]>

Modified: branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/BreakpointTreeElement.js (193065 => 193066)


--- branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/BreakpointTreeElement.js	2015-12-03 18:42:24 UTC (rev 193065)
+++ branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/BreakpointTreeElement.js	2015-12-03 18:42:31 UTC (rev 193066)
@@ -105,7 +105,7 @@
 
     onattach()
     {
-        WebInspector.GeneralTreeElement.prototype.onattach.call(this);
+        super.onattach();
 
         this._listeners.install();
 
@@ -116,7 +116,7 @@
 
     ondetach()
     {
-        WebInspector.GeneralTreeElement.prototype.ondetach.call(this);
+        super.ondetach();
 
         this._listeners.uninstall();
 

Modified: branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/CallFrameTreeElement.js (193065 => 193066)


--- branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/CallFrameTreeElement.js	2015-12-03 18:42:24 UTC (rev 193065)
+++ branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/CallFrameTreeElement.js	2015-12-03 18:42:31 UTC (rev 193066)
@@ -60,7 +60,7 @@
 
     onattach()
     {
-        WebInspector.GeneralTreeElement.prototype.onattach.call(this);
+        super.onattach();
 
         console.assert(this.element);
 

Modified: branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/DebuggerTabContentView.js (193065 => 193066)


--- branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/DebuggerTabContentView.js	2015-12-03 18:42:24 UTC (rev 193065)
+++ branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/DebuggerTabContentView.js	2015-12-03 18:42:31 UTC (rev 193066)
@@ -53,7 +53,7 @@
 
     showDetailsSidebarPanels()
     {
-        WebInspector.ContentBrowserTabContentView.prototype.showDetailsSidebarPanels.call(this);
+        super.showDetailsSidebarPanels();
 
         if (!this._showScopeChainDetailsSidebarPanel || !WebInspector.scopeChainDetailsSidebarPanel.parentSidebar)
             return;

Modified: branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/ProfileNodeTreeElement.js (193065 => 193066)


--- branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/ProfileNodeTreeElement.js	2015-12-03 18:42:24 UTC (rev 193065)
+++ branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/ProfileNodeTreeElement.js	2015-12-03 18:42:31 UTC (rev 193066)
@@ -103,7 +103,7 @@
 
     onattach()
     {
-        WebInspector.GeneralTreeElement.prototype.onattach.call(this);
+        super.onattach();
 
         console.assert(this.element);
 

Modified: branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js (193065 => 193066)


--- branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js	2015-12-03 18:42:24 UTC (rev 193065)
+++ branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js	2015-12-03 18:42:31 UTC (rev 193066)
@@ -94,7 +94,7 @@
 
     shown()
     {
-        WebInspector.TextEditor.prototype.shown.call(this);
+        super.shown();
 
         if (WebInspector.showJavaScriptTypeInformationSetting.value) {
             if (this._typeTokenAnnotator)
@@ -111,7 +111,7 @@
 
     hidden()
     {
-        WebInspector.TextEditor.prototype.hidden.call(this);
+        super.hidden();
 
         this.tokenTrackingController.removeHighlightedRange();
 
@@ -152,7 +152,7 @@
         if (this._sourceCode instanceof WebInspector.SourceMapResource)
             return false;
 
-        return WebInspector.TextEditor.prototype.canBeFormatted.call(this);
+        return super.canBeFormatted();
     }
 
     canShowTypeAnnotations()

Modified: branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/SourceCodeTreeElement.js (193065 => 193066)


--- branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/SourceCodeTreeElement.js	2015-12-03 18:42:24 UTC (rev 193065)
+++ branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/SourceCodeTreeElement.js	2015-12-03 18:42:31 UTC (rev 193066)
@@ -54,7 +54,7 @@
 
     onattach()
     {
-        WebInspector.GeneralTreeElement.prototype.onattach.call(this);
+        super.onattach();
 
         this.updateSourceMapResources();
     }

Modified: branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/TimelineRecordTreeElement.js (193065 => 193066)


--- branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/TimelineRecordTreeElement.js	2015-12-03 18:42:24 UTC (rev 193065)
+++ branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/TimelineRecordTreeElement.js	2015-12-03 18:42:31 UTC (rev 193066)
@@ -145,7 +145,7 @@
 
     onattach()
     {
-        WebInspector.GeneralTreeElement.prototype.onattach.call(this);
+        super.onattach();
 
         console.assert(this.element);
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to