Title: [193233] branches/safari-601-branch/Source/WebInspectorUI
- Revision
- 193233
- Author
- [email protected]
- Date
- 2015-12-03 11:00:17 -0800 (Thu, 03 Dec 2015)
Log Message
Merge r190341. rdar://problem/23221163
Modified Paths
Diff
Modified: branches/safari-601-branch/Source/WebInspectorUI/ChangeLog (193232 => 193233)
--- branches/safari-601-branch/Source/WebInspectorUI/ChangeLog 2015-12-03 19:00:12 UTC (rev 193232)
+++ branches/safari-601-branch/Source/WebInspectorUI/ChangeLog 2015-12-03 19:00:17 UTC (rev 193233)
@@ -1,5 +1,21 @@
2015-12-02 Timothy Hatcher <[email protected]>
+ Merge r190341. rdar://problem/23221163
+
+ 2015-09-29 Joseph Pecoraro <[email protected]>
+
+ Web Inspector: Missing completions for Symbol objects, console.error warning
+ https://bugs.webkit.org/show_bug.cgi?id=149641
+
+ Reviewed by Darin Adler.
+
+ * UserInterface/Controllers/_javascript_RuntimeCompletionProvider.js:
+ (WebInspector._javascript_RuntimeCompletionProvider.prototype.completionControllerCompletionsNeeded.getCompletions):
+ (WebInspector._javascript_RuntimeCompletionProvider.prototype.completionControllerCompletionsNeeded.evaluated):
+ Include completions for symbol types.
+
+2015-12-02 Timothy Hatcher <[email protected]>
+
Merge r190286. rdar://problem/23221163
2015-09-28 Joseph Pecoraro <[email protected]>
Modified: branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Controllers/_javascript_RuntimeCompletionProvider.js (193232 => 193233)
--- branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Controllers/_javascript_RuntimeCompletionProvider.js 2015-12-03 19:00:12 UTC (rev 193232)
+++ branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Controllers/_javascript_RuntimeCompletionProvider.js 2015-12-03 19:00:17 UTC (rev 193233)
@@ -162,6 +162,8 @@
object = new Number(0);
else if (primitiveType === "boolean")
object = new Boolean(false);
+ else if (primitiveType === "symbol")
+ object = Symbol();
else
object = this;
@@ -183,7 +185,7 @@
result.callFunctionJSON(getArrayCompletions, undefined, receivedArrayPropertyNames.bind(this));
else if (result.type === "object" || result.type === "function")
result.callFunctionJSON(getCompletions, undefined, receivedPropertyNames.bind(this));
- else if (result.type === "string" || result.type === "number" || result.type === "boolean")
+ else if (result.type === "string" || result.type === "number" || result.type === "boolean" || result.type === "symbol")
WebInspector.runtimeManager.evaluateInInspectedWindow("(" + getCompletions + ")(\"" + result.type + "\")", "completion", false, true, true, false, false, receivedPropertyNamesFromEvaluate.bind(this));
else
console.error("Unknown result type: " + result.type);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
