Title: [193236] branches/safari-601-branch/Source/WebInspectorUI
- Revision
- 193236
- Author
- [email protected]
- Date
- 2015-12-03 11:00:35 -0800 (Thu, 03 Dec 2015)
Log Message
Merge r190377. rdar://problem/23221163
Modified Paths
Diff
Modified: branches/safari-601-branch/Source/WebInspectorUI/ChangeLog (193235 => 193236)
--- branches/safari-601-branch/Source/WebInspectorUI/ChangeLog 2015-12-03 19:00:29 UTC (rev 193235)
+++ branches/safari-601-branch/Source/WebInspectorUI/ChangeLog 2015-12-03 19:00:35 UTC (rev 193236)
@@ -1,5 +1,30 @@
2015-12-02 Timothy Hatcher <[email protected]>
+ Merge r190377. rdar://problem/23221163
+
+ 2015-09-30 Joseph Pecoraro <[email protected]>
+
+ Web Inspector: Thousands of timers fire after switching to _javascript_ and Events timeline
+ https://bugs.webkit.org/show_bug.cgi?id=149682
+
+ Reviewed by Timothy Hatcher.
+
+ Setting the status element of a GeneralTreeElement was triggering a
+ TreeOutline.onchange event. For TreeOutlines with lots of tree elements
+ (_javascript_ & Events with profile nodes) this could result in thousands
+ of onchange events that causes lots of unnecessary work and blocks
+ future timers (like scroll synchronization) from firing.
+
+ This change eliminates TreeOutline change events for tree element
+ changes that are not interesting.
+
+ * UserInterface/Views/GeneralTreeElement.js:
+ (WebInspector.GeneralTreeElement.prototype.set status): Deleted.
+ * UserInterface/Views/TreeOutline.js:
+ (WebInspector.TreeElement.prototype.set tooltip): Deleted.
+
+2015-12-02 Timothy Hatcher <[email protected]>
+
Merge r190376. rdar://problem/23221163
2015-09-30 Joseph Pecoraro <[email protected]>
Modified: branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/GeneralTreeElement.js (193235 => 193236)
--- branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/GeneralTreeElement.js 2015-12-03 19:00:29 UTC (rev 193235)
+++ branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/GeneralTreeElement.js 2015-12-03 19:00:35 UTC (rev 193236)
@@ -188,7 +188,6 @@
this._status = x || "";
this._updateStatusElement();
- this.didChange();
}
get filterableData()
Modified: branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js (193235 => 193236)
--- branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js 2015-12-03 19:00:29 UTC (rev 193235)
+++ branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js 2015-12-03 19:00:35 UTC (rev 193236)
@@ -620,7 +620,6 @@
this._tooltip = x;
if (this._listItemNode)
this._listItemNode.title = x ? x : "";
- this.didChange();
}
get hasChildren()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
