Diff
Modified: branches/safari-601-branch/Source/WebInspectorUI/ChangeLog (193236 => 193237)
--- branches/safari-601-branch/Source/WebInspectorUI/ChangeLog 2015-12-03 19:00:35 UTC (rev 193236)
+++ branches/safari-601-branch/Source/WebInspectorUI/ChangeLog 2015-12-03 19:00:42 UTC (rev 193237)
@@ -1,5 +1,34 @@
2015-12-02 Timothy Hatcher <[email protected]>
+ Merge r190381. rdar://problem/23221163
+
+ 2015-09-30 Joseph Pecoraro <[email protected]>
+
+ Web Inspector: Reduce `delete` in Timeline related classes
+ https://bugs.webkit.org/show_bug.cgi?id=149686
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Controllers/TimelineManager.js:
+ (WebInspector.TimelineManager.prototype.capturingStopped):
+ * UserInterface/Views/TimelineDataGrid.js:
+ (WebInspector.TimelineDataGrid.prototype._refreshDirtyDataGridNodes):
+ (WebInspector.TimelineDataGrid.prototype._sort):
+ (WebInspector.TimelineDataGrid.prototype._updatePopoverForSelectedNode):
+ * UserInterface/Views/TimelineOverview.js:
+ (WebInspector.TimelineOverview.prototype.updateLayout):
+ (WebInspector.TimelineOverview.prototype._handleScrollEvent):
+ * UserInterface/Views/TreeOutlineDataGridSynchronizer.js:
+ (WebInspector.TreeOutlineDataGridSynchronizer.prototype._treeOutlineScrolled):
+ (WebInspector.TreeOutlineDataGridSynchronizer.prototype._dataGridScrolled):
+
+ * UserInterface/Views/ProbeSetDataGrid.js:
+ (WebInspector.ProbeSetDataGrid):
+ (WebInspector.ProbeSetDataGrid.prototype._teardownData):
+ Remove an unused member variable as well.
+
+2015-12-02 Timothy Hatcher <[email protected]>
+
Merge r190377. rdar://problem/23221163
2015-09-30 Joseph Pecoraro <[email protected]>
Modified: branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js (193236 => 193237)
--- branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js 2015-12-03 19:00:35 UTC (rev 193236)
+++ branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js 2015-12-03 19:00:42 UTC (rev 193237)
@@ -161,12 +161,12 @@
if (this._stopCapturingTimeout) {
clearTimeout(this._stopCapturingTimeout);
- delete this._stopCapturingTimeout;
+ this._stopCapturingTimeout = undefined;
}
if (this._deadTimeTimeout) {
clearTimeout(this._deadTimeTimeout);
- delete this._deadTimeTimeout;
+ this._deadTimeTimeout = undefined;
}
this._isCapturing = false;
Modified: branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/ProbeSetDataGrid.js (193236 => 193237)
--- branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/ProbeSetDataGrid.js 2015-12-03 19:00:35 UTC (rev 193236)
+++ branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/ProbeSetDataGrid.js 2015-12-03 19:00:42 UTC (rev 193237)
@@ -43,6 +43,7 @@
this.element.classList.add("inline");
this._frameNodes = new Map;
+ this._lastUpdatedFrame = null;
this._nodesSinceLastNavigation = [];
this._listeners = new WebInspector.EventListenerSet(this, "ProbeSetDataGrid instance listeners");
@@ -103,8 +104,7 @@
this._dataListeners.uninstall(true);
this.removeChildren();
this._frameNodes = new Map;
- this._separators = new Map;
- delete this._lastUpdatedFrame;
+ this._lastUpdatedFrame = null;
}
_updateNodeForFrame(frame)
Modified: branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/TimelineDataGrid.js (193236 => 193237)
--- branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/TimelineDataGrid.js 2015-12-03 19:00:35 UTC (rev 193236)
+++ branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/TimelineDataGrid.js 2015-12-03 19:00:42 UTC (rev 193237)
@@ -194,7 +194,7 @@
{
if (this._scheduledDataGridNodeRefreshIdentifier) {
cancelAnimationFrame(this._scheduledDataGridNodeRefreshIdentifier);
- delete this._scheduledDataGridNodeRefreshIdentifier;
+ this._scheduledDataGridNodeRefreshIdentifier = undefined;
}
if (!this._dirtyDataGridNodes)
@@ -236,13 +236,13 @@
if (dataGridNode === selectedNode) {
selectedNode.revealAndSelect();
- delete this._ignoreSelectionEvent;
+ this._ignoreSelectionEvent = false;
}
}
this._treeOutlineDataGridSynchronizer.enabled = true;
- delete this._dirtyDataGridNodes;
+ this._dirtyDataGridNodes = null;
}
_sort()
@@ -300,7 +300,7 @@
if (selectedNode)
selectedNode.revealAndSelect();
- delete this._ignoreSelectionEvent;
+ this._ignoreSelectionEvent = false;
}
_sortComparator(node1, node2)
@@ -403,7 +403,7 @@
{
if (this._showPopoverTimeout) {
clearTimeout(this._showPopoverTimeout);
- delete this._showPopoverTimeout;
+ this._showPopoverTimeout = undefined;
}
if (this._popover)
@@ -438,7 +438,7 @@
if (this._hidePopoverContentClearTimeout) {
clearTimeout(this._hidePopoverContentClearTimeout);
- delete this._hidePopoverContentClearTimeout;
+ this._hidePopoverContentClearTimeout = undefined;
}
if (updateContent)
Modified: branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js (193236 => 193237)
--- branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js 2015-12-03 19:00:35 UTC (rev 193236)
+++ branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js 2015-12-03 19:00:42 UTC (rev 193237)
@@ -313,7 +313,7 @@
{
if (this._scheduledLayoutUpdateIdentifier) {
cancelAnimationFrame(this._scheduledLayoutUpdateIdentifier);
- delete this._scheduledLayoutUpdateIdentifier;
+ this._scheduledLayoutUpdateIdentifier = undefined;
}
// Calculate the required width based on the duration and seconds per pixel.
@@ -405,7 +405,7 @@
_handleScrollEvent(event)
{
if (this._ignoreNextScrollEvent) {
- delete this._ignoreNextScrollEvent;
+ this._ignoreNextScrollEvent = false;
return;
}
@@ -417,7 +417,7 @@
// Force layout so we can update with the scroll position synchronously.
this.updateLayoutIfNeeded();
- delete this._dontUpdateScrollLeft;
+ this._dontUpdateScrollLeft = false;
}
_handleWheelEvent(event)
Modified: branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/TreeOutlineDataGridSynchronizer.js (193236 => 193237)
--- branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/TreeOutlineDataGridSynchronizer.js 2015-12-03 19:00:35 UTC (rev 193236)
+++ branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/TreeOutlineDataGridSynchronizer.js 2015-12-03 19:00:42 UTC (rev 193237)
@@ -167,7 +167,7 @@
return;
if (this._ignoreNextTreeOutlineScrollEvent) {
- delete this._ignoreNextTreeOutlineScrollEvent;
+ this._ignoreNextTreeOutlineScrollEvent = false;
return;
}
@@ -191,7 +191,7 @@
return;
if (this._ignoreNextDataGridScrollEvent) {
- delete this._ignoreNextDataGridScrollEvent;
+ this._ignoreNextDataGridScrollEvent = false;
return;
}
