Title: [193462] branches/safari-601.1.46-branch/Source/_javascript_Core
- Revision
- 193462
- Author
- [email protected]
- Date
- 2015-12-04 12:54:42 -0800 (Fri, 04 Dec 2015)
Log Message
Merge r192391. rdar://problem/23581597
Modified Paths
Diff
Modified: branches/safari-601.1.46-branch/Source/_javascript_Core/ChangeLog (193461 => 193462)
--- branches/safari-601.1.46-branch/Source/_javascript_Core/ChangeLog 2015-12-04 20:54:37 UTC (rev 193461)
+++ branches/safari-601.1.46-branch/Source/_javascript_Core/ChangeLog 2015-12-04 20:54:42 UTC (rev 193462)
@@ -1,5 +1,34 @@
2015-12-04 Timothy Hatcher <[email protected]>
+ Merge r192391. rdar://problem/23581597
+
+ 2015-11-12 Joseph Pecoraro <[email protected]>
+
+ Web Inspector: Reduce list of saved console messages
+ https://bugs.webkit.org/show_bug.cgi?id=151225
+
+ Reviewed by Geoffrey Garen.
+
+ Inspector saves messages so that when an inspector frontend opens it can report
+ these messages to the frontend. However we were saving a rather large list of
+ 1000 messages. Most pages do not produce a large number of console messages.
+ However pages that live for a long time can generate many errors over time,
+ especially periodic engine issues such as cross-origin access errors. This could
+ result in a lot of wasted memory for console messages that may never be used.
+
+ Likewise when an inspector first open sending all 1000 messages to the frontend
+ results in a poor experience.
+
+ Lets reduce the list of saved messages. Developer will still be able to see
+ all messages as long as they have Web Inspector open at the time the messages
+ are generated.
+
+ * inspector/agents/InspectorConsoleAgent.cpp:
+ Reduce the list from 1000 to 100. Also, when expiring
+ messages from this list, chunk in 10s instead of 100s.
+
+2015-12-04 Timothy Hatcher <[email protected]>
+
Merge r191397. rdar://problem/23581597
2015-10-21 Joseph Pecoraro <[email protected]>
Modified: branches/safari-601.1.46-branch/Source/_javascript_Core/inspector/agents/InspectorConsoleAgent.cpp (193461 => 193462)
--- branches/safari-601.1.46-branch/Source/_javascript_Core/inspector/agents/InspectorConsoleAgent.cpp 2015-12-04 20:54:37 UTC (rev 193461)
+++ branches/safari-601.1.46-branch/Source/_javascript_Core/inspector/agents/InspectorConsoleAgent.cpp 2015-12-04 20:54:42 UTC (rev 193462)
@@ -39,8 +39,8 @@
namespace Inspector {
-static const unsigned maximumConsoleMessages = 1000;
-static const int expireConsoleMessagesStep = 100;
+static const unsigned maximumConsoleMessages = 100;
+static const int expireConsoleMessagesStep = 10;
InspectorConsoleAgent::InspectorConsoleAgent(InjectedScriptManager* injectedScriptManager)
: InspectorAgentBase(ASCIILiteral("Console"))
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
