- Revision
- 193481
- Author
- [email protected]
- Date
- 2015-12-04 15:09:37 -0800 (Fri, 04 Dec 2015)
Log Message
Background state not being tracked correctly for PDFs on iOS
https://bugs.webkit.org/show_bug.cgi?id=151886
Reviewed by Anders Carlson.
The problem here is that when viewing a PDF we don't have an ApplicationStateTracker.
(While we do have a content view - which normally holds the ApplicationStateTracker -
the content view is not in a window, and only has an ApplicationStateTracker while in a
window). For now, let's give the WKPDFView an ApplicationStateTracker of its very own.
In the future we may want to refactor ownership of the ApplicationStateTracker up to
the WKWebView.
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _isBackground]):
- Added, checks background state of content/PDF view.
* UIProcess/API/Cocoa/WKWebViewInternal.h:
- expose _isBackground to PageClientImplIOS.
* UIProcess/ApplicationStateTracker.h:
(WebKit::ApplicationStateTracker::isInBackground):
* UIProcess/ApplicationStateTracker.mm:
(WebKit::isBackgroundState):
(WebKit::ApplicationStateTracker::ApplicationStateTracker):
- generalize WKContentView -> UIView, so this may now also be a WKPDFView.
* UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::isViewVisible):
- check background state via the WKWebView.
* UIProcess/ios/WKPDFView.h:
* UIProcess/ios/WKPDFView.mm:
(-[WKPDFView willMoveToWindow:]):
(-[WKPDFView didMoveToWindow]):
(-[WKPDFView isBackground]):
(-[WKPDFView _applicationDidEnterBackground]):
(-[WKPDFView _applicationWillEnterForeground]):
- added methods to initialize ApplicationStateTracker, access background state, & callbacks to the page proxy.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (193480 => 193481)
--- trunk/Source/WebKit2/ChangeLog 2015-12-04 22:54:26 UTC (rev 193480)
+++ trunk/Source/WebKit2/ChangeLog 2015-12-04 23:09:37 UTC (rev 193481)
@@ -1,3 +1,40 @@
+2015-12-04 Gavin Barraclough <[email protected]>
+
+ Background state not being tracked correctly for PDFs on iOS
+ https://bugs.webkit.org/show_bug.cgi?id=151886
+
+ Reviewed by Anders Carlson.
+
+ The problem here is that when viewing a PDF we don't have an ApplicationStateTracker.
+ (While we do have a content view - which normally holds the ApplicationStateTracker -
+ the content view is not in a window, and only has an ApplicationStateTracker while in a
+ window). For now, let's give the WKPDFView an ApplicationStateTracker of its very own.
+ In the future we may want to refactor ownership of the ApplicationStateTracker up to
+ the WKWebView.
+
+ * UIProcess/API/Cocoa/WKWebView.mm:
+ (-[WKWebView _isBackground]):
+ - Added, checks background state of content/PDF view.
+ * UIProcess/API/Cocoa/WKWebViewInternal.h:
+ - expose _isBackground to PageClientImplIOS.
+ * UIProcess/ApplicationStateTracker.h:
+ (WebKit::ApplicationStateTracker::isInBackground):
+ * UIProcess/ApplicationStateTracker.mm:
+ (WebKit::isBackgroundState):
+ (WebKit::ApplicationStateTracker::ApplicationStateTracker):
+ - generalize WKContentView -> UIView, so this may now also be a WKPDFView.
+ * UIProcess/ios/PageClientImplIOS.mm:
+ (WebKit::PageClientImpl::isViewVisible):
+ - check background state via the WKWebView.
+ * UIProcess/ios/WKPDFView.h:
+ * UIProcess/ios/WKPDFView.mm:
+ (-[WKPDFView willMoveToWindow:]):
+ (-[WKPDFView didMoveToWindow]):
+ (-[WKPDFView isBackground]):
+ (-[WKPDFView _applicationDidEnterBackground]):
+ (-[WKPDFView _applicationWillEnterForeground]):
+ - added methods to initialize ApplicationStateTracker, access background state, & callbacks to the page proxy.
+
2015-12-04 Antti Koivisto <[email protected]>
Rename WebResourceLoadScheduler to WebLoaderStrategy
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm (193480 => 193481)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm 2015-12-04 22:54:26 UTC (rev 193480)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm 2015-12-04 23:09:37 UTC (rev 193481)
@@ -750,6 +750,15 @@
#pragma mark iOS-specific methods
#if PLATFORM(IOS)
+
+- (BOOL)_isBackground
+{
+ if ([self _isDisplayingPDF])
+ return [(WKPDFView *)_customContentView isBackground];
+
+ return [_contentView isBackground];
+}
+
- (void)setFrame:(CGRect)frame
{
CGRect oldFrame = self.frame;
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewInternal.h (193480 => 193481)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewInternal.h 2015-12-04 22:54:26 UTC (rev 193480)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewInternal.h 2015-12-04 23:09:37 UTC (rev 193481)
@@ -111,6 +111,8 @@
- (void)_navigationGestureDidBegin;
- (void)_navigationGestureDidEnd;
+@property (nonatomic, readonly) BOOL _isBackground;
+
@property (nonatomic, readonly) WKWebViewContentProviderRegistry *_contentProviderRegistry;
@property (nonatomic, readonly) WKSelectionGranularity _selectionGranularity;
Modified: trunk/Source/WebKit2/UIProcess/ApplicationStateTracker.h (193480 => 193481)
--- trunk/Source/WebKit2/UIProcess/ApplicationStateTracker.h 2015-12-04 22:54:26 UTC (rev 193480)
+++ trunk/Source/WebKit2/UIProcess/ApplicationStateTracker.h 2015-12-04 23:09:37 UTC (rev 193481)
@@ -33,13 +33,13 @@
#import <wtf/WeakPtr.h>
OBJC_CLASS BKSApplicationStateMonitor;
-OBJC_CLASS WKContentView;
+OBJC_CLASS UIView;
namespace WebKit {
class ApplicationStateTracker {
public:
- ApplicationStateTracker(WKContentView *, SEL didEnterBackgroundSelector, SEL willEnterForegroundSelector);
+ ApplicationStateTracker(UIView *, SEL didEnterBackgroundSelector, SEL willEnterForegroundSelector);
~ApplicationStateTracker();
bool isInBackground() const { return m_isInBackground; }
@@ -48,7 +48,7 @@
void applicationDidEnterBackground();
void applicationWillEnterForeground();
- WeakObjCPtr<WKContentView> m_view;
+ WeakObjCPtr<UIView> m_view;
SEL m_didEnterBackgroundSelector;
SEL m_willEnterForegroundSelector;
Modified: trunk/Source/WebKit2/UIProcess/ApplicationStateTracker.mm (193480 => 193481)
--- trunk/Source/WebKit2/UIProcess/ApplicationStateTracker.mm 2015-12-04 22:54:26 UTC (rev 193480)
+++ trunk/Source/WebKit2/UIProcess/ApplicationStateTracker.mm 2015-12-04 23:09:37 UTC (rev 193481)
@@ -31,7 +31,6 @@
#import "AssertionServicesSPI.h"
#import "SandboxUtilities.h"
#import "UIKitSPI.h"
-#import "WKContentView.h"
#import <WebCore/SecuritySPI.h>
#import <wtf/NeverDestroyed.h>
#import <wtf/ObjcRuntimeExtras.h>
@@ -74,7 +73,7 @@
}
}
-ApplicationStateTracker::ApplicationStateTracker(WKContentView *view, SEL didEnterBackgroundSelector, SEL willEnterForegroundSelector)
+ApplicationStateTracker::ApplicationStateTracker(UIView *view, SEL didEnterBackgroundSelector, SEL willEnterForegroundSelector)
: m_view(view)
, m_didEnterBackgroundSelector(didEnterBackgroundSelector)
, m_willEnterForegroundSelector(willEnterForegroundSelector)
Modified: trunk/Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm (193480 => 193481)
--- trunk/Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm 2015-12-04 22:54:26 UTC (rev 193480)
+++ trunk/Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm 2015-12-04 23:09:37 UTC (rev 193481)
@@ -172,7 +172,7 @@
bool PageClientImpl::isViewVisible()
{
- if (isViewInWindow() && !m_contentView.isBackground)
+ if (isViewInWindow() && !m_webView._isBackground)
return true;
if ([m_webView _isShowingVideoPictureInPicture])
Modified: trunk/Source/WebKit2/UIProcess/ios/WKPDFView.h (193480 => 193481)
--- trunk/Source/WebKit2/UIProcess/ios/WKPDFView.h 2015-12-04 22:54:26 UTC (rev 193480)
+++ trunk/Source/WebKit2/UIProcess/ios/WKPDFView.h 2015-12-04 23:09:37 UTC (rev 193481)
@@ -34,6 +34,7 @@
@property (nonatomic, readonly) NSString *suggestedFilename;
@property (nonatomic, readonly) CGPDFDocumentRef pdfDocument;
+@property (nonatomic, readonly) BOOL isBackground;
@end
Modified: trunk/Source/WebKit2/UIProcess/ios/WKPDFView.mm (193480 => 193481)
--- trunk/Source/WebKit2/UIProcess/ios/WKPDFView.mm 2015-12-04 22:54:26 UTC (rev 193480)
+++ trunk/Source/WebKit2/UIProcess/ios/WKPDFView.mm 2015-12-04 23:09:37 UTC (rev 193481)
@@ -30,6 +30,7 @@
#import "APIFindClient.h"
#import "APIUIClient.h"
+#import "ApplicationStateTracker.h"
#import "CorePDFSPI.h"
#import "SessionState.h"
#import "UIKitSPI.h"
@@ -46,6 +47,7 @@
#import <wtf/Vector.h>
using namespace WebCore;
+using namespace WebKit;
const CGFloat pdfPageMargin = 8;
const CGFloat pdfMinimumZoomScale = 1;
@@ -108,6 +110,8 @@
dispatch_queue_t _findQueue;
RetainPtr<UIWKSelectionAssistant> _webSelectionAssistant;
+
+ std::unique_ptr<ApplicationStateTracker> _applicationStateTracker;
}
- (instancetype)web_initWithFrame:(CGRect)frame webView:(WKWebView *)webView
@@ -844,6 +848,47 @@
return NO;
}
+- (void)willMoveToWindow:(UIWindow *)newWindow
+{
+ if (newWindow)
+ return;
+
+ ASSERT(self.window);
+ ASSERT(_applicationStateTracker);
+ _applicationStateTracker = nullptr;
+}
+
+- (void)didMoveToWindow
+{
+ if (!self.window)
+ return;
+
+ ASSERT(!_applicationStateTracker);
+ _applicationStateTracker = std::make_unique<ApplicationStateTracker>(self, @selector(_applicationDidEnterBackground), @selector(_applicationWillEnterForeground));
+}
+
+- (BOOL)isBackground
+{
+ if (!_applicationStateTracker)
+ return YES;
+
+ return _applicationStateTracker->isInBackground();
+}
+
+- (void)_applicationDidEnterBackground
+{
+ _webView->_page->applicationDidEnterBackground();
+ _webView->_page->viewStateDidChange(ViewState::AllFlags & ~ViewState::IsInWindow);
+}
+
+- (void)_applicationWillEnterForeground
+{
+ _webView->_page->applicationWillEnterForeground();
+ if (auto drawingArea = _webView->_page->drawingArea())
+ drawingArea->hideContentUntilAnyUpdate();
+ _webView->_page->viewStateDidChange(ViewState::AllFlags & ~ViewState::IsInWindow, true, WebPageProxy::ViewStateChangeDispatchMode::Immediate);
+}
+
@end
#endif /* PLATFORM(IOS) */
