Title: [193875] trunk
- Revision
- 193875
- Author
- [email protected]
- Date
- 2015-12-09 15:40:18 -0800 (Wed, 09 Dec 2015)
Log Message
Modern IDB: storage/indexeddb/intversion-close-between-events.html fails.
https://bugs.webkit.org/show_bug.cgi?id=152096
Reviewed by Alex Christensen.
Source/WebCore:
No new tests (At least one failing test now passes).
* bindings/js/JSIDBDatabaseCustom.cpp:
(WebCore::JSIDBDatabase::transaction): In addition to JSArrays, treat DOMStringLists as a valid string sequence.
LayoutTests:
* platform/mac-wk1/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (193874 => 193875)
--- trunk/LayoutTests/ChangeLog 2015-12-09 23:23:57 UTC (rev 193874)
+++ trunk/LayoutTests/ChangeLog 2015-12-09 23:40:18 UTC (rev 193875)
@@ -1,5 +1,14 @@
2015-12-09 Brady Eidson <[email protected]>
+ Modern IDB: storage/indexeddb/intversion-close-between-events.html fails.
+ https://bugs.webkit.org/show_bug.cgi?id=152096
+
+ Reviewed by Alex Christensen.
+
+ * platform/mac-wk1/TestExpectations:
+
+2015-12-09 Brady Eidson <[email protected]>
+
Modern IDB: storage/indexeddb/database-closepending-flag.html fails.
https://bugs.webkit.org/show_bug.cgi?id=152095
Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (193874 => 193875)
--- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2015-12-09 23:23:57 UTC (rev 193874)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2015-12-09 23:40:18 UTC (rev 193875)
@@ -100,7 +100,6 @@
storage/indexeddb/index-count.html [ Failure ]
storage/indexeddb/index-duplicate-keypaths.html [ Failure ]
storage/indexeddb/intversion-abort-in-initial-upgradeneeded.html [ Failure ]
-storage/indexeddb/intversion-close-between-events.html [ Failure ]
storage/indexeddb/intversion-close-in-oncomplete.html [ Failure ]
storage/indexeddb/intversion-close-in-upgradeneeded.html [ Failure ]
storage/indexeddb/intversion-gated-on-delete.html [ Failure ]
Modified: trunk/Source/WebCore/ChangeLog (193874 => 193875)
--- trunk/Source/WebCore/ChangeLog 2015-12-09 23:23:57 UTC (rev 193874)
+++ trunk/Source/WebCore/ChangeLog 2015-12-09 23:40:18 UTC (rev 193875)
@@ -1,3 +1,15 @@
+2015-12-09 Brady Eidson <[email protected]>
+
+ Modern IDB: storage/indexeddb/intversion-close-between-events.html fails.
+ https://bugs.webkit.org/show_bug.cgi?id=152096
+
+ Reviewed by Alex Christensen.
+
+ No new tests (At least one failing test now passes).
+
+ * bindings/js/JSIDBDatabaseCustom.cpp:
+ (WebCore::JSIDBDatabase::transaction): In addition to JSArrays, treat DOMStringLists as a valid string sequence.
+
2015-12-09 Andreas Kling <[email protected]>
[iOS] ResourceUsageOverlay should work on iOS.
Modified: trunk/Source/WebCore/bindings/js/JSIDBDatabaseCustom.cpp (193874 => 193875)
--- trunk/Source/WebCore/bindings/js/JSIDBDatabaseCustom.cpp 2015-12-09 23:23:57 UTC (rev 193874)
+++ trunk/Source/WebCore/bindings/js/JSIDBDatabaseCustom.cpp 2015-12-09 23:40:18 UTC (rev 193875)
@@ -36,6 +36,7 @@
#include "IDBKeyPath.h"
#include "IDBObjectStore.h"
#include "JSDOMBinding.h"
+#include "JSDOMStringList.h"
#include "JSIDBObjectStore.h"
#include <runtime/Error.h>
#include <runtime/JSString.h>
@@ -93,11 +94,13 @@
Vector<String> scope;
JSValue scopeArg(exec.argument(0));
- if (scopeArg.isObject() && isJSArray(scopeArg)) {
- scope = toNativeArray<String>(&exec, scopeArg);
- if (exec.hadException())
- return jsUndefined();
- } else {
+ auto domStringList = JSDOMStringList::toWrapped(&exec, scopeArg);
+ if (exec.hadException())
+ return jsUndefined();
+
+ if (domStringList)
+ scope = Vector<String>(*domStringList);
+ else {
scope.append(scopeArg.toString(&exec)->value(&exec));
if (exec.hadException())
return jsUndefined();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
