Title: [193926] trunk/Source/WebInspectorUI
- Revision
- 193926
- Author
- [email protected]
- Date
- 2015-12-10 14:38:13 -0800 (Thu, 10 Dec 2015)
Log Message
Web Inspector: debugger popover should have source location link when showing function source
https://bugs.webkit.org/show_bug.cgi?id=151866
Reviewed by Brian Burg.
Added source code location link to function popover header.
* UserInterface/Views/SourceCodeTextEditor.js:
(WebInspector.SourceCodeTextEditor.prototype._showPopoverForFunction.didGetDetails):
Create source code location link from response payload.
(WebInspector.SourceCodeTextEditor.prototype._showPopoverForFunction):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (193925 => 193926)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-12-10 21:42:44 UTC (rev 193925)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-12-10 22:38:13 UTC (rev 193926)
@@ -1,3 +1,17 @@
+2015-12-10 Matt Baker <[email protected]>
+
+ Web Inspector: debugger popover should have source location link when showing function source
+ https://bugs.webkit.org/show_bug.cgi?id=151866
+
+ Reviewed by Brian Burg.
+
+ Added source code location link to function popover header.
+
+ * UserInterface/Views/SourceCodeTextEditor.js:
+ (WebInspector.SourceCodeTextEditor.prototype._showPopoverForFunction.didGetDetails):
+ Create source code location link from response payload.
+ (WebInspector.SourceCodeTextEditor.prototype._showPopoverForFunction):
+
2015-12-10 Nikita Vasilyev <[email protected]>
Web Inspector: [Meta] Unify z-index values in Inspector's CSS
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js (193925 => 193926)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js 2015-12-10 21:42:44 UTC (rev 193925)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js 2015-12-10 22:38:13 UTC (rev 193926)
@@ -1444,7 +1444,7 @@
_showPopoverForFunction(data)
{
- var candidate = this.tokenTrackingController.candidate;
+ let candidate = this.tokenTrackingController.candidate;
function didGetDetails(error, response)
{
@@ -1459,16 +1459,22 @@
if (candidate !== this.tokenTrackingController.candidate)
return;
- var wrapper = document.createElement("div");
- wrapper.className = "body formatted-function";
+ let wrapper = document.createElement("div");
+ wrapper.classList.add("body", "formatted-function");
wrapper.textContent = data.description;
- var content = document.createElement("div");
- content.className = "function";
+ let content = document.createElement("div");
+ content.classList.add("function");
- var title = content.appendChild(document.createElement("div"));
- title.className = "title";
+ let location = response.location;
+ let sourceCode = WebInspector.debuggerManager.scriptForIdentifier(location.scriptId);
+ let sourceCodeLocation = sourceCode.createSourceCodeLocation(location.lineNumber, location.columnNumber);
+ let functionSourceCodeLink = WebInspector.createSourceCodeLocationLink(sourceCodeLocation);
+
+ let title = content.appendChild(document.createElement("div"));
+ title.classList.add("title");
title.textContent = response.name || response.inferredName || response.displayName || WebInspector.UIString("(anonymous function)");
+ title.appendChild(functionSourceCodeLink);
content.appendChild(wrapper);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
