Diff
Modified: trunk/LayoutTests/ChangeLog (193935 => 193936)
--- trunk/LayoutTests/ChangeLog 2015-12-11 01:21:29 UTC (rev 193935)
+++ trunk/LayoutTests/ChangeLog 2015-12-11 01:35:17 UTC (rev 193936)
@@ -1,3 +1,22 @@
+2015-12-10 Brady Eidson <[email protected]>
+
+ Modern IDB: storage/indexeddb/delete-in-upgradeneeded-close-in-versionchange.html fails
+ https://bugs.webkit.org/show_bug.cgi?id=152144
+
+ Reviewed by Alex Christensen.
+
+ * platform/mac-wk1/TestExpectations:
+ * storage/indexeddb/modern/abort-requests-cancelled-expected.txt:
+ * storage/indexeddb/modern/aborted-put-expected.txt:
+ * storage/indexeddb/modern/createobjectstore-basic-expected.txt:
+ * storage/indexeddb/modern/deletedatabase-2-expected.txt:
+ * storage/indexeddb/modern/deletedatabase-2.html:
+ * storage/indexeddb/modern/deleteindex-2-expected.txt:
+ * storage/indexeddb/modern/deleteobjectstore-1-expected.txt:
+ * storage/indexeddb/modern/opendatabase-versions-expected.txt:
+ * storage/indexeddb/modern/opendatabase-versions.html:
+ * storage/indexeddb/modern/versionchange-abort-then-reopen-expected.txt:
+
2015-12-10 Ryan Haddad <[email protected]>
Rebaselining fast/text/emoji.html for Yosemite.
Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (193935 => 193936)
--- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2015-12-11 01:21:29 UTC (rev 193935)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2015-12-11 01:35:17 UTC (rev 193936)
@@ -95,7 +95,6 @@
storage/indexeddb/cursor-continue.html [ Failure ]
storage/indexeddb/database-deletepending-flag.html [ Failure ]
storage/indexeddb/delete-closed-database-object.html [ Failure ]
-storage/indexeddb/delete-in-upgradeneeded-close-in-versionchange.html [ Failure ]
storage/indexeddb/index-basics.html [ Failure ]
storage/indexeddb/index-count.html [ Failure ]
storage/indexeddb/index-duplicate-keypaths.html [ Failure ]
@@ -109,7 +108,6 @@
storage/indexeddb/intversion-two-opens-no-versions.html [ Failure ]
storage/indexeddb/intversion-upgrades.html [ Failure ]
storage/indexeddb/key-type-array.html [ Failure ]
-storage/indexeddb/lazy-index-types.html [ Failure ]
storage/indexeddb/objectstore-autoincrement.html [ Failure ]
storage/indexeddb/objectstore-count.html [ Failure ]
storage/indexeddb/open-cursor.html [ Failure ]
@@ -122,7 +120,6 @@
storage/indexeddb/properties-disabled-at-runtime.html [ Failure ]
storage/indexeddb/setversion-blocked-by-versionchange-close.html [ Failure ]
storage/indexeddb/transaction-scope-sequencing.html [ Failure ]
-storage/indexeddb/version-change-abort.html [ Failure ]
# Relies on internals.observeGC
storage/indexeddb/cursor-leak.html [ Failure ]
Modified: trunk/LayoutTests/storage/indexeddb/modern/abort-requests-cancelled-expected.txt (193935 => 193936)
--- trunk/LayoutTests/storage/indexeddb/modern/abort-requests-cancelled-expected.txt 2015-12-11 01:21:29 UTC (rev 193935)
+++ trunk/LayoutTests/storage/indexeddb/modern/abort-requests-cancelled-expected.txt 2015-12-11 01:35:17 UTC (rev 193936)
@@ -4,7 +4,6 @@
Error handling: "objectStore.put({ bar: 'B' }, 2);" (error)
Error handling: "objectStore.put({ bar: 'C' }, 3);" (error)
Initial upgrade versionchange transaction aborted
-Initial upgrade versionchange transaction error [object Event]
Second upgrade needed: Old version - 0 New version - 1
Success handling: "objectStore.put({ bar: 'A' }, 1);"
Success handling: "objectStore.put({ bar: 'B' }, 2);"
Modified: trunk/LayoutTests/storage/indexeddb/modern/aborted-put-expected.txt (193935 => 193936)
--- trunk/LayoutTests/storage/indexeddb/modern/aborted-put-expected.txt 2015-12-11 01:21:29 UTC (rev 193935)
+++ trunk/LayoutTests/storage/indexeddb/modern/aborted-put-expected.txt 2015-12-11 01:35:17 UTC (rev 193936)
@@ -11,7 +11,6 @@
ALERT: get1 'foo' succeeded - value was 'baz'
ALERT: get2 'far' succeeded - value was 'boo'
ALERT: Second version change transaction abort
-ALERT: Second version change transaction error - [object Event]
ALERT: Third upgrade needed: Old version - 1 New version - 2
ALERT: [object IDBTransaction] - versionchange
ALERT: [object IDBDatabase]
Modified: trunk/LayoutTests/storage/indexeddb/modern/createobjectstore-basic-expected.txt (193935 => 193936)
--- trunk/LayoutTests/storage/indexeddb/modern/createobjectstore-basic-expected.txt 2015-12-11 01:21:29 UTC (rev 193935)
+++ trunk/LayoutTests/storage/indexeddb/modern/createobjectstore-basic-expected.txt 2015-12-11 01:35:17 UTC (rev 193936)
@@ -4,7 +4,6 @@
ALERT: Put succeeded
ALERT: Initial upgrade versionchange transaction aborted
ALERT: Object store names:
-ALERT: Initial upgrade versionchange transaction error [object Event]
ALERT: Second upgrade needed: Old version - 0 New version - 1
ALERT: Object store names:
ALERT: Second upgrade versionchange transaction complete
Modified: trunk/LayoutTests/storage/indexeddb/modern/deletedatabase-2-expected.txt (193935 => 193936)
--- trunk/LayoutTests/storage/indexeddb/modern/deletedatabase-2-expected.txt 2015-12-11 01:21:29 UTC (rev 193935)
+++ trunk/LayoutTests/storage/indexeddb/modern/deletedatabase-2-expected.txt 2015-12-11 01:35:17 UTC (rev 193936)
@@ -4,7 +4,7 @@
Requesting deleteDatabase
First connection received versionchange event: oldVersion 1, newVersion null
First version change complete
-open db success
+Open request error: AbortError
Delete database success: oldVersion 1, newVersion null
Recreating database to make sure it's new and empty
Second upgrade old version - 0 new version - 1
Modified: trunk/LayoutTests/storage/indexeddb/modern/deletedatabase-2.html (193935 => 193936)
--- trunk/LayoutTests/storage/indexeddb/modern/deletedatabase-2.html 2015-12-11 01:21:29 UTC (rev 193935)
+++ trunk/LayoutTests/storage/indexeddb/modern/deletedatabase-2.html 2015-12-11 01:35:17 UTC (rev 193936)
@@ -29,8 +29,7 @@
}
request._onerror_ = function(e)
{
- log("Unexpected error");
- done();
+ log("Open request error: " + request.error.name);
}
request._onupgradeneeded_ = function(e)
Modified: trunk/LayoutTests/storage/indexeddb/modern/deleteindex-2-expected.txt (193935 => 193936)
--- trunk/LayoutTests/storage/indexeddb/modern/deleteindex-2-expected.txt 2015-12-11 01:21:29 UTC (rev 193935)
+++ trunk/LayoutTests/storage/indexeddb/modern/deleteindex-2-expected.txt 2015-12-11 01:35:17 UTC (rev 193936)
@@ -8,7 +8,6 @@
Deleted the index
Aborted the transaction
Second upgrade versionchange transaction abort
-Second upgrade versionchange transaction error [object Event]
Third upgrade needed: Old version - 1 New version - 3
Count is: 2
Cursor at record: A / 1
Modified: trunk/LayoutTests/storage/indexeddb/modern/deleteobjectstore-1-expected.txt (193935 => 193936)
--- trunk/LayoutTests/storage/indexeddb/modern/deleteobjectstore-1-expected.txt 2015-12-11 01:21:29 UTC (rev 193935)
+++ trunk/LayoutTests/storage/indexeddb/modern/deleteobjectstore-1-expected.txt 2015-12-11 01:35:17 UTC (rev 193936)
@@ -4,7 +4,6 @@
ALERT: Deleting object store
ALERT: Second version change transaction abort
ALERT: Request error - [object Event]
-ALERT: Second version change transaction error - [object Event]
ALERT: Success opening database connection - Starting final transaction
ALERT: Value gotten was AH AH AH AH AH
ALERT: Value gotten was AH AH AH AH AH
Modified: trunk/LayoutTests/storage/indexeddb/modern/opendatabase-versions-expected.txt (193935 => 193936)
--- trunk/LayoutTests/storage/indexeddb/modern/opendatabase-versions-expected.txt 2015-12-11 01:21:29 UTC (rev 193935)
+++ trunk/LayoutTests/storage/indexeddb/modern/opendatabase-versions-expected.txt 2015-12-11 01:35:17 UTC (rev 193936)
@@ -1,17 +1,18 @@
-ALERT: [object IDBOpenDBRequest] (firstPhase)
-ALERT: upgradeneeded (firstPhase): old version - 0 new version - 1
-ALERT: [object IDBTransaction]
-ALERT: Version change complete (firstPhase). Database version is now - 1
-ALERT: [object IDBOpenDBRequest] (secondPhase)
-ALERT: First version change successful
-ALERT: Successfully opened database at version 1 (secondPhase)
-ALERT: [object IDBOpenDBRequest] (thirdPhase)
-ALERT: upgradeneeded (thirdPhase): old version - 1 new version - 2
-ALERT: [object IDBTransaction]
-ALERT: Version change complete (thirdPhase). Database version is now - 2
-ALERT: [object IDBOpenDBRequest] (fourthPhase)
-ALERT: Version change to version 2 successful
-ALERT: Expected error (fourthPhase) - VersionError
-ALERT: Done
This test creates a new database with the default version, commits that versionchange transaction, and then reopens it at different versions to make sure the IDBOpenDBRequests behave appropriately.
+[object IDBOpenDBRequest] (firstPhase)
+upgradeneeded (firstPhase): old version - 0 new version - 1
+[object IDBTransaction]
+Version change complete (firstPhase). Database version is now - 1
+[object IDBOpenDBRequest] (secondPhase)
+Open request error (firstPhase) AbortError
+Successfully opened database at version 1 (secondPhase)
+[object IDBOpenDBRequest] (thirdPhase)
+upgradeneeded (thirdPhase): old version - 1 new version - 2
+[object IDBTransaction]
+Version change complete (thirdPhase). Database version is now - 2
+[object IDBOpenDBRequest] (fourthPhase)
+Open request error (thirdPhase) AbortError
+Expected error (fourthPhase) - VersionError
+Done
+
Modified: trunk/LayoutTests/storage/indexeddb/modern/opendatabase-versions.html (193935 => 193936)
--- trunk/LayoutTests/storage/indexeddb/modern/opendatabase-versions.html 2015-12-11 01:21:29 UTC (rev 193935)
+++ trunk/LayoutTests/storage/indexeddb/modern/opendatabase-versions.html 2015-12-11 01:35:17 UTC (rev 193936)
@@ -1,6 +1,12 @@
This test creates a new database with the default version, commits that versionchange transaction, and then reopens it at different versions to make sure the IDBOpenDBRequests behave appropriately.<br>
+<div id="logger"></div><br>
<script>
+function log(msg)
+{
+ document.getElementById("logger").innerHTML += msg + "<br>";
+}
+
if (window.testRunner) {
testRunner.waitUntilDone();
testRunner.dumpAsText();
@@ -8,44 +14,43 @@
function done()
{
- alert("Done");
+ log("Done");
if (window.testRunner)
testRunner.notifyDone();
}
var request = window.indexedDB.open("VersionTestDatabase");
-alert(request + " (firstPhase)");
+log(request + " (firstPhase)");
request._onsuccess_ = function()
{
- alert("First version change successful");
+ log("First version change successful");
}
request._onerror_ = function(e)
{
- alert("Unexpected error (firstPhase)");
- done();
+ log("Open request error (firstPhase) " + request.error.name);
}
request._onupgradeneeded_ = function(e)
{
var database = event.target.result;
- alert("upgradeneeded (firstPhase): old version - " + e.oldVersion + " new version - " + e.newVersion);
- alert(request.transaction);
+ log("upgradeneeded (firstPhase): old version - " + e.oldVersion + " new version - " + e.newVersion);
+ log(request.transaction);
request.transaction._oncomplete_ = function()
{
- alert("Version change complete (firstPhase). Database version is now - " + database.version);
+ log("Version change complete (firstPhase). Database version is now - " + database.version);
database.close();
secondPhase();
}
request.transaction._onabort_ = function()
{
- alert("Version change transaction unexpected abort! (firstPhase)");
+ log("Version change transaction unexpected abort! (firstPhase)");
done();
}
request.transaction._onerror_ = function()
{
- alert("Version change transaction unexpected error! (firstPhase)");
+ log("Version change transaction unexpected error! (firstPhase)");
done();
}
}
@@ -53,22 +58,22 @@
function secondPhase()
{
var request = window.indexedDB.open("VersionTestDatabase", 1);
- alert(request + " (secondPhase)");
+ log(request + " (secondPhase)");
request._onsuccess_ = function()
{
- alert("Successfully opened database at version 1 (secondPhase)");
+ log("Successfully opened database at version 1 (secondPhase)");
request.result.close();
request.result.close(); // Close it twice just for the heck of it
thirdPhase();
}
request._onerror_ = function(e)
{
- alert("Unexpected error (secondPhase)" + e);
+ log("Unexpected error (secondPhase)" + e);
done();
}
request._onupgradeneeded_ = function(e)
{
- alert("Unexpected upgrade needed (secondPhase)" + e);
+ log("Unexpected upgrade needed (secondPhase)" + e);
done();
}
}
@@ -76,36 +81,35 @@
function thirdPhase()
{
var request = window.indexedDB.open("VersionTestDatabase", 2);
- alert(request + " (thirdPhase)");
+ log(request + " (thirdPhase)");
request._onsuccess_ = function()
{
- alert("Version change to version 2 successful");
+ log("Version change to version 2 successful");
}
request._onerror_ = function(e)
{
- alert("Unexpected error (thirdPhase)");
- done();
+ log("Open request error (thirdPhase) " + request.error.name);
}
request._onupgradeneeded_ = function(e)
{
var database = event.target.result;
- alert("upgradeneeded (thirdPhase): old version - " + e.oldVersion + " new version - " + e.newVersion);
- alert(request.transaction);
+ log("upgradeneeded (thirdPhase): old version - " + e.oldVersion + " new version - " + e.newVersion);
+ log(request.transaction);
request.transaction._oncomplete_ = function()
{
- alert("Version change complete (thirdPhase). Database version is now - " + database.version);
+ log("Version change complete (thirdPhase). Database version is now - " + database.version);
database.close();
fourthPhase();
}
request.transaction._onabort_ = function()
{
- alert("Version change transaction unexpected abort! (thirdPhase)");
+ log("Version change transaction unexpected abort! (thirdPhase)");
done();
}
request.transaction._onerror_ = function()
{
- alert("Version change transaction unexpected error! (thirdPhase)");
+ log("Version change transaction unexpected error! (thirdPhase)");
done();
}
}
@@ -115,20 +119,20 @@
{
// We've upgraded to version 2, so version 1 should not be openable.
var request = window.indexedDB.open("VersionTestDatabase", 1);
- alert(request + " (fourthPhase)");
+ log(request + " (fourthPhase)");
request._onsuccess_ = function()
{
- alert("Unexpected success (fourthPhase)");
+ log("Unexpected success (fourthPhase)");
done();
}
request._onerror_ = function(e)
{
- alert("Expected error (fourthPhase) - " + request.error.name);
+ log("Expected error (fourthPhase) - " + request.error.name);
done();
}
request._onupgradeneeded_ = function(e)
{
- alert("Unexpected upgradeneeded (fourthPhase)");
+ log("Unexpected upgradeneeded (fourthPhase)");
done();
}
}
Modified: trunk/LayoutTests/storage/indexeddb/modern/versionchange-abort-then-reopen-expected.txt (193935 => 193936)
--- trunk/LayoutTests/storage/indexeddb/modern/versionchange-abort-then-reopen-expected.txt 2015-12-11 01:21:29 UTC (rev 193935)
+++ trunk/LayoutTests/storage/indexeddb/modern/versionchange-abort-then-reopen-expected.txt 2015-12-11 01:35:17 UTC (rev 193936)
@@ -1,11 +1,9 @@
ALERT: Initial upgrade needed: Old version - 0 New version - 1
ALERT: Initial upgrade versionchange transaction aborted
-ALERT: Initial upgrade versionchange transaction error [object Event]
ALERT: Second upgrade needed: Old version - 0 New version - 1
ALERT: Second upgrade versionchange transaction complete
ALERT: Third upgrade needed: Old version - 1 New version - 2
ALERT: Third upgrade versionchange transaction aborted
-ALERT: Third upgrade versionchange transaction error[object Event]
ALERT: Fourth upgrade needed: Old version - 1 New version - 2
ALERT: Done
This test opens a new database, then aborts the version change transaction.
Modified: trunk/Source/WebCore/ChangeLog (193935 => 193936)
--- trunk/Source/WebCore/ChangeLog 2015-12-11 01:21:29 UTC (rev 193935)
+++ trunk/Source/WebCore/ChangeLog 2015-12-11 01:35:17 UTC (rev 193936)
@@ -1,3 +1,37 @@
+2015-12-10 Brady Eidson <[email protected]>
+
+ Modern IDB: storage/indexeddb/delete-in-upgradeneeded-close-in-versionchange.html fails
+ https://bugs.webkit.org/show_bug.cgi?id=152144
+
+ Reviewed by Alex Christensen.
+
+ No new tests (At least two failing tests now pass, and other incorrect tests updated to be more correct).
+
+ - An IDBOpenDBRequest resulting in a versionchange transaction should not have the onsuccess event fire if
+ the database connection was closed during the versionchange transaction. onerror should fire instead.
+ - When firing an event at an IDBRequest, it should not have the transaction as an additional target if the
+ transaction has finished.
+ - When firing an event at an IDBRequest, it should not have the database as an additional target if the
+ database is closed or is closing.
+
+ * Modules/indexeddb/client/IDBDatabaseImpl.h:
+ (WebCore::IDBClient::IDBDatabase::isClosingOrClosed):
+
+ * Modules/indexeddb/client/IDBOpenDBRequestImpl.cpp:
+ (WebCore::IDBClient::IDBOpenDBRequest::fireErrorAfterVersionChangeCompletion):
+ (WebCore::IDBClient::IDBOpenDBRequest::fireErrorAfterVersionChangeAbort): Deleted.
+ * Modules/indexeddb/client/IDBOpenDBRequestImpl.h:
+
+ * Modules/indexeddb/client/IDBRequestImpl.cpp:
+ (WebCore::IDBClient::IDBRequest::dispatchEvent): Don't add finished transactions or closed databases as event targets.
+
+ * Modules/indexeddb/client/IDBTransactionImpl.cpp:
+ (WebCore::IDBClient::IDBTransaction::notifyDidAbort):
+ (WebCore::IDBClient::IDBTransaction::dispatchEvent): If this was a versionchange transaction completing, possibly fire
+ the error event on the OpenDBRequest instead of the success event.
+ * Modules/indexeddb/client/IDBTransactionImpl.h:
+ (WebCore::IDBClient::IDBTransaction::isFinished):
+
2015-12-10 Zalan Bujtas <[email protected]>
Simple line layout: Use TextPainter to draw simple line text.
Modified: trunk/Source/WebCore/Modules/indexeddb/client/IDBDatabaseImpl.h (193935 => 193936)
--- trunk/Source/WebCore/Modules/indexeddb/client/IDBDatabaseImpl.h 2015-12-11 01:21:29 UTC (rev 193935)
+++ trunk/Source/WebCore/Modules/indexeddb/client/IDBDatabaseImpl.h 2015-12-11 01:35:17 UTC (rev 193936)
@@ -87,6 +87,8 @@
void didCreateIndexInfo(const IDBIndexInfo&);
void didDeleteIndexInfo(const IDBIndexInfo&);
+ bool isClosingOrClosed() const { return m_closePending || m_closedInServer; }
+
private:
IDBDatabase(ScriptExecutionContext&, IDBConnectionToServer&, const IDBResultData&);
Modified: trunk/Source/WebCore/Modules/indexeddb/client/IDBOpenDBRequestImpl.cpp (193935 => 193936)
--- trunk/Source/WebCore/Modules/indexeddb/client/IDBOpenDBRequestImpl.cpp 2015-12-11 01:21:29 UTC (rev 193935)
+++ trunk/Source/WebCore/Modules/indexeddb/client/IDBOpenDBRequestImpl.cpp 2015-12-11 01:35:17 UTC (rev 193936)
@@ -86,14 +86,15 @@
enqueueEvent(Event::create(eventNames().successEvent, false, false));
}
-void IDBOpenDBRequest::fireErrorAfterVersionChangeAbort()
+void IDBOpenDBRequest::fireErrorAfterVersionChangeCompletion()
{
- LOG(IndexedDB, "IDBOpenDBRequest::fireErrorAfterVersionChangeAbort()");
+ LOG(IndexedDB, "IDBOpenDBRequest::fireErrorAfterVersionChangeCompletion()");
ASSERT(hasPendingActivity());
IDBError idbError(IDBDatabaseException::AbortError);
m_domError = DOMError::create(idbError.name());
+ m_result = IDBAny::createUndefined();
m_transaction->addRequest(*this);
enqueueEvent(Event::create(eventNames().errorEvent, true, true));
Modified: trunk/Source/WebCore/Modules/indexeddb/client/IDBOpenDBRequestImpl.h (193935 => 193936)
--- trunk/Source/WebCore/Modules/indexeddb/client/IDBOpenDBRequestImpl.h 2015-12-11 01:21:29 UTC (rev 193935)
+++ trunk/Source/WebCore/Modules/indexeddb/client/IDBOpenDBRequestImpl.h 2015-12-11 01:35:17 UTC (rev 193936)
@@ -55,7 +55,7 @@
void versionChangeTransactionWillFinish();
void fireSuccessAfterVersionChangeCommit();
- void fireErrorAfterVersionChangeAbort();
+ void fireErrorAfterVersionChangeCompletion();
private:
IDBOpenDBRequest(IDBConnectionToServer&, ScriptExecutionContext*, const IDBDatabaseIdentifier&, uint64_t version);
Modified: trunk/Source/WebCore/Modules/indexeddb/client/IDBRequestImpl.cpp (193935 => 193936)
--- trunk/Source/WebCore/Modules/indexeddb/client/IDBRequestImpl.cpp 2015-12-11 01:21:29 UTC (rev 193935)
+++ trunk/Source/WebCore/Modules/indexeddb/client/IDBRequestImpl.cpp 2015-12-11 01:35:17 UTC (rev 193936)
@@ -266,8 +266,10 @@
targets.append(this);
if (m_transaction) {
- targets.append(m_transaction);
- targets.append(m_transaction->db());
+ if (!m_transaction->isFinished())
+ targets.append(m_transaction);
+ if (!m_transaction->database().isClosingOrClosed())
+ targets.append(m_transaction->db());
}
m_hasPendingActivity = false;
Modified: trunk/Source/WebCore/Modules/indexeddb/client/IDBTransactionImpl.cpp (193935 => 193936)
--- trunk/Source/WebCore/Modules/indexeddb/client/IDBTransactionImpl.cpp 2015-12-11 01:21:29 UTC (rev 193935)
+++ trunk/Source/WebCore/Modules/indexeddb/client/IDBTransactionImpl.cpp 2015-12-11 01:35:17 UTC (rev 193936)
@@ -356,7 +356,7 @@
if (isVersionChange()) {
ASSERT(m_openDBRequest);
- m_openDBRequest->fireErrorAfterVersionChangeAbort();
+ m_openDBRequest->fireErrorAfterVersionChangeCompletion();
}
}
@@ -427,7 +427,11 @@
if (isVersionChange() && event.type() == eventNames().completeEvent) {
ASSERT(m_openDBRequest);
- m_openDBRequest->fireSuccessAfterVersionChangeCommit();
+
+ if (m_database->isClosingOrClosed())
+ m_openDBRequest->fireErrorAfterVersionChangeCompletion();
+ else
+ m_openDBRequest->fireSuccessAfterVersionChangeCommit();
}
return result;
Modified: trunk/Source/WebCore/Modules/indexeddb/client/IDBTransactionImpl.h (193935 => 193936)
--- trunk/Source/WebCore/Modules/indexeddb/client/IDBTransactionImpl.h 2015-12-11 01:21:29 UTC (rev 193935)
+++ trunk/Source/WebCore/Modules/indexeddb/client/IDBTransactionImpl.h 2015-12-11 01:35:17 UTC (rev 193936)
@@ -127,6 +127,7 @@
void operationDidComplete(TransactionOperation&);
bool isFinishedOrFinishing() const;
+ bool isFinished() const { return m_state == IndexedDB::TransactionState::Finished; }
private:
IDBTransaction(IDBDatabase&, const IDBTransactionInfo&, IDBOpenDBRequest*);
