- Revision
- 193948
- Author
- [email protected]
- Date
- 2015-12-10 23:45:09 -0800 (Thu, 10 Dec 2015)
Log Message
Binding and builtin generators should lowercase RTCXX as rtcXX and not rTCXX
https://bugs.webkit.org/show_bug.cgi?id=152121
Reviewed by Darin Adler.
Source/_javascript_Core:
* Scripts/builtins/builtins_generator.py:
(WK_lcfirst): Added RTC special rule.
Source/WebCore:
No change in behavior.
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::finishCreation): Using rtcXX in lieu of rTCXX.
* bindings/js/WebCoreJSBuiltinInternals.h:
(WebCore::JSBuiltinInternalFunctions::JSBuiltinInternalFunctions): Ditto.
(WebCore::JSBuiltinInternalFunctions::rtcPeerConnectionInternals): Added.
(WebCore::JSBuiltinInternalFunctions::visit): Ditto.
(WebCore::JSBuiltinInternalFunctions::init): Ditto.
(WebCore::JSBuiltinInternalFunctions::rTCPeerConnectionInternals): Deleted.
* bindings/js/WebCoreJSBuiltins.h:
(WebCore::JSBuiltinFunctions::JSBuiltinFunctions): Using rtcXX in lieu of rTCXX.
(WebCore::JSBuiltinFunctions::rtcPeerConnectionBuiltins): Added.
(WebCore::JSBuiltinFunctions::rtcPeerConnectionInternalsBuiltins): Added.
(WebCore::JSBuiltinFunctions::rTCPeerConnectionBuiltins): Deleted.
(WebCore::JSBuiltinFunctions::rTCPeerConnectionInternalsBuiltins): Deleted.
* bindings/scripts/CodeGenerator.pm:
(WK_lcfirst): Added RTC special rule.
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (193947 => 193948)
--- trunk/Source/_javascript_Core/ChangeLog 2015-12-11 07:31:28 UTC (rev 193947)
+++ trunk/Source/_javascript_Core/ChangeLog 2015-12-11 07:45:09 UTC (rev 193948)
@@ -1,3 +1,13 @@
+2015-12-10 Youenn Fablet <[email protected]>
+
+ Binding and builtin generators should lowercase RTCXX as rtcXX and not rTCXX
+ https://bugs.webkit.org/show_bug.cgi?id=152121
+
+ Reviewed by Darin Adler.
+
+ * Scripts/builtins/builtins_generator.py:
+ (WK_lcfirst): Added RTC special rule.
+
2015-12-09 Filip Pizlo <[email protected]>
FTL B3 should be able to run quicksort asm.js test
Modified: trunk/Source/_javascript_Core/Scripts/builtins/builtins_generator.py (193947 => 193948)
--- trunk/Source/_javascript_Core/Scripts/builtins/builtins_generator.py 2015-12-11 07:31:28 UTC (rev 193947)
+++ trunk/Source/_javascript_Core/Scripts/builtins/builtins_generator.py 2015-12-11 07:45:09 UTC (rev 193948)
@@ -44,6 +44,7 @@
str = str.replace('xML', 'xml')
str = str.replace('xSLT', 'xslt')
str = str.replace('cSS', 'css')
+ str = str.replace('rTC', 'rtc')
return str
def WK_ucfirst(str):
Modified: trunk/Source/WebCore/ChangeLog (193947 => 193948)
--- trunk/Source/WebCore/ChangeLog 2015-12-11 07:31:28 UTC (rev 193947)
+++ trunk/Source/WebCore/ChangeLog 2015-12-11 07:45:09 UTC (rev 193948)
@@ -1,3 +1,29 @@
+2015-12-10 Youenn Fablet <[email protected]>
+
+ Binding and builtin generators should lowercase RTCXX as rtcXX and not rTCXX
+ https://bugs.webkit.org/show_bug.cgi?id=152121
+
+ Reviewed by Darin Adler.
+
+ No change in behavior.
+
+ * bindings/js/JSDOMWindowBase.cpp:
+ (WebCore::JSDOMWindowBase::finishCreation): Using rtcXX in lieu of rTCXX.
+ * bindings/js/WebCoreJSBuiltinInternals.h:
+ (WebCore::JSBuiltinInternalFunctions::JSBuiltinInternalFunctions): Ditto.
+ (WebCore::JSBuiltinInternalFunctions::rtcPeerConnectionInternals): Added.
+ (WebCore::JSBuiltinInternalFunctions::visit): Ditto.
+ (WebCore::JSBuiltinInternalFunctions::init): Ditto.
+ (WebCore::JSBuiltinInternalFunctions::rTCPeerConnectionInternals): Deleted.
+ * bindings/js/WebCoreJSBuiltins.h:
+ (WebCore::JSBuiltinFunctions::JSBuiltinFunctions): Using rtcXX in lieu of rTCXX.
+ (WebCore::JSBuiltinFunctions::rtcPeerConnectionBuiltins): Added.
+ (WebCore::JSBuiltinFunctions::rtcPeerConnectionInternalsBuiltins): Added.
+ (WebCore::JSBuiltinFunctions::rTCPeerConnectionBuiltins): Deleted.
+ (WebCore::JSBuiltinFunctions::rTCPeerConnectionInternalsBuiltins): Deleted.
+ * bindings/scripts/CodeGenerator.pm:
+ (WK_lcfirst): Added RTC special rule.
+
2015-12-10 Zalan Bujtas <[email protected]>
ASSERTION FAILED: !simpleLineLayout() in WebCore::RenderText::collectSelectionRectsForLineBoxes
Modified: trunk/Source/WebCore/bindings/js/JSDOMWindowBase.cpp (193947 => 193948)
--- trunk/Source/WebCore/bindings/js/JSDOMWindowBase.cpp 2015-12-11 07:31:28 UTC (rev 193947)
+++ trunk/Source/WebCore/bindings/js/JSDOMWindowBase.cpp 2015-12-11 07:45:09 UTC (rev 193948)
@@ -127,7 +127,7 @@
#if ENABLE(MEDIA_STREAM)
#define DECLARE_GLOBAL_STATIC(name)\
GlobalPropertyInfo(\
- clientData.builtinFunctions().rTCPeerConnectionInternalsBuiltins().name##PrivateName(), m_privateFunctions.rTCPeerConnectionInternals().m_##name##Function.get() , DontDelete | ReadOnly),
+ clientData.builtinFunctions().rtcPeerConnectionInternalsBuiltins().name##PrivateName(), m_privateFunctions.rtcPeerConnectionInternals().m_##name##Function.get() , DontDelete | ReadOnly),
WEBCORE_FOREACH_RTCPEERCONNECTIONINTERNALS_BUILTIN_FUNCTION_NAME(DECLARE_GLOBAL_STATIC)
#undef DECLARE_GLOBAL_STATIC
#endif
Modified: trunk/Source/WebCore/bindings/js/WebCoreJSBuiltinInternals.h (193947 => 193948)
--- trunk/Source/WebCore/bindings/js/WebCoreJSBuiltinInternals.h 2015-12-11 07:31:28 UTC (rev 193947)
+++ trunk/Source/WebCore/bindings/js/WebCoreJSBuiltinInternals.h 2015-12-11 07:45:09 UTC (rev 193948)
@@ -53,7 +53,7 @@
, m_writableStreamInternalsFunctions(vm)
#endif
#if ENABLE(MEDIA_STREAM)
- , m_rTCPeerConnectionInternalsFunctions(vm)
+ , m_rtcPeerConnectionInternalsFunctions(vm)
#endif
{ }
@@ -63,7 +63,7 @@
WritableStreamInternalsBuiltinFunctions writableStreamInternals() { return m_writableStreamInternalsFunctions; }
#endif
#if ENABLE(MEDIA_STREAM)
- RTCPeerConnectionInternalsBuiltinFunctions rTCPeerConnectionInternals() { return m_rTCPeerConnectionInternalsFunctions; }
+ RTCPeerConnectionInternalsBuiltinFunctions rtcPeerConnectionInternals() { return m_rtcPeerConnectionInternalsFunctions; }
#endif
void visit(JSC::SlotVisitor& visitor) {
#if ENABLE(STREAMS_API)
@@ -72,7 +72,7 @@
m_writableStreamInternalsFunctions.visit(visitor);
#endif
#if ENABLE(MEDIA_STREAM)
- m_rTCPeerConnectionInternalsFunctions.visit(visitor);
+ m_rtcPeerConnectionInternalsFunctions.visit(visitor);
#endif
#ifndef SKIP_UNUSED_PARAM
UNUSED_PARAM(visitor);
@@ -85,7 +85,7 @@
m_writableStreamInternalsFunctions.init(globalObject);
#endif
#if ENABLE(MEDIA_STREAM)
- m_rTCPeerConnectionInternalsFunctions.init(globalObject);
+ m_rtcPeerConnectionInternalsFunctions.init(globalObject);
#endif
#ifndef SKIP_UNUSED_PARAM
UNUSED_PARAM(globalObject);
@@ -100,7 +100,7 @@
WritableStreamInternalsBuiltinFunctions m_writableStreamInternalsFunctions;
#endif
#if ENABLE(MEDIA_STREAM)
- RTCPeerConnectionInternalsBuiltinFunctions m_rTCPeerConnectionInternalsFunctions;
+ RTCPeerConnectionInternalsBuiltinFunctions m_rtcPeerConnectionInternalsFunctions;
#endif
};
Modified: trunk/Source/WebCore/bindings/js/WebCoreJSBuiltins.h (193947 => 193948)
--- trunk/Source/WebCore/bindings/js/WebCoreJSBuiltins.h 2015-12-11 07:31:28 UTC (rev 193947)
+++ trunk/Source/WebCore/bindings/js/WebCoreJSBuiltins.h 2015-12-11 07:45:09 UTC (rev 193948)
@@ -68,8 +68,8 @@
#if ENABLE(MEDIA_STREAM)
, m_mediaDevicesBuiltins(&vm)
, m_navigatorUserMediaBuiltins(&vm)
- , m_rTCPeerConnectionBuiltins(&vm)
- , m_rTCPeerConnectionInternalsBuiltins(&vm)
+ , m_rtcPeerConnectionBuiltins(&vm)
+ , m_rtcPeerConnectionInternalsBuiltins(&vm)
#endif
{
#if ENABLE(STREAMS_API)
@@ -78,7 +78,7 @@
m_writableStreamInternalsBuiltins.exportNames();
#endif
#if ENABLE(MEDIA_STREAM)
- m_rTCPeerConnectionInternalsBuiltins.exportNames();
+ m_rtcPeerConnectionInternalsBuiltins.exportNames();
#endif
}
#if ENABLE(STREAMS_API)
@@ -95,8 +95,8 @@
#if ENABLE(MEDIA_STREAM)
MediaDevicesBuiltinsWrapper& mediaDevicesBuiltins() { return m_mediaDevicesBuiltins; }
NavigatorUserMediaBuiltinsWrapper& navigatorUserMediaBuiltins() { return m_navigatorUserMediaBuiltins;}
- RTCPeerConnectionBuiltinsWrapper& rTCPeerConnectionBuiltins() { return m_rTCPeerConnectionBuiltins; }
- RTCPeerConnectionInternalsBuiltinsWrapper& rTCPeerConnectionInternalsBuiltins() { return m_rTCPeerConnectionInternalsBuiltins; }
+ RTCPeerConnectionBuiltinsWrapper& rtcPeerConnectionBuiltins() { return m_rtcPeerConnectionBuiltins; }
+ RTCPeerConnectionInternalsBuiltinsWrapper& rtcPeerConnectionInternalsBuiltins() { return m_rtcPeerConnectionInternalsBuiltins; }
#endif
private:
@@ -115,8 +115,8 @@
#if ENABLE(MEDIA_STREAM)
MediaDevicesBuiltinsWrapper m_mediaDevicesBuiltins;
NavigatorUserMediaBuiltinsWrapper m_navigatorUserMediaBuiltins;
- RTCPeerConnectionBuiltinsWrapper m_rTCPeerConnectionBuiltins;
- RTCPeerConnectionInternalsBuiltinsWrapper m_rTCPeerConnectionInternalsBuiltins;
+ RTCPeerConnectionBuiltinsWrapper m_rtcPeerConnectionBuiltins;
+ RTCPeerConnectionInternalsBuiltinsWrapper m_rtcPeerConnectionInternalsBuiltins;
#endif
};
Modified: trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm (193947 => 193948)
--- trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm 2015-12-11 07:31:28 UTC (rev 193947)
+++ trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm 2015-12-11 07:45:09 UTC (rev 193948)
@@ -476,6 +476,7 @@
die "Sequences must not be used as the type of an attribute, constant or exception field." if $object->GetSequenceType($type);
}
+# These match WK_lcfirst and WK_ucfirst defined in builtins_generator.py.
# Uppercase the first letter while respecting WebKit style guidelines.
# E.g., xmlEncoding becomes XMLEncoding, but xmlllang becomes Xmllang.
sub WK_ucfirst
@@ -500,6 +501,7 @@
$ret =~ s/xML/xml/ if $ret =~ /^xML/;
$ret =~ s/xSLT/xslt/ if $ret =~ /^xSLT/;
$ret =~ s/cSS/css/ if $ret =~ /^cSS/;
+ $ret =~ s/rTC/rtc/ if $ret =~ /^rTC/;
# For HTML5 FileSystem API Flags attributes.
# (create is widely used to instantiate an object and must be avoided.)
