Title: [193988] trunk
Revision
193988
Author
[email protected]
Date
2015-12-11 15:30:34 -0800 (Fri, 11 Dec 2015)

Log Message

Modern IDB: storage/indexeddb/index-basics.html fails.
https://bugs.webkit.org/show_bug.cgi?id=152190

Reviewed by Alex Christensen.

Source/WebCore:

No new tests (At least one failing test now passes).

* bindings/js/JSIDBObjectStoreCustom.cpp:
(WebCore::JSIDBObjectStore::createIndex): Custom error message for the TypeError

LayoutTests:

* platform/mac-wk1/TestExpectations:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (193987 => 193988)


--- trunk/LayoutTests/ChangeLog	2015-12-11 23:20:20 UTC (rev 193987)
+++ trunk/LayoutTests/ChangeLog	2015-12-11 23:30:34 UTC (rev 193988)
@@ -1,3 +1,12 @@
+2015-12-11  Brady Eidson  <[email protected]>
+
+        Modern IDB: storage/indexeddb/index-basics.html fails.
+        https://bugs.webkit.org/show_bug.cgi?id=152190
+
+        Reviewed by Alex Christensen.
+
+        * platform/mac-wk1/TestExpectations:
+
 2015-12-11  Keith Miller  <[email protected]>
 
         Rebaseline a failing inspector test for a new property on Function.prototype.

Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (193987 => 193988)


--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2015-12-11 23:20:20 UTC (rev 193987)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2015-12-11 23:30:34 UTC (rev 193988)
@@ -95,7 +95,6 @@
 storage/indexeddb/cursor-continue.html [ Failure ]
 storage/indexeddb/database-deletepending-flag.html [ Failure ]
 storage/indexeddb/delete-closed-database-object.html [ Failure ]
-storage/indexeddb/index-basics.html [ Failure ]
 storage/indexeddb/index-duplicate-keypaths.html [ Failure ]
 storage/indexeddb/intversion-gated-on-delete.html [ Failure ]
 storage/indexeddb/intversion-open-in-upgradeneeded.html [ Failure ]

Modified: trunk/Source/WebCore/ChangeLog (193987 => 193988)


--- trunk/Source/WebCore/ChangeLog	2015-12-11 23:20:20 UTC (rev 193987)
+++ trunk/Source/WebCore/ChangeLog	2015-12-11 23:30:34 UTC (rev 193988)
@@ -1,3 +1,15 @@
+2015-12-11  Brady Eidson  <[email protected]>
+
+        Modern IDB: storage/indexeddb/index-basics.html fails.
+        https://bugs.webkit.org/show_bug.cgi?id=152190
+
+        Reviewed by Alex Christensen.
+
+        No new tests (At least one failing test now passes).
+
+        * bindings/js/JSIDBObjectStoreCustom.cpp:
+        (WebCore::JSIDBObjectStore::createIndex): Custom error message for the TypeError
+
 2015-12-11  Jiewen Tan  <[email protected]>
 
         Strip out Referer header when requesting subresources or following links for documents with "Content-Disposition: attachment"

Modified: trunk/Source/WebCore/bindings/js/JSIDBObjectStoreCustom.cpp (193987 => 193988)


--- trunk/Source/WebCore/bindings/js/JSIDBObjectStoreCustom.cpp	2015-12-11 23:20:20 UTC (rev 193987)
+++ trunk/Source/WebCore/bindings/js/JSIDBObjectStoreCustom.cpp	2015-12-11 23:30:34 UTC (rev 193988)
@@ -120,7 +120,7 @@
 
     JSValue optionsValue = state.argument(2);
     if (!optionsValue.isUndefinedOrNull() && !optionsValue.isObject())
-        return throwTypeError(&state, "Not an object.");
+        return throwTypeError(&state, "Failed to execute 'createIndex' on 'IDBObjectStore': No function was found that matched the signature provided.");
 
     bool unique = false;
     bool multiEntry = false;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to