Title: [194009] trunk/Source/WebInspectorUI
- Revision
- 194009
- Author
- [email protected]
- Date
- 2015-12-12 09:37:35 -0800 (Sat, 12 Dec 2015)
Log Message
REGRESSION (r191613): Web Inspector: Can't type spaces when editing DOM nodes
https://bugs.webkit.org/show_bug.cgi?id=152173
Patch by Joseph Pecoraro <[email protected]> on 2015-12-12
Reviewed by Timothy Hatcher.
* UserInterface/Views/TimelineSidebarPanel.js:
(WebInspector.TimelineSidebarPanel):
Disable the keyboard shortcuts when they are created. They will be
enabled when the panel is shown / hidden. It doesn't really make sense
that these are on the sidebar panel instead of the tab, but things
will be changing in Timelines soon anyways so just fix this now.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (194008 => 194009)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-12-12 17:32:15 UTC (rev 194008)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-12-12 17:37:35 UTC (rev 194009)
@@ -1,3 +1,17 @@
+2015-12-12 Joseph Pecoraro <[email protected]>
+
+ REGRESSION (r191613): Web Inspector: Can't type spaces when editing DOM nodes
+ https://bugs.webkit.org/show_bug.cgi?id=152173
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/TimelineSidebarPanel.js:
+ (WebInspector.TimelineSidebarPanel):
+ Disable the keyboard shortcuts when they are created. They will be
+ enabled when the panel is shown / hidden. It doesn't really make sense
+ that these are on the sidebar panel instead of the tab, but things
+ will be changing in Timelines soon anyways so just fix this now.
+
2015-12-12 Nikita Vasilyev <[email protected]>
Web Inspector: "Selected Element" should use sans-serif font, not monospace
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.js (194008 => 194009)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.js 2015-12-12 17:32:15 UTC (rev 194008)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.js 2015-12-12 17:37:35 UTC (rev 194009)
@@ -175,9 +175,11 @@
this._toggleRecordingShortcut = new WebInspector.KeyboardShortcut(null, WebInspector.KeyboardShortcut.Key.Space, this._toggleRecordingOnSpacebar.bind(this));
this._toggleRecordingShortcut.implicitlyPreventsDefault = false;
+ this._toggleRecordingShortcut.disabled = true;
this._toggleNewRecordingShortcut = new WebInspector.KeyboardShortcut(WebInspector.KeyboardShortcut.Modifier.Shift, WebInspector.KeyboardShortcut.Key.Space, this._toggleNewRecordingOnSpacebar.bind(this));
this._toggleNewRecordingShortcut.implicitlyPreventsDefault = false;
+ this._toggleNewRecordingShortcut.disabled = true;
}
// Static
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
