[webkit-changes] [194073] trunk/Source/JavaScriptCore

[benjamin]

Title: [194073] trunk/Source/_javascript_Core

Revision

194073

Author

benja...@webkit.org

Date

2015-12-14 16:34:37 -0800 (Mon, 14 Dec 2015)

Log Message

Rename FTL::Output's ceil64() to doubleCeil()

Rubber-stamped by Filip Pizlo.

ceil64() was a bad name, that's the name convention we use for integers.

* ftl/FTLB3Output.h:
(JSC::FTL::Output::doubleCeil):
(JSC::FTL::Output::ceil64): Deleted.
* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::compileArithRound):

Modified Paths

• trunk/Source/_javascript_Core/ChangeLog
• trunk/Source/_javascript_Core/ftl/FTLB3Output.h
• trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp
• trunk/Source/_javascript_Core/ftl/FTLOutput.h

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (194072 => 194073)

--- trunk/Source/_javascript_Core/ChangeLog	2015-12-15 00:30:53 UTC (rev 194072)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-12-15 00:34:37 UTC (rev 194073)
@@ -1,3 +1,17 @@
+2015-12-14  Benjamin Poulain  <benja...@webkit.org>
+
+        Rename FTL::Output's ceil64() to doubleCeil()
+
+        Rubber-stamped by Filip Pizlo.
+
+        ceil64() was a bad name, that's the name convention we use for integers.
+
+        * ftl/FTLB3Output.h:
+        (JSC::FTL::Output::doubleCeil):
+        (JSC::FTL::Output::ceil64): Deleted.
+        * ftl/FTLLowerDFGToLLVM.cpp:
+        (JSC::FTL::DFG::LowerDFGToLLVM::compileArithRound):
+
 2015-12-14  Filip Pizlo  <fpi...@apple.com>
 
         FTL B3 should be able to run n-body.js

Modified: trunk/Source/_javascript_Core/ftl/FTLB3Output.h (194072 => 194073)

--- trunk/Source/_javascript_Core/ftl/FTLB3Output.h	2015-12-15 00:30:53 UTC (rev 194072)
+++ trunk/Source/_javascript_Core/ftl/FTLB3Output.h	2015-12-15 00:34:37 UTC (rev 194073)
@@ -154,7 +154,6 @@
     LValue lShr(LValue left, LValue right) { return m_block->appendNew<B3::Value>(m_proc, B3::ZShr, origin(), left, castToInt32(right)); }
     LValue bitNot(LValue);
 
-    LValue ceil64(LValue operand) { return m_block->appendNew<B3::Value>(m_proc, B3::Ceil, origin(), operand); }
     LValue ctlz32(LValue operand) { return m_block->appendNew<B3::Value>(m_proc, B3::Clz, origin(), operand); }
     LValue addWithOverflow32(LValue left, LValue right) { CRASH(); }
     LValue subWithOverflow32(LValue left, LValue right) { CRASH(); }
@@ -163,6 +162,7 @@
     LValue subWithOverflow64(LValue left, LValue right) { CRASH(); }
     LValue mulWithOverflow64(LValue left, LValue right) { CRASH(); }
     LValue doubleAbs(LValue value) { return m_block->appendNew<B3::Value>(m_proc, B3::Abs, origin(), value); }
+    LValue doubleCeil(LValue operand) { return m_block->appendNew<B3::Value>(m_proc, B3::Ceil, origin(), operand); }
 
     LValue doubleSin(LValue value) { return callWithoutSideEffects(B3::Double, sin, value); }
     LValue doubleCos(LValue value) { return callWithoutSideEffects(B3::Double, cos, value); }

Modified: trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp (194072 => 194073)

--- trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp	2015-12-15 00:30:53 UTC (rev 194072)
+++ trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp	2015-12-15 00:34:37 UTC (rev 194073)
@@ -2125,7 +2125,7 @@
         LBasicBlock continuation = FTL_NEW_BLOCK(m_out, ("ArithRound continuation"));
 
         LValue value = lowDouble(m_node->child1());
-        LValue integerValue = m_out.ceil64(value);
+        LValue integerValue = m_out.doubleCeil(value);
         ValueFromBlock integerValueResult = m_out.anchor(integerValue);
 
         LValue realPart = m_out.doubleSub(integerValue, value);

Modified: trunk/Source/_javascript_Core/ftl/FTLOutput.h (194072 => 194073)

--- trunk/Source/_javascript_Core/ftl/FTLOutput.h	2015-12-15 00:30:53 UTC (rev 194072)
+++ trunk/Source/_javascript_Core/ftl/FTLOutput.h	2015-12-15 00:34:37 UTC (rev 194073)
@@ -147,10 +147,6 @@
     
     LValue insertElement(LValue vector, LValue element, LValue index) { return buildInsertElement(m_builder, vector, element, index); }
 
-    LValue ceil64(LValue operand)
-    {
-        return call(doubleType, ceil64Intrinsic(), operand);
-    }
     LValue ctlz32(LValue operand)
     {
         return call(int32, ctlz32Intrinsic(), operand, booleanFalse);
@@ -183,6 +179,10 @@
     {
         return call(doubleType, doubleAbsIntrinsic(), value);
     }
+    LValue doubleCeil(LValue operand)
+    {
+        return call(doubleType, ceil64Intrinsic(), operand);
+    }
 
     LValue doubleSin(LValue value)
     {

_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes