Title: [194145] trunk/Websites/perf.webkit.org
- Revision
- 194145
- Author
- [email protected]
- Date
- 2015-12-16 09:32:47 -0800 (Wed, 16 Dec 2015)
Log Message
The chart status on v3 UI sometimes show wrong revision ranges
https://bugs.webkit.org/show_bug.cgi?id=152331
Reviewed by Chris Dumez.
The bug was caused by the status view not taking the data sampling that happens in TimeSeriesChart into account
when finding the previous point. Take this into account by using InteractiveTimeSeries.currentPoint(-1) which
finds the sampled data point immediately preceding the current point (at which the indicator is shown).
* public/v3/components/chart-status-view.js:
(ChartStatusView.prototype.updateStatusIfNeeded):
Modified Paths
Diff
Modified: trunk/Websites/perf.webkit.org/ChangeLog (194144 => 194145)
--- trunk/Websites/perf.webkit.org/ChangeLog 2015-12-16 17:30:49 UTC (rev 194144)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2015-12-16 17:32:47 UTC (rev 194145)
@@ -1,3 +1,17 @@
+2015-12-16 Ryosuke Niwa <[email protected]>
+
+ The chart status on v3 UI sometimes show wrong revision ranges
+ https://bugs.webkit.org/show_bug.cgi?id=152331
+
+ Reviewed by Chris Dumez.
+
+ The bug was caused by the status view not taking the data sampling that happens in TimeSeriesChart into account
+ when finding the previous point. Take this into account by using InteractiveTimeSeries.currentPoint(-1) which
+ finds the sampled data point immediately preceding the current point (at which the indicator is shown).
+
+ * public/v3/components/chart-status-view.js:
+ (ChartStatusView.prototype.updateStatusIfNeeded):
+
2015-12-15 Ryosuke Niwa <[email protected]>
Perf dashboard's cycler page should use v3 UI
Modified: trunk/Websites/perf.webkit.org/public/v3/components/chart-status-view.js (194144 => 194145)
--- trunk/Websites/perf.webkit.org/public/v3/components/chart-status-view.js 2015-12-16 17:30:49 UTC (rev 194144)
+++ trunk/Websites/perf.webkit.org/public/v3/components/chart-status-view.js 2015-12-16 17:32:47 UTC (rev 194145)
@@ -45,8 +45,6 @@
var previousPoint;
if (this._chart instanceof InteractiveTimeSeriesChart) {
- currentPoint = this._chart.currentPoint();
-
var selection = this._chart.currentSelection();
if (selection && this._usedSelection == selection)
return false;
@@ -61,8 +59,10 @@
currentPoint = data[data.length - 1];
previousPoint = data[0];
}
- } else if (currentPoint)
- previousPoint = currentPoint.series.previousPoint(currentPoint);
+ } else {
+ currentPoint = this._chart.currentPoint();
+ previousPoint = this._chart.currentPoint(-1);
+ }
} else {
var data = ""
if (!data)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
