Title: [194150] trunk/Source/WebInspectorUI
- Revision
- 194150
- Author
- [email protected]
- Date
- 2015-12-16 09:42:11 -0800 (Wed, 16 Dec 2015)
Log Message
Web Inspector: Improve copy of console message containing Array and Map output
https://bugs.webkit.org/show_bug.cgi?id=152329
Patch by Joseph Pecoraro <[email protected]> on 2015-12-16
Reviewed by Timothy Hatcher.
Introduce a real space in the content instead of style specific
margins so the existing copy/paste mechanism (innerText)
will have spaces between index/key and value.
* UserInterface/Views/ObjectTreeArrayIndexTreeElement.css:
(.object-tree-array-index .index-name): Deleted.
* UserInterface/Views/ObjectTreeArrayIndexTreeElement.js:
(WebInspector.ObjectTreeArrayIndexTreeElement.prototype._titleFragment):
(WebInspector.ObjectTreeArrayIndexTreeElement):
* UserInterface/Views/ObjectTreeMapEntryTreeElement.css:
(.object-tree-array-index.object-tree-map-entry > .titles > .title > .index-name): Deleted.
* UserInterface/Views/ObjectTreeMapEntryTreeElement.js:
(WebInspector.ObjectTreeMapEntryTreeElement.prototype.titleFragment):
(WebInspector.ObjectTreeMapEntryTreeElement):
* UserInterface/Views/ObjectTreeSetIndexTreeElement.js:
(WebInspector.ObjectTreeSetIndexTreeElement.prototype._titleFragment):
(WebInspector.ObjectTreeSetIndexTreeElement):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (194149 => 194150)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-12-16 17:40:15 UTC (rev 194149)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-12-16 17:42:11 UTC (rev 194150)
@@ -1,5 +1,30 @@
2015-12-16 Joseph Pecoraro <[email protected]>
+ Web Inspector: Improve copy of console message containing Array and Map output
+ https://bugs.webkit.org/show_bug.cgi?id=152329
+
+ Reviewed by Timothy Hatcher.
+
+ Introduce a real space in the content instead of style specific
+ margins so the existing copy/paste mechanism (innerText)
+ will have spaces between index/key and value.
+
+ * UserInterface/Views/ObjectTreeArrayIndexTreeElement.css:
+ (.object-tree-array-index .index-name): Deleted.
+ * UserInterface/Views/ObjectTreeArrayIndexTreeElement.js:
+ (WebInspector.ObjectTreeArrayIndexTreeElement.prototype._titleFragment):
+ (WebInspector.ObjectTreeArrayIndexTreeElement):
+ * UserInterface/Views/ObjectTreeMapEntryTreeElement.css:
+ (.object-tree-array-index.object-tree-map-entry > .titles > .title > .index-name): Deleted.
+ * UserInterface/Views/ObjectTreeMapEntryTreeElement.js:
+ (WebInspector.ObjectTreeMapEntryTreeElement.prototype.titleFragment):
+ (WebInspector.ObjectTreeMapEntryTreeElement):
+ * UserInterface/Views/ObjectTreeSetIndexTreeElement.js:
+ (WebInspector.ObjectTreeSetIndexTreeElement.prototype._titleFragment):
+ (WebInspector.ObjectTreeSetIndexTreeElement):
+
+2015-12-16 Joseph Pecoraro <[email protected]>
+
Web Inspector: Typing object literal in the console causes a parse error
https://bugs.webkit.org/show_bug.cgi?id=141737
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeArrayIndexTreeElement.css (194149 => 194150)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeArrayIndexTreeElement.css 2015-12-16 17:40:15 UTC (rev 194149)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeArrayIndexTreeElement.css 2015-12-16 17:42:11 UTC (rev 194150)
@@ -46,7 +46,6 @@
display: inline-block;
width: 30px;
- margin-right: 7px;
text-align: right;
}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeArrayIndexTreeElement.js (194149 => 194150)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeArrayIndexTreeElement.js 2015-12-16 17:40:15 UTC (rev 194149)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeArrayIndexTreeElement.js 2015-12-16 17:42:11 UTC (rev 194150)
@@ -60,6 +60,9 @@
nameElement.textContent = this.property.name;
nameElement.title = this.propertyPathString(this.thisPropertyPath());
+ // Space. For copy/paste to have space between the index and value.
+ container.append(" ");
+
// Value.
var valueElement = container.appendChild(document.createElement("span"));
valueElement.className = "index-value";
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeMapEntryTreeElement.css (194149 => 194150)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeMapEntryTreeElement.css 2015-12-16 17:40:15 UTC (rev 194149)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeMapEntryTreeElement.css 2015-12-16 17:42:11 UTC (rev 194150)
@@ -26,7 +26,6 @@
.object-tree-array-index.object-tree-map-entry > .titles > .title > .index-name {
width: 40px;
text-align: right;
- margin-right: 5px;
}
.object-tree-map-entry.key:not(:first-child) {
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeMapEntryTreeElement.js (194149 => 194150)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeMapEntryTreeElement.js 2015-12-16 17:40:15 UTC (rev 194149)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeMapEntryTreeElement.js 2015-12-16 17:42:11 UTC (rev 194150)
@@ -69,6 +69,9 @@
nameElement.textContent = this.displayPropertyName();
nameElement.title = this.propertyPathString(propertyPath);
+ // Space. For copy/paste to have space between the key and value.
+ container.append(" ");
+
// Value.
var valueElement = container.appendChild(document.createElement("span"));
valueElement.className = "index-value";
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeSetIndexTreeElement.js (194149 => 194150)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeSetIndexTreeElement.js 2015-12-16 17:40:15 UTC (rev 194149)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeSetIndexTreeElement.js 2015-12-16 17:42:11 UTC (rev 194150)
@@ -71,6 +71,9 @@
nameElement.textContent = "\u2022";
nameElement.title = WebInspector.UIString("Unable to determine path to property from root");
+ // Space. For copy/paste to have space between the bullet and value.
+ container.append(" ");
+
// Value.
var valueElement = container.appendChild(document.createElement("span"));
valueElement.className = "index-value";
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
