Title: [194220] trunk/Websites/perf.webkit.org
- Revision
- 194220
- Author
- [email protected]
- Date
- 2015-12-17 10:33:09 -0800 (Thu, 17 Dec 2015)
Log Message
Closing a pane on v3 UI always closes the last pane
https://bugs.webkit.org/show_bug.cgi?id=152388
Reviewed by Chris Dumez.
The bug was caused by closePane being called without arguments. (The first argument to bind is "this" value.)
Fixed it by passing in "this" pane object to the first argument.
* public/v3/pages/chart-pane.js:
(ChartPane):
Modified Paths
Diff
Modified: trunk/Websites/perf.webkit.org/ChangeLog (194219 => 194220)
--- trunk/Websites/perf.webkit.org/ChangeLog 2015-12-17 17:58:11 UTC (rev 194219)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2015-12-17 18:33:09 UTC (rev 194220)
@@ -1,3 +1,16 @@
+2015-12-17 Ryosuke Niwa <[email protected]>
+
+ Closing a pane on v3 UI always closes the last pane
+ https://bugs.webkit.org/show_bug.cgi?id=152388
+
+ Reviewed by Chris Dumez.
+
+ The bug was caused by closePane being called without arguments. (The first argument to bind is "this" value.)
+ Fixed it by passing in "this" pane object to the first argument.
+
+ * public/v3/pages/chart-pane.js:
+ (ChartPane):
+
2015-12-16 Ryosuke Niwa <[email protected]>
Perf Dashboard v3 UI doesn't show recent data points on v2 UI
Modified: trunk/Websites/perf.webkit.org/public/v3/pages/chart-pane.js (194219 => 194220)
--- trunk/Websites/perf.webkit.org/public/v3/pages/chart-pane.js 2015-12-17 17:58:11 UTC (rev 194219)
+++ trunk/Websites/perf.webkit.org/public/v3/pages/chart-pane.js 2015-12-17 18:33:09 UTC (rev 194220)
@@ -24,7 +24,7 @@
this._paneOpenedByClick = null;
this._commitLogViewer = this.content().querySelector('commit-log-viewer').component();
- this.content().querySelector('close-button').component().setCallback(chartsPage.closePane.bind(chartsPage));
+ this.content().querySelector('close-button').component().setCallback(chartsPage.closePane.bind(chartsPage, this));
if (result.error)
return;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
