Title: [194232] trunk/Websites/perf.webkit.org
- Revision
- 194232
- Author
- [email protected]
- Date
- 2015-12-17 14:13:45 -0800 (Thu, 17 Dec 2015)
Log Message
Dashboard charts should have uniform widths on v3 UI
https://bugs.webkit.org/show_bug.cgi?id=152395
Reviewed by Chris Dumez.
Fix the bug by applying table-layout: fixed on the dashboard table.
* public/v3/pages/dashboard-page.js:
(DashboardPage.prototype.render): Added header-column as a class name to explicitly set the header column with.
(DashboardPage.cssTemplate): Adjusted CSS accordingly.
Modified Paths
Diff
Modified: trunk/Websites/perf.webkit.org/ChangeLog (194231 => 194232)
--- trunk/Websites/perf.webkit.org/ChangeLog 2015-12-17 22:11:59 UTC (rev 194231)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2015-12-17 22:13:45 UTC (rev 194232)
@@ -1,5 +1,18 @@
2015-12-17 Ryosuke Niwa <[email protected]>
+ Dashboard charts should have uniform widths on v3 UI
+ https://bugs.webkit.org/show_bug.cgi?id=152395
+
+ Reviewed by Chris Dumez.
+
+ Fix the bug by applying table-layout: fixed on the dashboard table.
+
+ * public/v3/pages/dashboard-page.js:
+ (DashboardPage.prototype.render): Added header-column as a class name to explicitly set the header column with.
+ (DashboardPage.cssTemplate): Adjusted CSS accordingly.
+
+2015-12-17 Ryosuke Niwa <[email protected]>
+
Closing a pane on v3 UI always closes the last pane
https://bugs.webkit.org/show_bug.cgi?id=152388
Modified: trunk/Websites/perf.webkit.org/public/v3/pages/dashboard-page.js (194231 => 194232)
--- trunk/Websites/perf.webkit.org/public/v3/pages/dashboard-page.js 2015-12-17 22:11:59 UTC (rev 194231)
+++ trunk/Websites/perf.webkit.org/public/v3/pages/dashboard-page.js 2015-12-17 22:13:45 UTC (rev 194232)
@@ -92,7 +92,11 @@
var tree = [];
for (var group of this._tableGroups) {
tree.push(element('thead', element('tr',
- group[0].map(function (cell) { return element('td', cell.content || cell); }))));
+ group[0].map(function (cell, cellIndex) {
+ if (!cellIndex)
+ return element('th', {class: 'heading-column'});
+ return element('td', cell.content || cell);
+ }))));
tree.push(element('tbody', group.slice(1).map(function (row) {
return element('tr', row.map(function (cell, cellIndex) {
@@ -164,6 +168,9 @@
static cssTemplate()
{
return `
+ .dashboard-table {
+ table-layout: fixed;
+ }
.dashboard-table td,
.dashboard-table th {
border: none;
@@ -183,6 +190,10 @@
width: 2rem;
position: relative;
}
+ .dashboard-table .heading-column {
+ width: 2rem;
+ height: 1rem;
+ }
.dashboard-table th .vertical-label {
position: absolute;
left: 0;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
