Title: [194240] trunk/Websites/perf.webkit.org
- Revision
- 194240
- Author
- [email protected]
- Date
- 2015-12-17 15:02:25 -0800 (Thu, 17 Dec 2015)
Log Message
v3 UI shouldn't open/close pane selector by mouseenter/leave
https://bugs.webkit.org/show_bug.cgi?id=152399
Reviewed by Andreas Kling.
Removed the code to open and close the pane selector by mouseenter and mouseleave
since multiple people have complained about the behavior.
* public/v3/pages/charts-toolbar.js:
(ChartsToolbar): Removed the event listeners.
(ChartsToolbar.prototype._addPane): Don't close the pane selector when adding a new pane
to better support the use case of adding multiple panes.
(ChartsToolbar.cssTemplate): Tweaked CSS.
Modified Paths
Diff
Modified: trunk/Websites/perf.webkit.org/ChangeLog (194239 => 194240)
--- trunk/Websites/perf.webkit.org/ChangeLog 2015-12-17 22:57:13 UTC (rev 194239)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2015-12-17 23:02:25 UTC (rev 194240)
@@ -1,5 +1,21 @@
2015-12-17 Ryosuke Niwa <[email protected]>
+ v3 UI shouldn't open/close pane selector by mouseenter/leave
+ https://bugs.webkit.org/show_bug.cgi?id=152399
+
+ Reviewed by Andreas Kling.
+
+ Removed the code to open and close the pane selector by mouseenter and mouseleave
+ since multiple people have complained about the behavior.
+
+ * public/v3/pages/charts-toolbar.js:
+ (ChartsToolbar): Removed the event listeners.
+ (ChartsToolbar.prototype._addPane): Don't close the pane selector when adding a new pane
+ to better support the use case of adding multiple panes.
+ (ChartsToolbar.cssTemplate): Tweaked CSS.
+
+2015-12-17 Ryosuke Niwa <[email protected]>
+
Popover for analysis tasks shows up at the left edge of annotation bars in the v3 UI
https://bugs.webkit.org/show_bug.cgi?id=152389
Modified: trunk/Websites/perf.webkit.org/public/v3/pages/charts-toolbar.js (194239 => 194240)
--- trunk/Websites/perf.webkit.org/public/v3/pages/charts-toolbar.js 2015-12-17 22:57:13 UTC (rev 194239)
+++ trunk/Websites/perf.webkit.org/public/v3/pages/charts-toolbar.js 2015-12-17 23:02:25 UTC (rev 194240)
@@ -18,26 +18,8 @@
this._paneSelector.setCallback(this._addPane.bind(this));
this._paneSelectorOpener.addEventListener('click', this._togglePaneSelector.bind(this));
-
- var self = this;
- this._paneSelectorOpener.addEventListener('mouseenter', function () {
- self._openPaneSelector(false);
- temporarilyIgnoreMouseleave = true;
- setTimeout(function () { temporarilyIgnoreMouseleave = false; }, 0);
- });
- this._paneSelectorContainer.style.display = 'none';
- var temporarilyIgnoreMouseleave = false;
- this._paneSelectorContainer.addEventListener('mousemove', function () {
- temporarilyIgnoreMouseleave = true; // Workaround webkit.org/b/152170
- setTimeout(function () { temporarilyIgnoreMouseleave = false; }, 0);
- });
- this._paneSelectorContainer.addEventListener('mouseleave', function (event) {
- setTimeout(function () {
- if (!temporarilyIgnoreMouseleave)
- self._closePaneSelector();
- }, 0);
- });
+ this._paneSelectorContainer.style.display = 'none';
}
render()
@@ -75,7 +57,6 @@
this._numberOfDaysCallback(numberOfDays, event.type == 'change');
}
-
_togglePaneSelector(event)
{
event.preventDefault();
@@ -107,11 +88,8 @@
_addPane(platform, metric)
{
- if (!this._addPaneCallback)
- return;
-
- this._closePaneSelector();
- this._addPaneCallback(platform, metric);
+ if (this._addPaneCallback)
+ this._addPaneCallback(platform, metric);
}
@@ -135,6 +113,10 @@
{
return Toolbar.cssTemplate() + `
+ .charts-toolbar > .buttoned-toolbar:first-child {
+ margin-right: 0.5rem;
+ }
+
.buttoned-toolbar li a.pane-selector-opener:hover {
background: rgba(204, 153, 51, 0.1);
}
@@ -153,6 +135,7 @@
}
.start-time-slider {
+ padding-left: 1rem;
line-height: 1em;
font-size: 0.9rem;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
