Title: [194244] trunk/Source/WebInspectorUI
- Revision
- 194244
- Author
- [email protected]
- Date
- 2015-12-17 15:53:51 -0800 (Thu, 17 Dec 2015)
Log Message
Web Inspector: control whether to collect and dump protocol messages using a WebInspector.Setting
https://bugs.webkit.org/show_bug.cgi?id=151635
Reviewed by Joseph Pecoraro.
Follow-up fix to stop double-logging everything.
* UserInterface/Protocol/LoggingProtocolTracer.js:
(WebInspector.LoggingProtocolTracer.prototype._processEntry):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (194243 => 194244)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-12-17 23:37:51 UTC (rev 194243)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-12-17 23:53:51 UTC (rev 194244)
@@ -1,3 +1,15 @@
+2015-12-17 Brian Burg <[email protected]>
+
+ Web Inspector: control whether to collect and dump protocol messages using a WebInspector.Setting
+ https://bugs.webkit.org/show_bug.cgi?id=151635
+
+ Reviewed by Joseph Pecoraro.
+
+ Follow-up fix to stop double-logging everything.
+
+ * UserInterface/Protocol/LoggingProtocolTracer.js:
+ (WebInspector.LoggingProtocolTracer.prototype._processEntry):
+
2015-12-17 Joseph Pecoraro <[email protected]>
Web Inspector: Improve console.trace, make it more like console.assert and inline the message
Modified: trunk/Source/WebInspectorUI/UserInterface/Protocol/LoggingProtocolTracer.js (194243 => 194244)
--- trunk/Source/WebInspectorUI/UserInterface/Protocol/LoggingProtocolTracer.js 2015-12-17 23:37:51 UTC (rev 194243)
+++ trunk/Source/WebInspectorUI/UserInterface/Protocol/LoggingProtocolTracer.js 2015-12-17 23:53:51 UTC (rev 194244)
@@ -118,7 +118,7 @@
this._logToConsole(`time-stats: Handling: ${entry.timings.dispatch || NaN}ms; RTT: ${entry.timings.rtt}ms`);
else if (entry.timings.dispatch)
this._logToConsole(`time-stats: Handling: ${entry.timings.dispatch || NaN}ms`);
- } else if (this._dumpMessagesToConsole)
+ } else if (this._dumpMessagesToConsole && !entry.timings)
this._logToConsole(`${entry.type}: ${entry.message}`);
}
};
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes