Title: [194245] trunk/Source
Revision
194245
Author
[email protected]
Date
2015-12-17 16:04:58 -0800 (Thu, 17 Dec 2015)

Log Message

ViewportConfiguration functions should return a bool to say if anything changed
https://bugs.webkit.org/show_bug.cgi?id=152353

Reviewed by Tim Horton.

Rather than callers all checking whether setting ViewportConfiguration values
changes state, have its functions return a bool if the values change.

Source/WebCore:

* page/ViewportConfiguration.cpp:
(WebCore::ViewportConfiguration::setContentsSize):
(WebCore::ViewportConfiguration::setMinimumLayoutSize):
(WebCore::ViewportConfiguration::setViewportArguments):
(WebCore::ViewportConfiguration::setCanIgnoreScalingConstraints):
* page/ViewportConfiguration.h:
(WebCore::ViewportConfiguration::setCanIgnoreScalingConstraints): Deleted.

Source/WebKit2:

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::mainFrameDidLayout):
(WebKit::WebPage::didCommitLoad):
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::viewportPropertiesDidChange):
(WebKit::WebPage::setViewportConfigurationMinimumLayoutSize):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (194244 => 194245)


--- trunk/Source/WebCore/ChangeLog	2015-12-17 23:53:51 UTC (rev 194244)
+++ trunk/Source/WebCore/ChangeLog	2015-12-18 00:04:58 UTC (rev 194245)
@@ -1,3 +1,21 @@
+2015-12-16  Simon Fraser  <[email protected]>
+
+        ViewportConfiguration functions should return a bool to say if anything changed
+        https://bugs.webkit.org/show_bug.cgi?id=152353
+
+        Reviewed by Tim Horton.
+
+        Rather than callers all checking whether setting ViewportConfiguration values
+        changes state, have its functions return a bool if the values change.
+
+        * page/ViewportConfiguration.cpp:
+        (WebCore::ViewportConfiguration::setContentsSize):
+        (WebCore::ViewportConfiguration::setMinimumLayoutSize):
+        (WebCore::ViewportConfiguration::setViewportArguments):
+        (WebCore::ViewportConfiguration::setCanIgnoreScalingConstraints):
+        * page/ViewportConfiguration.h:
+        (WebCore::ViewportConfiguration::setCanIgnoreScalingConstraints): Deleted.
+
 2015-12-16  Joseph Pecoraro  <[email protected]>
 
         Web Inspector: Add JSContext Script Profiling

Modified: trunk/Source/WebKit2/ChangeLog (194244 => 194245)


--- trunk/Source/WebKit2/ChangeLog	2015-12-17 23:53:51 UTC (rev 194244)
+++ trunk/Source/WebKit2/ChangeLog	2015-12-18 00:04:58 UTC (rev 194245)
@@ -1,3 +1,20 @@
+2015-12-16  Simon Fraser  <[email protected]>
+
+        ViewportConfiguration functions should return a bool to say if anything changed
+        https://bugs.webkit.org/show_bug.cgi?id=152353
+
+        Reviewed by Tim Horton.
+
+        Rather than callers all checking whether setting ViewportConfiguration values
+        changes state, have its functions return a bool if the values change.
+
+        * WebProcess/WebPage/WebPage.cpp:
+        (WebKit::WebPage::mainFrameDidLayout):
+        (WebKit::WebPage::didCommitLoad):
+        * WebProcess/WebPage/ios/WebPageIOS.mm:
+        (WebKit::WebPage::viewportPropertiesDidChange):
+        (WebKit::WebPage::setViewportConfigurationMinimumLayoutSize):
+
 2015-12-16  Alex Christensen  <[email protected]>
 
         Progress towards implementing downloads with NetworkSession
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to