Title: [194258] trunk/Source/WebInspectorUI
- Revision
- 194258
- Author
- [email protected]
- Date
- 2015-12-17 20:14:40 -0800 (Thu, 17 Dec 2015)
Log Message
Web Inspector: CSS warning's fake CallFrame is not creating a valid payload
https://bugs.webkit.org/show_bug.cgi?id=152413
Patch by Joseph Pecoraro <[email protected]> on 2015-12-17
Reviewed by Timothy Hatcher.
* UserInterface/Views/ConsoleMessageView.js:
(WebInspector.ConsoleMessageView.prototype._appendLocationLink):
This attempts to create a CallFrame from a Console.CallFrame payload,
but this was missing the required functionName string parameter.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (194257 => 194258)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-12-18 04:00:29 UTC (rev 194257)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-12-18 04:14:40 UTC (rev 194258)
@@ -1,5 +1,17 @@
2015-12-17 Joseph Pecoraro <[email protected]>
+ Web Inspector: CSS warning's fake CallFrame is not creating a valid payload
+ https://bugs.webkit.org/show_bug.cgi?id=152413
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/ConsoleMessageView.js:
+ (WebInspector.ConsoleMessageView.prototype._appendLocationLink):
+ This attempts to create a CallFrame from a Console.CallFrame payload,
+ but this was missing the required functionName string parameter.
+
+2015-12-17 Joseph Pecoraro <[email protected]>
+
Provide a way to distinguish a nested lexical block from a function's lexical block
https://bugs.webkit.org/show_bug.cgi?id=152361
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js (194257 => 194258)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js 2015-12-18 04:00:29 UTC (rev 194257)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js 2015-12-18 04:14:40 UTC (rev 194258)
@@ -323,6 +323,7 @@
} else if (this._message.url && !this._shouldHideURL(this._message.url)) {
// CSS warnings have no stack traces.
callFrame = WebInspector.CallFrame.fromPayload({
+ functionName: "",
url: this._message.url,
lineNumber: this._message.line,
columnNumber: this._message.column
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes