Diff
Modified: trunk/Source/WebCore/ChangeLog (194321 => 194322)
--- trunk/Source/WebCore/ChangeLog 2015-12-20 20:08:36 UTC (rev 194321)
+++ trunk/Source/WebCore/ChangeLog 2015-12-20 21:57:01 UTC (rev 194322)
@@ -1,3 +1,17 @@
+2015-12-20 Dan Bernstein <[email protected]>
+
+ Remove unused setToolbarHeight
+ https://bugs.webkit.org/show_bug.cgi?id=152466
+
+ Reviewed by Darin Adler.
+
+ * inspector/InspectorFrontendClient.h:
+ * inspector/InspectorFrontendHost.cpp:
+ (WebCore::InspectorFrontendHost::setToolbarHeight): Deleted.
+ * inspector/InspectorFrontendHost.h:
+ * inspector/InspectorFrontendHost.idl:
+ * testing/Internals.cpp:
+
2015-12-20 Commit Queue <[email protected]>
Unreviewed, rolling out r194033 and r194267.
Modified: trunk/Source/WebCore/inspector/InspectorFrontendClient.h (194321 => 194322)
--- trunk/Source/WebCore/inspector/InspectorFrontendClient.h 2015-12-20 20:08:36 UTC (rev 194321)
+++ trunk/Source/WebCore/inspector/InspectorFrontendClient.h 2015-12-20 21:57:01 UTC (rev 194322)
@@ -64,8 +64,6 @@
WEBCORE_EXPORT virtual void changeAttachedWindowHeight(unsigned) = 0;
WEBCORE_EXPORT virtual void changeAttachedWindowWidth(unsigned) = 0;
- virtual void setToolbarHeight(unsigned) = 0;
-
WEBCORE_EXPORT virtual void openInNewTab(const String& url) = 0;
virtual bool canSave() = 0;
Modified: trunk/Source/WebCore/inspector/InspectorFrontendHost.cpp (194321 => 194322)
--- trunk/Source/WebCore/inspector/InspectorFrontendHost.cpp 2015-12-20 20:08:36 UTC (rev 194321)
+++ trunk/Source/WebCore/inspector/InspectorFrontendHost.cpp 2015-12-20 21:57:01 UTC (rev 194322)
@@ -208,12 +208,6 @@
m_client->changeAttachedWindowWidth(width);
}
-void InspectorFrontendHost::setToolbarHeight(unsigned height)
-{
- if (m_client)
- m_client->setToolbarHeight(height);
-}
-
void InspectorFrontendHost::startWindowDrag()
{
if (m_client)
Modified: trunk/Source/WebCore/inspector/InspectorFrontendHost.h (194321 => 194322)
--- trunk/Source/WebCore/inspector/InspectorFrontendHost.h 2015-12-20 20:08:36 UTC (rev 194321)
+++ trunk/Source/WebCore/inspector/InspectorFrontendHost.h 2015-12-20 21:57:01 UTC (rev 194322)
@@ -64,7 +64,6 @@
void setAttachedWindowHeight(unsigned);
void setAttachedWindowWidth(unsigned);
- void setToolbarHeight(unsigned);
void startWindowDrag();
void moveWindowBy(float x, float y) const;
Modified: trunk/Source/WebCore/inspector/InspectorFrontendHost.idl (194321 => 194322)
--- trunk/Source/WebCore/inspector/InspectorFrontendHost.idl 2015-12-20 20:08:36 UTC (rev 194321)
+++ trunk/Source/WebCore/inspector/InspectorFrontendHost.idl 2015-12-20 21:57:01 UTC (rev 194322)
@@ -46,7 +46,6 @@
void setAttachedWindowHeight(unsigned long height);
void setAttachedWindowWidth(unsigned long width);
- void setToolbarHeight(unrestricted float height);
void startWindowDrag();
void moveWindowBy(unrestricted float x, unrestricted float y);
Modified: trunk/Source/WebCore/testing/Internals.cpp (194321 => 194322)
--- trunk/Source/WebCore/testing/Internals.cpp 2015-12-20 20:08:36 UTC (rev 194321)
+++ trunk/Source/WebCore/testing/Internals.cpp 2015-12-20 21:57:01 UTC (rev 194322)
@@ -234,7 +234,6 @@
protected:
virtual void setAttachedWindowHeight(unsigned) override { }
virtual void setAttachedWindowWidth(unsigned) override { }
- virtual void setToolbarHeight(unsigned) override { }
public:
// Inspector::FrontendChannel API
Modified: trunk/Source/WebInspectorUI/ChangeLog (194321 => 194322)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-12-20 20:08:36 UTC (rev 194321)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-12-20 21:57:01 UTC (rev 194322)
@@ -1,3 +1,15 @@
+2015-12-20 Dan Bernstein <[email protected]>
+
+ Remove unused setToolbarHeight
+ https://bugs.webkit.org/show_bug.cgi?id=152466
+
+ Reviewed by Darin Adler.
+
+ * UserInterface/Base/Main.js:
+ (WebInspector.contentLoaded):
+ * UserInterface/Protocol/InspectorFrontendHostStub.js:
+ (window.InspectorFrontendHost.WebInspector.InspectorFrontendHostStub.prototype.setToolbarHeight): Deleted.
+
2015-12-19 Dan Bernstein <[email protected]>
[Mac] WebKit contains dead source code for OS X Mavericks and earlier
Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Main.js (194321 => 194322)
--- trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2015-12-20 20:08:36 UTC (rev 194321)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2015-12-20 21:57:01 UTC (rev 194322)
@@ -366,7 +366,6 @@
this._dockingAvailable = false;
this._updateDockNavigationItems();
- this._updateToolbarHeight();
this._setupViewHierarchy();
// These tabs are always available for selecting, modulo isTabAllowed().
@@ -1436,12 +1435,6 @@
this._tabBrowserSizeDidChange();
};
-WebInspector._updateToolbarHeight = function()
-{
- if (WebInspector.Platform.name === "mac" && WebInspector.Platform.version.release < 10)
- InspectorFrontendHost.setToolbarHeight(this.toolbar.element.offsetHeight);
-};
-
WebInspector._setupViewHierarchy = function()
{
let rootView = WebInspector.View.rootView();
Modified: trunk/Source/WebInspectorUI/UserInterface/Protocol/InspectorFrontendHostStub.js (194321 => 194322)
--- trunk/Source/WebInspectorUI/UserInterface/Protocol/InspectorFrontendHostStub.js 2015-12-20 20:08:36 UTC (rev 194321)
+++ trunk/Source/WebInspectorUI/UserInterface/Protocol/InspectorFrontendHostStub.js 2015-12-20 21:57:01 UTC (rev 194322)
@@ -84,10 +84,6 @@
{
},
- setToolbarHeight: function(width)
- {
- },
-
startWindowDrag: function()
{
},
Modified: trunk/Source/WebKit/ios/ChangeLog (194321 => 194322)
--- trunk/Source/WebKit/ios/ChangeLog 2015-12-20 20:08:36 UTC (rev 194321)
+++ trunk/Source/WebKit/ios/ChangeLog 2015-12-20 21:57:01 UTC (rev 194322)
@@ -1,3 +1,13 @@
+2015-12-20 Dan Bernstein <[email protected]>
+
+ Remove unused setToolbarHeight
+ https://bugs.webkit.org/show_bug.cgi?id=152466
+
+ Reviewed by Darin Adler.
+
+ * WebCoreSupport/WebInspectorClientIOS.mm:
+ (WebInspectorFrontendClient::setToolbarHeight): Deleted.
+
2015-12-18 Simon Fraser <[email protected]>
Turn off "shrink-to-fit" viewport scaling in UIWebViews
Modified: trunk/Source/WebKit/ios/WebCoreSupport/WebInspectorClientIOS.mm (194321 => 194322)
--- trunk/Source/WebKit/ios/WebCoreSupport/WebInspectorClientIOS.mm 2015-12-20 20:08:36 UTC (rev 194321)
+++ trunk/Source/WebKit/ios/WebCoreSupport/WebInspectorClientIOS.mm 2015-12-20 21:57:01 UTC (rev 194322)
@@ -128,7 +128,6 @@
void WebInspectorFrontendClient::detachWindow() { }
void WebInspectorFrontendClient::setAttachedWindowHeight(unsigned) { }
void WebInspectorFrontendClient::setAttachedWindowWidth(unsigned) { }
-void WebInspectorFrontendClient::setToolbarHeight(unsigned) { }
void WebInspectorFrontendClient::startWindowDrag() { }
void WebInspectorFrontendClient::inspectedURLChanged(const String&) { }
void WebInspectorFrontendClient::updateWindowTitle() const { }
Modified: trunk/Source/WebKit/mac/ChangeLog (194321 => 194322)
--- trunk/Source/WebKit/mac/ChangeLog 2015-12-20 20:08:36 UTC (rev 194321)
+++ trunk/Source/WebKit/mac/ChangeLog 2015-12-20 21:57:01 UTC (rev 194322)
@@ -1,3 +1,14 @@
+2015-12-20 Dan Bernstein <[email protected]>
+
+ Remove unused setToolbarHeight
+ https://bugs.webkit.org/show_bug.cgi?id=152466
+
+ Reviewed by Darin Adler.
+
+ * WebCoreSupport/WebInspectorClient.h:
+ * WebCoreSupport/WebInspectorClient.mm::
+ (WebInspectorFrontendClient::setToolbarHeight): Deleted.
+
2015-12-19 Dan Bernstein <[email protected]>
[Mac] WebKit contains dead source code for OS X Mavericks and earlier
Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.h (194321 => 194322)
--- trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.h 2015-12-20 20:08:36 UTC (rev 194321)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.h 2015-12-20 21:57:01 UTC (rev 194322)
@@ -119,7 +119,6 @@
virtual void setAttachedWindowHeight(unsigned height) override;
virtual void setAttachedWindowWidth(unsigned height) override;
- virtual void setToolbarHeight(unsigned) override;
virtual void inspectedURLChanged(const String& newURL) override;
Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm (194321 => 194322)
--- trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm 2015-12-20 20:08:36 UTC (rev 194321)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm 2015-12-20 21:57:01 UTC (rev 194322)
@@ -272,10 +272,6 @@
// Dock to right is not implemented in WebKit 1.
}
-void WebInspectorFrontendClient::setToolbarHeight(unsigned height)
-{
-}
-
void WebInspectorFrontendClient::inspectedURLChanged(const String& newURL)
{
m_inspectedURL = newURL;
Modified: trunk/Source/WebKit/win/ChangeLog (194321 => 194322)
--- trunk/Source/WebKit/win/ChangeLog 2015-12-20 20:08:36 UTC (rev 194321)
+++ trunk/Source/WebKit/win/ChangeLog 2015-12-20 21:57:01 UTC (rev 194322)
@@ -1,3 +1,14 @@
+2015-12-20 Dan Bernstein <[email protected]>
+
+ Remove unused setToolbarHeight
+ https://bugs.webkit.org/show_bug.cgi?id=152466
+
+ Reviewed by Darin Adler.
+
+ * WebCoreSupport/WebInspectorClient.cpp:
+ (WebInspectorFrontendClient::setToolbarHeight): Deleted.
+ * WebCoreSupport/WebInspectorClient.h:
+
2015-12-15 Zan Dobersek <[email protected]>
[TexMap] Operate with a reference to the TextureMapper wherever possible
Modified: trunk/Source/WebKit/win/WebCoreSupport/WebInspectorClient.cpp (194321 => 194322)
--- trunk/Source/WebKit/win/WebCoreSupport/WebInspectorClient.cpp 2015-12-20 20:08:36 UTC (rev 194321)
+++ trunk/Source/WebKit/win/WebCoreSupport/WebInspectorClient.cpp 2015-12-20 21:57:01 UTC (rev 194322)
@@ -327,11 +327,6 @@
notImplemented();
}
-void WebInspectorFrontendClient::setToolbarHeight(unsigned)
-{
- notImplemented();
-}
-
void WebInspectorFrontendClient::inspectedURLChanged(const String& newURL)
{
m_inspectedURL = newURL;
Modified: trunk/Source/WebKit/win/WebCoreSupport/WebInspectorClient.h (194321 => 194322)
--- trunk/Source/WebKit/win/WebCoreSupport/WebInspectorClient.h 2015-12-20 20:08:36 UTC (rev 194321)
+++ trunk/Source/WebKit/win/WebCoreSupport/WebInspectorClient.h 2015-12-20 21:57:01 UTC (rev 194322)
@@ -105,7 +105,6 @@
virtual void setAttachedWindowHeight(unsigned) override;
virtual void setAttachedWindowWidth(unsigned) override;
- virtual void setToolbarHeight(unsigned) override;
virtual void inspectedURLChanged(const WTF::String& newURL) override;
Modified: trunk/Source/WebKit2/ChangeLog (194321 => 194322)
--- trunk/Source/WebKit2/ChangeLog 2015-12-20 20:08:36 UTC (rev 194321)
+++ trunk/Source/WebKit2/ChangeLog 2015-12-20 21:57:01 UTC (rev 194322)
@@ -1,3 +1,25 @@
+2015-12-20 Dan Bernstein <[email protected]>
+
+ Remove unused setToolbarHeight
+ https://bugs.webkit.org/show_bug.cgi?id=152466
+
+ Reviewed by Darin Adler.
+
+ * UIProcess/WebInspectorProxy.cpp:
+ (WebKit::WebInspectorProxy::platformSetToolbarHeight): Deleted.
+ * UIProcess/WebInspectorProxy.h:
+ (WebKit::WebInspectorProxy::setToolbarHeight): Deleted.
+ * UIProcess/WebInspectorProxy.messages.in:
+ * UIProcess/efl/WebInspectorProxyEfl.cpp:
+ (WebKit::WebInspectorProxy::platformSetToolbarHeight): Deleted.
+ * UIProcess/gtk/WebInspectorProxyGtk.cpp:
+ (WebKit::WebInspectorProxy::platformSetToolbarHeight): Deleted.
+ * UIProcess/mac/WebInspectorProxyMac.mm:
+ (WebKit::WebInspectorProxy::platformSetToolbarHeight): Deleted.
+ * WebProcess/WebPage/WebInspectorUI.cpp:
+ (WebKit::WebInspectorUI::setToolbarHeight): Deleted.
+ * WebProcess/WebPage/WebInspectorUI.h:
+
2015-12-19 Dan Bernstein <[email protected]>
[Mac] WebKit contains dead source code for OS X Mavericks and earlier
Modified: trunk/Source/WebKit2/UIProcess/WebInspectorProxy.cpp (194321 => 194322)
--- trunk/Source/WebKit2/UIProcess/WebInspectorProxy.cpp 2015-12-20 20:08:36 UTC (rev 194321)
+++ trunk/Source/WebKit2/UIProcess/WebInspectorProxy.cpp 2015-12-20 21:57:01 UTC (rev 194322)
@@ -732,11 +732,6 @@
notImplemented();
}
-void WebInspectorProxy::platformSetToolbarHeight(unsigned)
-{
- notImplemented();
-}
-
void WebInspectorProxy::platformStartWindowDrag()
{
notImplemented();
Modified: trunk/Source/WebKit2/UIProcess/WebInspectorProxy.h (194321 => 194322)
--- trunk/Source/WebKit2/UIProcess/WebInspectorProxy.h 2015-12-20 20:08:36 UTC (rev 194321)
+++ trunk/Source/WebKit2/UIProcess/WebInspectorProxy.h 2015-12-20 21:57:01 UTC (rev 194322)
@@ -128,7 +128,6 @@
void setAttachedWindowHeight(unsigned);
void setAttachedWindowWidth(unsigned);
- void setToolbarHeight(unsigned height) { platformSetToolbarHeight(height); }
void startWindowDrag();
@@ -176,7 +175,6 @@
void platformDetach();
void platformSetAttachedWindowHeight(unsigned);
void platformSetAttachedWindowWidth(unsigned);
- void platformSetToolbarHeight(unsigned);
void platformStartWindowDrag();
void platformSave(const String& filename, const String& content, bool base64Encoded, bool forceSaveAs);
void platformAppend(const String& filename, const String& content);
Modified: trunk/Source/WebKit2/UIProcess/WebInspectorProxy.messages.in (194321 => 194322)
--- trunk/Source/WebKit2/UIProcess/WebInspectorProxy.messages.in 2015-12-20 20:08:36 UTC (rev 194321)
+++ trunk/Source/WebKit2/UIProcess/WebInspectorProxy.messages.in 2015-12-20 21:57:01 UTC (rev 194322)
@@ -39,7 +39,6 @@
SetAttachedWindowHeight(unsigned height)
SetAttachedWindowWidth(unsigned width)
- SetToolbarHeight(unsigned height)
StartWindowDrag()
Modified: trunk/Source/WebKit2/UIProcess/efl/WebInspectorProxyEfl.cpp (194321 => 194322)
--- trunk/Source/WebKit2/UIProcess/efl/WebInspectorProxyEfl.cpp 2015-12-20 20:08:36 UTC (rev 194321)
+++ trunk/Source/WebKit2/UIProcess/efl/WebInspectorProxyEfl.cpp 2015-12-20 21:57:01 UTC (rev 194322)
@@ -232,11 +232,6 @@
notImplemented();
}
-void WebInspectorProxy::platformSetToolbarHeight(unsigned)
-{
- notImplemented();
-}
-
void WebInspectorProxy::platformStartWindowDrag()
{
notImplemented();
Modified: trunk/Source/WebKit2/UIProcess/gtk/WebInspectorProxyGtk.cpp (194321 => 194322)
--- trunk/Source/WebKit2/UIProcess/gtk/WebInspectorProxyGtk.cpp 2015-12-20 20:08:36 UTC (rev 194321)
+++ trunk/Source/WebKit2/UIProcess/gtk/WebInspectorProxyGtk.cpp 2015-12-20 21:57:01 UTC (rev 194322)
@@ -343,11 +343,6 @@
webkitWebViewBaseSetInspectorViewSize(WEBKIT_WEB_VIEW_BASE(inspectedPage()->viewWidget()), width);
}
-void WebInspectorProxy::platformSetToolbarHeight(unsigned)
-{
- notImplemented();
-}
-
void WebInspectorProxy::platformStartWindowDrag()
{
notImplemented();
Modified: trunk/Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm (194321 => 194322)
--- trunk/Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm 2015-12-20 20:08:36 UTC (rev 194321)
+++ trunk/Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm 2015-12-20 21:57:01 UTC (rev 194322)
@@ -784,10 +784,6 @@
inspectedViewFrameDidChange(width);
}
-void WebInspectorProxy::platformSetToolbarHeight(unsigned height)
-{
-}
-
void WebInspectorProxy::platformStartWindowDrag()
{
#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101100
Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebInspectorUI.cpp (194321 => 194322)
--- trunk/Source/WebKit2/WebProcess/WebPage/WebInspectorUI.cpp 2015-12-20 20:08:36 UTC (rev 194321)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebInspectorUI.cpp 2015-12-20 21:57:01 UTC (rev 194322)
@@ -187,11 +187,6 @@
WebProcess::singleton().parentProcessConnection()->send(Messages::WebInspectorProxy::SetAttachedWindowWidth(width), m_inspectedPageIdentifier);
}
-void WebInspectorUI::setToolbarHeight(unsigned height)
-{
- WebProcess::singleton().parentProcessConnection()->send(Messages::WebInspectorProxy::SetToolbarHeight(height), m_inspectedPageIdentifier);
-}
-
void WebInspectorUI::openInNewTab(const String& url)
{
if (m_backendConnection)
Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebInspectorUI.h (194321 => 194322)
--- trunk/Source/WebKit2/WebProcess/WebPage/WebInspectorUI.h 2015-12-20 20:08:36 UTC (rev 194321)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebInspectorUI.h 2015-12-20 21:57:01 UTC (rev 194322)
@@ -91,8 +91,6 @@
void changeAttachedWindowHeight(unsigned) override;
void changeAttachedWindowWidth(unsigned) override;
- void setToolbarHeight(unsigned) override;
-
void openInNewTab(const String& url) override;
bool canSave() override;
