Title: [194360] trunk/Source/WebInspectorUI
- Revision
- 194360
- Author
- [email protected]
- Date
- 2015-12-21 22:07:23 -0800 (Mon, 21 Dec 2015)
Log Message
WebInspector: Can't open a new tab: Uncaught Exception: TypeError: this.isNewTabWithTypeAllowed is not a function
https://bugs.webkit.org/show_bug.cgi?id=152471
Reviewed by Timothy Hatcher.
* UserInterface/Base/Main.js:
(WebInspector._updateNewTabButtonState):
Don't use arrow functions because of https://webkit.org/b/152497 "Arrow functions: 'this' isn't lexically bound"
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (194359 => 194360)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-12-22 05:50:58 UTC (rev 194359)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-12-22 06:07:23 UTC (rev 194360)
@@ -1,5 +1,16 @@
2015-12-21 Nikita Vasilyev <[email protected]>
+ WebInspector: Can't open a new tab: Uncaught Exception: TypeError: this.isNewTabWithTypeAllowed is not a function
+ https://bugs.webkit.org/show_bug.cgi?id=152471
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Base/Main.js:
+ (WebInspector._updateNewTabButtonState):
+ Don't use arrow functions because of https://webkit.org/b/152497 "Arrow functions: 'this' isn't lexically bound"
+
+2015-12-21 Nikita Vasilyev <[email protected]>
+
Web Inspector: Remove unused WebInspector.Object.removeAllListeners
https://bugs.webkit.org/show_bug.cgi?id=152474
Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Main.js (194359 => 194360)
--- trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2015-12-22 05:50:58 UTC (rev 194359)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2015-12-22 06:07:23 UTC (rev 194360)
@@ -490,7 +490,11 @@
{
let allTabs = [...this._knownTabClassesByType.values()];
let addableTabs = allTabs.filter((tabClass) => !tabClass.isEphemeral());
- let canMakeNewTab = addableTabs.some((tabClass) => this.isNewTabWithTypeAllowed(tabClass.Type));
+
+ // FIXME: Use arrow functions once http://webkit.org/b/152497 is resolved.
+ let canMakeNewTab = addableTabs.some(function(tabClass) {
+ return this.isNewTabWithTypeAllowed(tabClass.Type);
+ }.bind(this));
this.tabBar.newTabItem.disabled = !canMakeNewTab;
};
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
