Title: [194364] trunk
- Revision
- 194364
- Author
- [email protected]
- Date
- 2015-12-22 09:38:00 -0800 (Tue, 22 Dec 2015)
Log Message
[WK2] Looping in testcase: fast/dom/Window/property-access-on-cached-window-after-frame-removed.html
https://bugs.webkit.org/show_bug.cgi?id=152482
Reviewed by Brent Fulgham.
Tools:
vertical/horizontalScrollbar returns an accessibility element. That element can also be queried
for the same property. On WK2, the element returned will not be valid, but is still present and
that can lead to looping.
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::horizontalScrollbar):
(AccessibilityUIElement::verticalScrollbar):
* WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::horizontalScrollbar):
(WTR::AccessibilityUIElement::verticalScrollbar):
LayoutTests:
* platform/mac-wk2/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (194363 => 194364)
--- trunk/LayoutTests/ChangeLog 2015-12-22 16:20:48 UTC (rev 194363)
+++ trunk/LayoutTests/ChangeLog 2015-12-22 17:38:00 UTC (rev 194364)
@@ -1,3 +1,12 @@
+2015-12-22 Chris Fleizach <[email protected]>
+
+ [WK2] Looping in testcase: fast/dom/Window/property-access-on-cached-window-after-frame-removed.html
+ https://bugs.webkit.org/show_bug.cgi?id=152482
+
+ Reviewed by Brent Fulgham.
+
+ * platform/mac-wk2/TestExpectations:
+
2015-12-21 Ryan Haddad <[email protected]>
Skipping unsupported test on ios-simulator
Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (194363 => 194364)
--- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2015-12-22 16:20:48 UTC (rev 194363)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2015-12-22 17:38:00 UTC (rev 194364)
@@ -364,9 +364,6 @@
[ Debug ] editing/undo/remove-css-property-and-remove-style.html [ Pass Failure ]
-# Test for WK1 only
-fast/dom/Window/property-access-on-cached-window-after-frame-removed.html [ Skip ]
-
### END OF (3) Unclassified failures
########################################
Modified: trunk/Tools/ChangeLog (194363 => 194364)
--- trunk/Tools/ChangeLog 2015-12-22 16:20:48 UTC (rev 194363)
+++ trunk/Tools/ChangeLog 2015-12-22 17:38:00 UTC (rev 194364)
@@ -1,3 +1,21 @@
+2015-12-22 Chris Fleizach <[email protected]>
+
+ [WK2] Looping in testcase: fast/dom/Window/property-access-on-cached-window-after-frame-removed.html
+ https://bugs.webkit.org/show_bug.cgi?id=152482
+
+ Reviewed by Brent Fulgham.
+
+ vertical/horizontalScrollbar returns an accessibility element. That element can also be queried
+ for the same property. On WK2, the element returned will not be valid, but is still present and
+ that can lead to looping.
+
+ * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
+ (AccessibilityUIElement::horizontalScrollbar):
+ (AccessibilityUIElement::verticalScrollbar):
+ * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
+ (WTR::AccessibilityUIElement::horizontalScrollbar):
+ (WTR::AccessibilityUIElement::verticalScrollbar):
+
2015-12-22 Xabier Rodriguez Calvar <[email protected]>
Unreviewed.
Modified: trunk/Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm (194363 => 194364)
--- trunk/Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm 2015-12-22 16:20:48 UTC (rev 194363)
+++ trunk/Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm 2015-12-22 17:38:00 UTC (rev 194364)
@@ -1292,6 +1292,9 @@
AccessibilityUIElement AccessibilityUIElement::horizontalScrollbar() const
{
+ if (!m_element)
+ return nullptr;
+
BEGIN_AX_OBJC_EXCEPTIONS
return AccessibilityUIElement([m_element accessibilityAttributeValue:NSAccessibilityHorizontalScrollBarAttribute]);
END_AX_OBJC_EXCEPTIONS
@@ -1301,6 +1304,9 @@
AccessibilityUIElement AccessibilityUIElement::verticalScrollbar() const
{
+ if (!m_element)
+ return nullptr;
+
BEGIN_AX_OBJC_EXCEPTIONS
return AccessibilityUIElement([m_element accessibilityAttributeValue:NSAccessibilityVerticalScrollBarAttribute]);
END_AX_OBJC_EXCEPTIONS
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm (194363 => 194364)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm 2015-12-22 16:20:48 UTC (rev 194363)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm 2015-12-22 17:38:00 UTC (rev 194364)
@@ -1352,6 +1352,9 @@
PassRefPtr<AccessibilityUIElement> AccessibilityUIElement::horizontalScrollbar() const
{
+ if (!m_element)
+ return nullptr;
+
BEGIN_AX_OBJC_EXCEPTIONS
return AccessibilityUIElement::create([m_element accessibilityAttributeValue:NSAccessibilityHorizontalScrollBarAttribute]);
END_AX_OBJC_EXCEPTIONS
@@ -1361,6 +1364,9 @@
PassRefPtr<AccessibilityUIElement> AccessibilityUIElement::verticalScrollbar() const
{
+ if (!m_element)
+ return nullptr;
+
BEGIN_AX_OBJC_EXCEPTIONS
return AccessibilityUIElement::create([m_element accessibilityAttributeValue:NSAccessibilityVerticalScrollBarAttribute]);
END_AX_OBJC_EXCEPTIONS
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
