Diff
Modified: trunk/LayoutTests/ChangeLog (194770 => 194771)
--- trunk/LayoutTests/ChangeLog 2016-01-08 18:44:36 UTC (rev 194770)
+++ trunk/LayoutTests/ChangeLog 2016-01-08 18:48:03 UTC (rev 194771)
@@ -1,5 +1,16 @@
2016-01-08 Brady Eidson <beid...@apple.com>
+ Modern IDB: imported/w3c/indexeddb/idbobjectstore_createIndex6-event_order.htm fails.
+ https://bugs.webkit.org/show_bug.cgi?id=152891
+
+ Reviewed by Alex Christensen.
+
+ * platform/mac-wk1/TestExpectations:
+ * platform/wk2/imported/w3c/indexeddb/idbobjectstore_createIndex6-event_order-expected.txt: Copied from LayoutTests/imported/w3c/indexeddb/idbobjectstore_createIndex6-event_order-expected.txt.
+ * platform/wk2/imported/w3c/indexeddb/idbobjectstore_createIndex7-event_order-expected.txt: Copied from LayoutTests/imported/w3c/indexeddb/idbobjectstore_createIndex7-event_order-expected.txt.
+
+2016-01-08 Brady Eidson <beid...@apple.com>
+
Modern IDB: storage/indexeddb/dont-wedge.html is flaky.
https://bugs.webkit.org/show_bug.cgi?id=152892
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (194770 => 194771)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2016-01-08 18:44:36 UTC (rev 194770)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-01-08 18:48:03 UTC (rev 194771)
@@ -1,3 +1,13 @@
+2016-01-08 Brady Eidson <beid...@apple.com>
+
+ Modern IDB: imported/w3c/indexeddb/idbobjectstore_createIndex6-event_order.htm fails.
+ https://bugs.webkit.org/show_bug.cgi?id=152891
+
+ Reviewed by Alex Christensen.
+
+ * indexeddb/idbobjectstore_createIndex6-event_order-expected.txt:
+ * indexeddb/idbobjectstore_createIndex7-event_order-expected.txt:
+
2016-01-07 Brady Eidson <beid...@apple.com>
Modern IDB: Add expectations for W3C tests that were missing them.
Modified: trunk/LayoutTests/imported/w3c/indexeddb/idbobjectstore_createIndex6-event_order-expected.txt (194770 => 194771)
--- trunk/LayoutTests/imported/w3c/indexeddb/idbobjectstore_createIndex6-event_order-expected.txt 2016-01-08 18:44:36 UTC (rev 194770)
+++ trunk/LayoutTests/imported/w3c/indexeddb/idbobjectstore_createIndex6-event_order-expected.txt 2016-01-08 18:48:03 UTC (rev 194771)
@@ -1,3 +1,3 @@
-FAIL IDBObjectStore.createIndex() - event order when unique constraint is triggered assert_unreached: unexpected open.success event Reached unreachable code
+PASS IDBObjectStore.createIndex() - event order when unique constraint is triggered
Modified: trunk/LayoutTests/imported/w3c/indexeddb/idbobjectstore_createIndex7-event_order-expected.txt (194770 => 194771)
--- trunk/LayoutTests/imported/w3c/indexeddb/idbobjectstore_createIndex7-event_order-expected.txt 2016-01-08 18:44:36 UTC (rev 194770)
+++ trunk/LayoutTests/imported/w3c/indexeddb/idbobjectstore_createIndex7-event_order-expected.txt 2016-01-08 18:48:03 UTC (rev 194771)
@@ -1,3 +1,3 @@
-FAIL IDBObjectStore.createIndex() - Event ordering for ConstraintError on request assert_unreached: unexpected open.success event Reached unreachable code
+PASS IDBObjectStore.createIndex() - Event ordering for ConstraintError on request
Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (194770 => 194771)
--- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2016-01-08 18:44:36 UTC (rev 194770)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2016-01-08 18:48:03 UTC (rev 194771)
@@ -74,8 +74,6 @@
imported/w3c/indexeddb/keyorder.htm [ Skip ]
# W3C IDB tests - Legacy IDB fails, Modern IDB fails differently
-imported/w3c/indexeddb/idbobjectstore_createIndex6-event_order.htm [ Failure ]
-imported/w3c/indexeddb/idbobjectstore_createIndex7-event_order.htm [ Failure ]
imported/w3c/indexeddb/idbversionchangeevent.htm [ Failure ]
imported/w3c/indexeddb/keypath.htm [ Failure ]
Copied: trunk/LayoutTests/platform/wk2/imported/w3c/indexeddb/idbobjectstore_createIndex6-event_order-expected.txt (from rev 194770, trunk/LayoutTests/imported/w3c/indexeddb/idbobjectstore_createIndex6-event_order-expected.txt) (0 => 194771)
--- trunk/LayoutTests/platform/wk2/imported/w3c/indexeddb/idbobjectstore_createIndex6-event_order-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/wk2/imported/w3c/indexeddb/idbobjectstore_createIndex6-event_order-expected.txt 2016-01-08 18:48:03 UTC (rev 194771)
@@ -0,0 +1,3 @@
+
+FAIL IDBObjectStore.createIndex() - event order when unique constraint is triggered assert_unreached: unexpected open.success event Reached unreachable code
+
Copied: trunk/LayoutTests/platform/wk2/imported/w3c/indexeddb/idbobjectstore_createIndex7-event_order-expected.txt (from rev 194770, trunk/LayoutTests/imported/w3c/indexeddb/idbobjectstore_createIndex7-event_order-expected.txt) (0 => 194771)
--- trunk/LayoutTests/platform/wk2/imported/w3c/indexeddb/idbobjectstore_createIndex7-event_order-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/wk2/imported/w3c/indexeddb/idbobjectstore_createIndex7-event_order-expected.txt 2016-01-08 18:48:03 UTC (rev 194771)
@@ -0,0 +1,3 @@
+
+FAIL IDBObjectStore.createIndex() - Event ordering for ConstraintError on request assert_unreached: unexpected open.success event Reached unreachable code
+
Modified: trunk/Source/WebCore/ChangeLog (194770 => 194771)
--- trunk/Source/WebCore/ChangeLog 2016-01-08 18:44:36 UTC (rev 194770)
+++ trunk/Source/WebCore/ChangeLog 2016-01-08 18:48:03 UTC (rev 194771)
@@ -1,3 +1,16 @@
+2016-01-08 Brady Eidson <beid...@apple.com>
+
+ Modern IDB: imported/w3c/indexeddb/idbobjectstore_createIndex6-event_order.htm fails.
+ https://bugs.webkit.org/show_bug.cgi?id=152891
+
+ Reviewed by Alex Christensen.
+
+ No new tests (At least two failing tests now pass).
+
+ * Modules/indexeddb/client/IDBRequestImpl.cpp:
+ (WebCore::IDBClient::IDBRequest::dispatchEvent): Whenever we add the IDBTransaction as an event target,
+ also add the IDBDatabase.
+
2016-01-07 Antti Koivisto <an...@apple.com>
Enable selector filtering for shadow trees
Modified: trunk/Source/WebCore/Modules/indexeddb/client/IDBRequestImpl.cpp (194770 => 194771)
--- trunk/Source/WebCore/Modules/indexeddb/client/IDBRequestImpl.cpp 2016-01-08 18:44:36 UTC (rev 194770)
+++ trunk/Source/WebCore/Modules/indexeddb/client/IDBRequestImpl.cpp 2016-01-08 18:48:03 UTC (rev 194771)
@@ -276,10 +276,8 @@
if (&event == m_openDatabaseSuccessEvent)
m_openDatabaseSuccessEvent = nullptr;
- else if (m_transaction) {
- if (!m_transaction->isFinished())
+ else if (m_transaction && !m_transaction->isFinished()) {
targets.append(m_transaction);
- if (!m_transaction->database().isClosingOrClosed())
targets.append(m_transaction->db());
}
