Title: [194929] trunk/Websites/perf.webkit.org
- Revision
- 194929
- Author
- [email protected]
- Date
- 2016-01-12 14:48:22 -0800 (Tue, 12 Jan 2016)
Log Message
Analysis results viewer sometimes doesn't show the correct relative difference
https://bugs.webkit.org/show_bug.cgi?id=152930
Reviewed by Chris Dumez.
The bug was caused by single A/B testing result associated with multiple rows when there are multiple data
points with the same root set which matches that of an A/B testing.
Fixed the bug by detecting such a case, and only associating each A/B testing result with the row created
for the first matching point.
* public/v3/components/analysis-results-viewer.js:
(AnalysisResultsViewer.prototype._buildRowsForPointsAndTestGroups):
Modified Paths
Diff
Modified: trunk/Websites/perf.webkit.org/ChangeLog (194928 => 194929)
--- trunk/Websites/perf.webkit.org/ChangeLog 2016-01-12 22:29:43 UTC (rev 194928)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2016-01-12 22:48:22 UTC (rev 194929)
@@ -1,3 +1,19 @@
+2016-01-12 Ryosuke Niwa <[email protected]>
+
+ Analysis results viewer sometimes doesn't show the correct relative difference
+ https://bugs.webkit.org/show_bug.cgi?id=152930
+
+ Reviewed by Chris Dumez.
+
+ The bug was caused by single A/B testing result associated with multiple rows when there are multiple data
+ points with the same root set which matches that of an A/B testing.
+
+ Fixed the bug by detecting such a case, and only associating each A/B testing result with the row created
+ for the first matching point.
+
+ * public/v3/components/analysis-results-viewer.js:
+ (AnalysisResultsViewer.prototype._buildRowsForPointsAndTestGroups):
+
2016-01-08 Ryosuke Niwa <[email protected]>
Make v3 UI analysis task page is hard to understand
Modified: trunk/Websites/perf.webkit.org/public/v3/components/analysis-results-viewer.js (194928 => 194929)
--- trunk/Websites/perf.webkit.org/public/v3/components/analysis-results-viewer.js 2016-01-12 22:29:43 UTC (rev 194928)
+++ trunk/Websites/perf.webkit.org/public/v3/components/analysis-results-viewer.js 2016-01-12 22:48:22 UTC (rev 194929)
@@ -155,7 +155,7 @@
var rootSetInPoint = point.rootSet();
var matchingRootSets = [];
for (var entry of rootSetsInTestGroups) {
- if (rootSetInPoint.equals(entry.rootSet())) {
+ if (rootSetInPoint.equals(entry.rootSet()) && !rootSetsWithPoints.has(entry)) {
matchingRootSets.push(entry);
rootSetsWithPoints.add(entry);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
