Title: [194957] trunk/Source/WebCore
Revision
194957
Author
[email protected]
Date
2016-01-13 00:01:56 -0800 (Wed, 13 Jan 2016)

Log Message

[EFL] Fix wrong return value of paintThemePart in RenderThemeEfl
https://bugs.webkit.org/show_bug.cgi?id=153058

Reviewed by Carlos Garcia Campos.

To return false in paint functions in RenderThemeEfl means that it is supported though,
paintThemePart has returned false even when failing to get image cache of theme.

* rendering/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::paintThemePart):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (194956 => 194957)


--- trunk/Source/WebCore/ChangeLog	2016-01-13 06:58:34 UTC (rev 194956)
+++ trunk/Source/WebCore/ChangeLog	2016-01-13 08:01:56 UTC (rev 194957)
@@ -1,3 +1,16 @@
+2016-01-13  Gyuyoung Kim  <[email protected]>
+
+        [EFL] Fix wrong return value of paintThemePart in RenderThemeEfl
+        https://bugs.webkit.org/show_bug.cgi?id=153058
+
+        Reviewed by Carlos Garcia Campos.
+
+        To return false in paint functions in RenderThemeEfl means that it is supported though,
+        paintThemePart has returned false even when failing to get image cache of theme.
+
+        * rendering/RenderThemeEfl.cpp:
+        (WebCore::RenderThemeEfl::paintThemePart):
+
 2016-01-12  Andy Estes  <[email protected]>
 
         [Content Filtering] forEachContentFilterUntilBlocked should accept a lambda by rvalue reference

Modified: trunk/Source/WebCore/rendering/RenderThemeEfl.cpp (194956 => 194957)


--- trunk/Source/WebCore/rendering/RenderThemeEfl.cpp	2016-01-13 06:58:34 UTC (rev 194956)
+++ trunk/Source/WebCore/rendering/RenderThemeEfl.cpp	2016-01-13 08:01:56 UTC (rev 194957)
@@ -364,7 +364,7 @@
 
     ThemePartCacheEntry* entry = getThemePartFromCache(type, rect.size());
     if (!entry)
-        return false;
+        return true;
 
     bool haveBackgroundColor = isControlStyled(object.style(), object.style().border(), *object.style().backgroundLayers(), Color::white);
     ControlStates states(extractControlStatesForRenderer(object));
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to