Title: [194988] trunk
- Revision
- 194988
- Author
- mcatanz...@igalia.com
- Date
- 2016-01-13 15:06:20 -0800 (Wed, 13 Jan 2016)
Log Message
[GTK] Add comments above options declarations in OptionsGTK.cmake
https://bugs.webkit.org/show_bug.cgi?id=153074
Reviewed by Martin Robinson.
* Source/cmake/OptionsGTK.cmake:
Modified Paths
Diff
Modified: trunk/ChangeLog (194987 => 194988)
--- trunk/ChangeLog 2016-01-13 23:00:14 UTC (rev 194987)
+++ trunk/ChangeLog 2016-01-13 23:06:20 UTC (rev 194988)
@@ -1,3 +1,12 @@
+2016-01-13 Michael Catanzaro <mcatanz...@igalia.com>
+
+ [GTK] Add comments above options declarations in OptionsGTK.cmake
+ https://bugs.webkit.org/show_bug.cgi?id=153074
+
+ Reviewed by Martin Robinson.
+
+ * Source/cmake/OptionsGTK.cmake:
+
2016-01-12 Carlos Garcia Campos <cgar...@igalia.com>
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.11.3 release.
Modified: trunk/Source/cmake/OptionsGTK.cmake (194987 => 194988)
--- trunk/Source/cmake/OptionsGTK.cmake 2016-01-13 23:00:14 UTC (rev 194987)
+++ trunk/Source/cmake/OptionsGTK.cmake 2016-01-13 23:06:20 UTC (rev 194988)
@@ -72,6 +72,9 @@
set(ENABLE_FTL_DEFAULT OFF)
endif ()
+# Public options specific to the GTK+ port. Do not add any options here unless
+# there is a strong reason we should support changing the value of the option,
+# and the option is not relevant to any other WebKit ports.
WEBKIT_OPTION_DEFINE(ENABLE_GLES2 "Whether to enable OpenGL ES 2.0." PUBLIC ${ENABLE_GLES2_DEFAULT})
WEBKIT_OPTION_DEFINE(ENABLE_GTKDOC "Whether or not to use generate gtkdoc." PUBLIC OFF)
WEBKIT_OPTION_DEFINE(ENABLE_INTROSPECTION "Whether to enable GObject introspection." PUBLIC ON)
@@ -83,6 +86,8 @@
WEBKIT_OPTION_DEFINE(USE_LIBNOTIFY "Whether to enable the default web notification implementation." PUBLIC ON)
WEBKIT_OPTION_DEFINE(USE_LIBHYPHEN "Whether to enable the default automatic hyphenation implementation." PUBLIC ON)
+# Private options specific to the GTK+ port. Changing these options is
+# completely unsupported. They are intended for use only by WebKit developers.
WEBKIT_OPTION_DEFINE(USE_GSTREAMER_GL "Whether to enable support for GStreamer GL" PRIVATE OFF)
WEBKIT_OPTION_DEFINE(USE_GSTREAMER_MPEGTS "Whether to enable support for MPEG-TS" PRIVATE OFF)
WEBKIT_OPTION_DEFINE(USE_REDIRECTED_XCOMPOSITE_WINDOW "Whether to use a Redirected XComposite Window for accelerated compositing in X11." PRIVATE ON)
@@ -122,6 +127,9 @@
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MEMORY_SAMPLER PUBLIC OFF)
endif ()
+# Public options shared with other WebKit ports. Do not add any options here
+# without approval from a GTK+ reviewer. There must be strong reason to support
+# changing the value of the option.
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ACCELERATED_2D_CANVAS PUBLIC OFF)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CREDENTIAL_STORAGE PUBLIC ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_DRAG_SUPPORT PUBLIC ON)
@@ -135,6 +143,9 @@
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEB_AUDIO PUBLIC ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(USE_SYSTEM_MALLOC PUBLIC OFF)
+# Private options shared with other WebKit ports. Add options here when
+# we need a value different from the default defined in WebKitFeatures.cmake.
+# Changing these options is completely unsupported.
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_3D_TRANSFORMS PRIVATE ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ACCESSIBILITY PRIVATE ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CANVAS_PATH PRIVATE OFF)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
