Title: [195160] trunk
Revision
195160
Author
[email protected]
Date
2016-01-15 17:03:47 -0800 (Fri, 15 Jan 2016)

Log Message

Drop obsolete HTMLDocument.width / height attributes
https://bugs.webkit.org/show_bug.cgi?id=153144

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Rebaseline W3C test now that more checks are passing.

* web-platform-tests/dom/historical-expected.txt:

Source/WebCore:

Drop obsolete HTMLDocument.width / height attributes as these are
obsolete and already not supported by other major browsers (tested
Firefox and Chrome).

No new tests, already covered by existing tests.

* html/HTMLDocument.idl:

LayoutTests:

* fast/dom/HTMLDocument/width-and-height-expected.txt: Removed.
* fast/dom/HTMLDocument/width-and-height.html: Removed.
Drop outdated test.

* fast/dom/Window/window-property-invalid-characters-ignored-expected.txt:
* fast/dom/Window/window-property-invalid-characters-ignored.html:
Stop relying on Document.width / height as these are obsolete.

Modified Paths

Removed Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (195159 => 195160)


--- trunk/LayoutTests/ChangeLog	2016-01-16 00:37:29 UTC (rev 195159)
+++ trunk/LayoutTests/ChangeLog	2016-01-16 01:03:47 UTC (rev 195160)
@@ -1,3 +1,18 @@
+2016-01-15  Chris Dumez  <[email protected]>
+
+        Drop obsolete HTMLDocument.width / height attributes
+        https://bugs.webkit.org/show_bug.cgi?id=153144
+
+        Reviewed by Ryosuke Niwa.
+
+        * fast/dom/HTMLDocument/width-and-height-expected.txt: Removed.
+        * fast/dom/HTMLDocument/width-and-height.html: Removed.
+        Drop outdated test.
+
+        * fast/dom/Window/window-property-invalid-characters-ignored-expected.txt:
+        * fast/dom/Window/window-property-invalid-characters-ignored.html:
+        Stop relying on Document.width / height as these are obsolete.
+
 2016-01-15  Beth Dakin  <[email protected]>
 
         Add a test for touch events in scaled documents

Deleted: trunk/LayoutTests/fast/dom/HTMLDocument/width-and-height-expected.txt (195159 => 195160)


--- trunk/LayoutTests/fast/dom/HTMLDocument/width-and-height-expected.txt	2016-01-16 00:37:29 UTC (rev 195159)
+++ trunk/LayoutTests/fast/dom/HTMLDocument/width-and-height-expected.txt	2016-01-16 01:03:47 UTC (rev 195160)
@@ -1 +0,0 @@
-PASS. The document.width and document.height properties are accessible from _javascript_.

Deleted: trunk/LayoutTests/fast/dom/HTMLDocument/width-and-height.html (195159 => 195160)


--- trunk/LayoutTests/fast/dom/HTMLDocument/width-and-height.html	2016-01-16 00:37:29 UTC (rev 195159)
+++ trunk/LayoutTests/fast/dom/HTMLDocument/width-and-height.html	2016-01-16 01:03:47 UTC (rev 195160)
@@ -1,9 +0,0 @@
-<script>
-    if (window.testRunner)
-        testRunner.dumpAsText();
-
-    if ('width' in document && 'height' in document)
-        document.write("PASS. The document.width and document.height properties are accessible from _javascript_.");
-    else
-        document.write("FAIL. document.width or document.height are not accessible from _javascript_.");
-</script>

Modified: trunk/LayoutTests/fast/dom/Window/window-property-invalid-characters-ignored-expected.txt (195159 => 195160)


--- trunk/LayoutTests/fast/dom/Window/window-property-invalid-characters-ignored-expected.txt	2016-01-16 00:37:29 UTC (rev 195159)
+++ trunk/LayoutTests/fast/dom/Window/window-property-invalid-characters-ignored-expected.txt	2016-01-16 01:03:47 UTC (rev 195160)
@@ -3,8 +3,8 @@
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
-PASS w.document.width is 123
-PASS w.document.height is 123
+PASS w.innerWidth is 123
+PASS w.innerHeight is 123
 PASS w !== window is true
 PASS successfullyParsed is true
 

Modified: trunk/LayoutTests/fast/dom/Window/window-property-invalid-characters-ignored.html (195159 => 195160)


--- trunk/LayoutTests/fast/dom/Window/window-property-invalid-characters-ignored.html	2016-01-16 00:37:29 UTC (rev 195159)
+++ trunk/LayoutTests/fast/dom/Window/window-property-invalid-characters-ignored.html	2016-01-16 01:03:47 UTC (rev 195160)
@@ -16,8 +16,8 @@
 
 function finishTest()
 {
-    shouldBe("w.document.width", "123");
-    shouldBe("w.document.height", "123");
+    shouldBe("w.innerWidth", "123");
+    shouldBe("w.innerHeight", "123");
     shouldBeTrue("w !== window");
     w.close();
 

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (195159 => 195160)


--- trunk/LayoutTests/imported/w3c/ChangeLog	2016-01-16 00:37:29 UTC (rev 195159)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2016-01-16 01:03:47 UTC (rev 195160)
@@ -1,5 +1,16 @@
 2016-01-15  Chris Dumez  <[email protected]>
 
+        Drop obsolete HTMLDocument.width / height attributes
+        https://bugs.webkit.org/show_bug.cgi?id=153144
+
+        Reviewed by Ryosuke Niwa.
+
+        Rebaseline W3C test now that more checks are passing.
+
+        * web-platform-tests/dom/historical-expected.txt:
+
+2016-01-15  Chris Dumez  <[email protected]>
+
         Drop obsolete DocumentType.entities / notations
         https://bugs.webkit.org/show_bug.cgi?id=153147
 

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/dom/historical-expected.txt (195159 => 195160)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/dom/historical-expected.txt	2016-01-16 00:37:29 UTC (rev 195159)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/dom/historical-expected.txt	2016-01-16 01:03:47 UTC (rev 195160)
@@ -28,8 +28,8 @@
 PASS Historical DOM features must be removed: normalizeDocument 
 PASS Historical DOM features must be removed: renameNode 
 FAIL Historical DOM features must be removed: defaultCharset assert_equals: expected (undefined) undefined but got (string) "ISO-8859-1"
-FAIL Historical DOM features must be removed: height assert_equals: expected (undefined) undefined but got (number) 600
-FAIL Historical DOM features must be removed: width assert_equals: expected (undefined) undefined but got (number) 800
+PASS Historical DOM features must be removed: height 
+PASS Historical DOM features must be removed: width 
 PASS DOMImplementation.getFeature() must be nuked. 
 PASS Historical DOM features must be removed: schemaTypeInfo 
 PASS Historical DOM features must be removed: setIdAttribute 

Modified: trunk/Source/WebCore/ChangeLog (195159 => 195160)


--- trunk/Source/WebCore/ChangeLog	2016-01-16 00:37:29 UTC (rev 195159)
+++ trunk/Source/WebCore/ChangeLog	2016-01-16 01:03:47 UTC (rev 195160)
@@ -1,5 +1,20 @@
 2016-01-15  Chris Dumez  <[email protected]>
 
+        Drop obsolete HTMLDocument.width / height attributes
+        https://bugs.webkit.org/show_bug.cgi?id=153144
+
+        Reviewed by Ryosuke Niwa.
+
+        Drop obsolete HTMLDocument.width / height attributes as these are
+        obsolete and already not supported by other major browsers (tested
+        Firefox and Chrome).
+
+        No new tests, already covered by existing tests.
+
+        * html/HTMLDocument.idl:
+
+2016-01-15  Chris Dumez  <[email protected]>
+
         Drop obsolete DocumentType.entities / notations
         https://bugs.webkit.org/show_bug.cgi?id=153147
 

Modified: trunk/Source/WebCore/html/HTMLDocument.idl (195159 => 195160)


--- trunk/Source/WebCore/html/HTMLDocument.idl	2016-01-16 00:37:29 UTC (rev 195159)
+++ trunk/Source/WebCore/html/HTMLDocument.idl	2016-01-16 01:03:47 UTC (rev 195160)
@@ -45,8 +45,11 @@
     void captureEvents();
     void releaseEvents();
 
+#if !defined(LANGUAGE_JAVASCRIPT) || !LANGUAGE_JAVASCRIPT
     readonly attribute long width;
     readonly attribute long height;
+#endif
+
              [TreatNullAs=NullString] attribute DOMString dir;
              [TreatNullAs=NullString] attribute DOMString designMode;
     readonly attribute DOMString compatMode;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to