Title: [195172] trunk
Revision
195172
Author
[email protected]
Date
2016-01-16 11:07:34 -0800 (Sat, 16 Jan 2016)

Log Message

Source/WebCore:
Fix flakiness of displaylists/layer-dispay-list.html

When toggling "uses display list drawing" on a GraphicsLayerCA, do
a repaint.

* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::setUsesDisplayListDrawing):

LayoutTests:
This test needs to force layout before calling setElementUsesDisplayListDrawing(),
so that the layer already has its "drawsContents" property updated.

* displaylists/layer-dispay-list.html:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (195171 => 195172)


--- trunk/LayoutTests/ChangeLog	2016-01-16 19:03:08 UTC (rev 195171)
+++ trunk/LayoutTests/ChangeLog	2016-01-16 19:07:34 UTC (rev 195172)
@@ -1,3 +1,10 @@
+2016-01-16  Simon Fraser  <[email protected]>
+
+        This test needs to force layout before calling setElementUsesDisplayListDrawing(),
+        so that the layer already has its "drawsContents" property updated.
+
+        * displaylists/layer-dispay-list.html:
+
 2016-01-15  Jiewen Tan  <[email protected]>
 
         FrameLoaderClient::didReceiveServerRedirectForProvisionalLoadForFrame() is never called when loading a main resource from the memory cache

Modified: trunk/LayoutTests/displaylists/layer-dispay-list.html (195171 => 195172)


--- trunk/LayoutTests/displaylists/layer-dispay-list.html	2016-01-16 19:03:08 UTC (rev 195171)
+++ trunk/LayoutTests/displaylists/layer-dispay-list.html	2016-01-16 19:07:34 UTC (rev 195172)
@@ -23,7 +23,7 @@
         var targetDiv;
         function doTest()
         {
-            // document.body.offsetWidth;
+            document.body.offsetWidth;
             targetDiv = document.getElementById('target');
             if (window.internals)
                 internals.setElementUsesDisplayListDrawing(targetDiv, true);

Modified: trunk/Source/WebCore/ChangeLog (195171 => 195172)


--- trunk/Source/WebCore/ChangeLog	2016-01-16 19:03:08 UTC (rev 195171)
+++ trunk/Source/WebCore/ChangeLog	2016-01-16 19:07:34 UTC (rev 195172)
@@ -1,3 +1,13 @@
+2016-01-16  Simon Fraser  <[email protected]>
+
+        Fix flakiness of displaylists/layer-dispay-list.html
+        
+        When toggling "uses display list drawing" on a GraphicsLayerCA, do
+        a repaint.
+
+        * platform/graphics/ca/GraphicsLayerCA.cpp:
+        (WebCore::GraphicsLayerCA::setUsesDisplayListDrawing):
+
 2016-01-15  Simon Fraser  <[email protected]>
 
         Remove GraphicsContext::drawConvexPolygon() and GraphicsContext::clipConvexPolygon()

Modified: trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp (195171 => 195172)


--- trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp	2016-01-16 19:03:08 UTC (rev 195171)
+++ trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp	2016-01-16 19:07:34 UTC (rev 195172)
@@ -675,6 +675,7 @@
     if (usesDisplayListDrawing == m_usesDisplayListDrawing)
         return;
 
+    setNeedsDisplay();
     GraphicsLayer::setUsesDisplayListDrawing(usesDisplayListDrawing);
 }
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to