[webkit-changes] [195246] trunk/Source/JavaScriptCore

Mon, 18 Jan 2016 20:09:07 -0800

Title: [195246] trunk/Source/_javascript_Core
Revision
195246
Author
[email protected]
Date
2016-01-18 20:08:56 -0800 (Mon, 18 Jan 2016)

Log Message

assertions in BytecodeUseDef.h about opcode length are off by one
https://bugs.webkit.org/show_bug.cgi?id=153215

Reviewed by Dan Bernstein.

* bytecode/BytecodeUseDef.h:
(JSC::computeUsesForBytecodeOffset):

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (195245 => 195246)


--- trunk/Source/_javascript_Core/ChangeLog	2016-01-19 04:05:22 UTC (rev 195245)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-01-19 04:08:56 UTC (rev 195246)
@@ -1,5 +1,15 @@
 2016-01-18  Saam barati  <[email protected]>
 
+        assertions in BytecodeUseDef.h about opcode length are off by one
+        https://bugs.webkit.org/show_bug.cgi?id=153215
+
+        Reviewed by Dan Bernstein.
+
+        * bytecode/BytecodeUseDef.h:
+        (JSC::computeUsesForBytecodeOffset):
+
+2016-01-18  Saam barati  <[email protected]>
+
         FTL doesn't do proper spilling for exception handling when GetById/Snippets go to slow path
         https://bugs.webkit.org/show_bug.cgi?id=153186

Modified: trunk/Source/_javascript_Core/bytecode/BytecodeUseDef.h (195245 => 195246)


--- trunk/Source/_javascript_Core/bytecode/BytecodeUseDef.h	2016-01-19 04:05:22 UTC (rev 195245)
+++ trunk/Source/_javascript_Core/bytecode/BytecodeUseDef.h	2016-01-19 04:08:56 UTC (rev 195246)
@@ -73,7 +73,7 @@
     case op_dec:
     case op_inc:
     case op_resume: {
-        ASSERT(opcodeLengths[opcodeID] >= 1);
+        ASSERT(opcodeLengths[opcodeID] > 1);
         functor(codeBlock, instruction, opcodeID, instruction[1].u.operand);
         return;
     }
@@ -86,14 +86,14 @@
     case op_jngreatereq:
     case op_jless:
     case op_copy_rest: {
-        ASSERT(opcodeLengths[opcodeID] >= 2);
+        ASSERT(opcodeLengths[opcodeID] > 2);
         functor(codeBlock, instruction, opcodeID, instruction[1].u.operand);
         functor(codeBlock, instruction, opcodeID, instruction[2].u.operand);
         return;
     }
     case op_put_by_val_direct:
     case op_put_by_val: {
-        ASSERT(opcodeLengths[opcodeID] >= 3);
+        ASSERT(opcodeLengths[opcodeID] > 3);
         functor(codeBlock, instruction, opcodeID, instruction[1].u.operand);
         functor(codeBlock, instruction, opcodeID, instruction[2].u.operand);
         functor(codeBlock, instruction, opcodeID, instruction[3].u.operand);
@@ -103,20 +103,20 @@
     case op_put_by_id:
     case op_put_to_scope:
     case op_put_to_arguments: {
-        ASSERT(opcodeLengths[opcodeID] >= 3);
+        ASSERT(opcodeLengths[opcodeID] > 3);
         functor(codeBlock, instruction, opcodeID, instruction[1].u.operand);
         functor(codeBlock, instruction, opcodeID, instruction[3].u.operand);
         return;
     }
     case op_put_getter_by_id:
     case op_put_setter_by_id: {
-        ASSERT(opcodeLengths[opcodeID] >= 4);
+        ASSERT(opcodeLengths[opcodeID] > 4);
         functor(codeBlock, instruction, opcodeID, instruction[1].u.operand);
         functor(codeBlock, instruction, opcodeID, instruction[4].u.operand);
         return;
     }
     case op_put_getter_setter_by_id: {
-        ASSERT(opcodeLengths[opcodeID] >= 5);
+        ASSERT(opcodeLengths[opcodeID] > 5);
         functor(codeBlock, instruction, opcodeID, instruction[1].u.operand);
         functor(codeBlock, instruction, opcodeID, instruction[4].u.operand);
         functor(codeBlock, instruction, opcodeID, instruction[5].u.operand);
@@ -124,7 +124,7 @@
     }
     case op_put_getter_by_val:
     case op_put_setter_by_val: {
-        ASSERT(opcodeLengths[opcodeID] >= 4);
+        ASSERT(opcodeLengths[opcodeID] > 4);
         functor(codeBlock, instruction, opcodeID, instruction[1].u.operand);
         functor(codeBlock, instruction, opcodeID, instruction[2].u.operand);
         functor(codeBlock, instruction, opcodeID, instruction[4].u.operand);
@@ -166,7 +166,7 @@
     case op_get_parent_scope:
     case op_create_scoped_arguments:
     case op_get_from_arguments: {
-        ASSERT(opcodeLengths[opcodeID] >= 2);
+        ASSERT(opcodeLengths[opcodeID] > 2);
         functor(codeBlock, instruction, opcodeID, instruction[2].u.operand);
         return;
     }

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to