Title: [195447] trunk
- Revision
- 195447
- Author
- [email protected]
- Date
- 2016-01-22 01:19:44 -0800 (Fri, 22 Jan 2016)
Log Message
[GTK] Remove a focus ring on anchor node when focused by mouse.
https://bugs.webkit.org/show_bug.cgi?id=136121
Reviewed by Michael Catanzaro.
Source/WebCore:
Safari, Chrome and FF don't show a focus ring, the dotted rectangle on anchor node
for mouse clicking. I think the behavior is reasonable and looks better.
No reason for gtk & efl ports to keep the focus on anchor node. Of course, this change should not
affect the focus ring for tab navigation.
No new tests since an existing test can cover this.
Tests: fast/events/click-focus-anchor.html
* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::isMouseFocusable):
LayoutTests:
Removed gtk and efl specific results for the test.
* platform/efl/fast/events/click-focus-anchor-expected.txt: Removed.
* platform/gtk/fast/events/click-focus-anchor-expected.txt: Removed.
Modified Paths
Removed Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (195446 => 195447)
--- trunk/LayoutTests/ChangeLog 2016-01-22 07:24:36 UTC (rev 195446)
+++ trunk/LayoutTests/ChangeLog 2016-01-22 09:19:44 UTC (rev 195447)
@@ -1,3 +1,15 @@
+2016-01-22 ChangSeok Oh <[email protected]>
+
+ [GTK] Remove a focus ring on anchor node when focused by mouse.
+ https://bugs.webkit.org/show_bug.cgi?id=136121
+
+ Reviewed by Michael Catanzaro.
+
+ Removed gtk and efl specific results for the test.
+
+ * platform/efl/fast/events/click-focus-anchor-expected.txt: Removed.
+ * platform/gtk/fast/events/click-focus-anchor-expected.txt: Removed.
+
2016-01-21 Simon Fraser <[email protected]>
REGRESSION (r168244): Content in horizontal-bt page is offset such that only the end is viewable and there is a white gap at the top
Deleted: trunk/LayoutTests/platform/efl/fast/events/click-focus-anchor-expected.txt (195446 => 195447)
--- trunk/LayoutTests/platform/efl/fast/events/click-focus-anchor-expected.txt 2016-01-22 07:24:36 UTC (rev 195446)
+++ trunk/LayoutTests/platform/efl/fast/events/click-focus-anchor-expected.txt 2016-01-22 09:19:44 UTC (rev 195447)
@@ -1,11 +0,0 @@
-This test ensures that we can click to focus an a element. Click on the element below.
-
-The expected result is platform specific. GTK, QT and EFL allows all links to be mouse focusable.
-
-Result
-
-
-a1 received focus (focusable)
-a3 received focus (focusable on GTK, QT and EFL)
-a4 received focus (focusable)
-a5 received focus (focusable)
Deleted: trunk/LayoutTests/platform/gtk/fast/events/click-focus-anchor-expected.txt (195446 => 195447)
--- trunk/LayoutTests/platform/gtk/fast/events/click-focus-anchor-expected.txt 2016-01-22 07:24:36 UTC (rev 195446)
+++ trunk/LayoutTests/platform/gtk/fast/events/click-focus-anchor-expected.txt 2016-01-22 09:19:44 UTC (rev 195447)
@@ -1,11 +0,0 @@
-This test ensures that we can click to focus an a element. Click on the element below.
-
-The expected result is platform specific. GTK, QT and EFL allows all links to be mouse focusable.
-
-Result
-
-
-a1 received focus (focusable)
-a3 received focus (focusable on GTK, QT and EFL)
-a4 received focus (focusable)
-a5 received focus (focusable)
Modified: trunk/Source/WebCore/ChangeLog (195446 => 195447)
--- trunk/Source/WebCore/ChangeLog 2016-01-22 07:24:36 UTC (rev 195446)
+++ trunk/Source/WebCore/ChangeLog 2016-01-22 09:19:44 UTC (rev 195447)
@@ -1,3 +1,21 @@
+2016-01-22 ChangSeok Oh <[email protected]>
+
+ [GTK] Remove a focus ring on anchor node when focused by mouse.
+ https://bugs.webkit.org/show_bug.cgi?id=136121
+
+ Reviewed by Michael Catanzaro.
+
+ Safari, Chrome and FF don't show a focus ring, the dotted rectangle on anchor node
+ for mouse clicking. I think the behavior is reasonable and looks better.
+ No reason for gtk & efl ports to keep the focus on anchor node. Of course, this change should not
+ affect the focus ring for tab navigation.
+
+ No new tests since an existing test can cover this.
+ Tests: fast/events/click-focus-anchor.html
+
+ * html/HTMLAnchorElement.cpp:
+ (WebCore::HTMLAnchorElement::isMouseFocusable):
+
2016-01-21 Simon Fraser <[email protected]>
REGRESSION (r168244): Content in horizontal-bt page is offset such that only the end is viewable and there is a white gap at the top
Modified: trunk/Source/WebCore/html/HTMLAnchorElement.cpp (195446 => 195447)
--- trunk/Source/WebCore/html/HTMLAnchorElement.cpp 2016-01-22 07:24:36 UTC (rev 195446)
+++ trunk/Source/WebCore/html/HTMLAnchorElement.cpp 2016-01-22 09:19:44 UTC (rev 195447)
@@ -95,12 +95,9 @@
bool HTMLAnchorElement::isMouseFocusable() const
{
-#if !(PLATFORM(EFL) || PLATFORM(GTK))
// Only allow links with tabIndex or contentEditable to be mouse focusable.
- // This is our rule for the Mac platform; on many other platforms we focus any link you click on.
if (isLink())
return HTMLElement::supportsFocus();
-#endif
return HTMLElement::isMouseFocusable();
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
