Title: [195454] trunk/Source/WebInspectorUI
- Revision
- 195454
- Author
- [email protected]
- Date
- 2016-01-22 10:03:26 -0800 (Fri, 22 Jan 2016)
Log Message
Web Inspector: Class toggle add icon flashes when changing nodes
https://bugs.webkit.org/show_bug.cgi?id=153341
Patch by Devin Rousso <[email protected]> on 2016-01-22
Reviewed by Timothy Hatcher.
* UserInterface/Views/CSSStyleDetailsSidebarPanel.js:
(WebInspector.CSSStyleDetailsSidebarPanel.prototype._populateClassToggles):
Changed the way in which the class toggles are repopulated to prevent the
add class icon from being removed and re-added.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (195453 => 195454)
--- trunk/Source/WebInspectorUI/ChangeLog 2016-01-22 17:35:50 UTC (rev 195453)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-01-22 18:03:26 UTC (rev 195454)
@@ -1,3 +1,15 @@
+2016-01-22 Devin Rousso <[email protected]>
+
+ Web Inspector: Class toggle add icon flashes when changing nodes
+ https://bugs.webkit.org/show_bug.cgi?id=153341
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/CSSStyleDetailsSidebarPanel.js:
+ (WebInspector.CSSStyleDetailsSidebarPanel.prototype._populateClassToggles):
+ Changed the way in which the class toggles are repopulated to prevent the
+ add class icon from being removed and re-added.
+
2016-01-21 Nikita Vasilyev <[email protected]>
REGRESSION (r195305): Web Inspector: WebInspector.Object can dispatch constructor-level events multiple times
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.js (195453 => 195454)
--- trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.js 2016-01-22 17:35:50 UTC (rev 195453)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.js 2016-01-22 18:03:26 UTC (rev 195454)
@@ -353,8 +353,9 @@
_populateClassToggles()
{
- this._classListContainer.removeChildren();
- this._classListContainer.appendChild(this._addClassContainer);
+ // Ensure that _addClassContainer is the first child of _classListContainer.
+ while (this._classListContainer.children.length > 1)
+ this._classListContainer.children[1].remove();
let classes = this.domNode.getAttribute("class");
let classToggledMap = this.domNode[WebInspector.CSSStyleDetailsSidebarPanel.ToggledClassesSymbol];
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
