Diff
Modified: trunk/LayoutTests/ChangeLog (195506 => 195507)
--- trunk/LayoutTests/ChangeLog 2016-01-23 07:13:03 UTC (rev 195506)
+++ trunk/LayoutTests/ChangeLog 2016-01-23 07:13:53 UTC (rev 195507)
@@ -1,3 +1,18 @@
+2016-01-22 Commit Queue <[email protected]>
+
+ Unreviewed, rolling out r195493.
+ https://bugs.webkit.org/show_bug.cgi?id=153397
+
+ Broke authenticaiton tests (leaks credentials) (Requested by
+ ap on #webkit).
+
+ Reverted changeset:
+
+ "LayoutTest http/tests/security/xssAuditor/embed-tag-in-path-
+ unterminated.html crashing"
+ https://bugs.webkit.org/show_bug.cgi?id=153250
+ http://trac.webkit.org/changeset/195493
+
2016-01-20 Ryosuke Niwa <[email protected]>
HTMLElement::nodeName should not upper case non-ASCII characters
Deleted: trunk/LayoutTests/http/tests/loading/basic-auth-load-URL-with-consecutive-slashes-expected.txt (195506 => 195507)
--- trunk/LayoutTests/http/tests/loading/basic-auth-load-URL-with-consecutive-slashes-expected.txt 2016-01-23 07:13:03 UTC (rev 195506)
+++ trunk/LayoutTests/http/tests/loading/basic-auth-load-URL-with-consecutive-slashes-expected.txt 2016-01-23 07:13:53 UTC (rev 195507)
@@ -1,19 +0,0 @@
-main frame - didStartProvisionalLoadForFrame
-main frame - didCommitLoadForFrame
-frame "frame" - didStartProvisionalLoadForFrame
-main frame - didFinishDocumentLoadForFrame
-http://127.0.0.1:8000/loading/resources/basic-auth-testing.php?username=webkit&password=rocks - didReceiveAuthenticationChallenge - Responding with webkit:rocks
-frame "frame" - didCommitLoadForFrame
-frame "frame" - didFinishDocumentLoadForFrame
-frame "frame" - willPerformClientRedirectToURL: http://127.0.0.1:8000/a//b/non-existent-file.html
-frame "frame" - didHandleOnloadEventsForFrame
-main frame - didHandleOnloadEventsForFrame
-frame "frame" - didFinishLoadForFrame
-main frame - didFinishLoadForFrame
-frame "frame" - didStartProvisionalLoadForFrame
-frame "frame" - didCancelClientRedirectForFrame
-frame "frame" - didCommitLoadForFrame
-frame "frame" - didReceiveTitle: 404 Not Found
-frame "frame" - didFinishDocumentLoadForFrame
-frame "frame" - didFailLoadWithError
-PASS did not cause assertion failure.
Deleted: trunk/LayoutTests/http/tests/loading/basic-auth-load-URL-with-consecutive-slashes.html (195506 => 195507)
--- trunk/LayoutTests/http/tests/loading/basic-auth-load-URL-with-consecutive-slashes.html 2016-01-23 07:13:03 UTC (rev 195506)
+++ trunk/LayoutTests/http/tests/loading/basic-auth-load-URL-with-consecutive-slashes.html 2016-01-23 07:13:53 UTC (rev 195507)
@@ -1,31 +0,0 @@
-<!DOCTYPE html>
-<html>
-<head>
-<script>
-if (window.testRunner) {
- testRunner.dumpAsText();
- testRunner.setHandlesAuthenticationChallenges(true);
- testRunner.setAuthenticationUsername("webkit");
- testRunner.setAuthenticationPassword("rocks");
- testRunner.waitUntilDone();
-}
-
-function done()
-{
- document.body.removeChild(document.getElementById("frame"));
- if (window.testRunner)
- testRunner.notifyDone();
-}
-
-function notifyFrameDidLoad(frame)
-{
- frame._onload_ = done;
- frame.src = ""
-}
-</script>
-</head>
-<body>
-<iframe id="frame" src="" _onload_="notifyFrameDidLoad(this)"></iframe>
-<p>PASS did not cause assertion failure.</p>
-</body>
-</html>
Deleted: trunk/LayoutTests/http/tests/xmlhttprequest/basic-auth-load-URL-with-consecutive-slashes-expected.txt (195506 => 195507)
--- trunk/LayoutTests/http/tests/xmlhttprequest/basic-auth-load-URL-with-consecutive-slashes-expected.txt 2016-01-23 07:13:03 UTC (rev 195506)
+++ trunk/LayoutTests/http/tests/xmlhttprequest/basic-auth-load-URL-with-consecutive-slashes-expected.txt 2016-01-23 07:13:53 UTC (rev 195507)
@@ -1 +0,0 @@
-PASS did not cause assertion failure.
Deleted: trunk/LayoutTests/http/tests/xmlhttprequest/basic-auth-load-URL-with-consecutive-slashes.html (195506 => 195507)
--- trunk/LayoutTests/http/tests/xmlhttprequest/basic-auth-load-URL-with-consecutive-slashes.html 2016-01-23 07:13:03 UTC (rev 195506)
+++ trunk/LayoutTests/http/tests/xmlhttprequest/basic-auth-load-URL-with-consecutive-slashes.html 2016-01-23 07:13:53 UTC (rev 195507)
@@ -1,35 +0,0 @@
-<!DOCTYPE html>
-<html>
-<body>
-<script>
-if (window.testRunner)
- testRunner.dumpAsText()
-
-function sendWithCredentials()
-{
- var xhr = new XMLHttpRequest;
- xhr.open("GET", "resources/remember-bad-password/count-failures.php", false, "foo", "bar");
- xhr.send("");
-}
-
-function sendWithoutCredentials()
-{
- var xhr = new XMLHttpRequest;
- xhr.open("GET", "resources/remember-bad-password//count-failures.php", false);
- xhr.send("");
-}
-
-function reset()
-{
- var xhr = new XMLHttpRequest;
- xhr.open("GET", "resources/remember-bad-password/count-failures.php?command=reset", false);
- xhr.send("");
-}
-
-sendWithCredentials();
-sendWithoutCredentials();
-reset();
-</script>
-<p>PASS did not cause assertion failure.</p>
-</body>
-</html>
Deleted: trunk/LayoutTests/platform/wk2/http/tests/loading/basic-auth-load-URL-with-consecutive-slashes-expected.txt (195506 => 195507)
--- trunk/LayoutTests/platform/wk2/http/tests/loading/basic-auth-load-URL-with-consecutive-slashes-expected.txt 2016-01-23 07:13:03 UTC (rev 195506)
+++ trunk/LayoutTests/platform/wk2/http/tests/loading/basic-auth-load-URL-with-consecutive-slashes-expected.txt 2016-01-23 07:13:53 UTC (rev 195507)
@@ -1,19 +0,0 @@
-main frame - didStartProvisionalLoadForFrame
-main frame - didCommitLoadForFrame
-frame "frame" - didStartProvisionalLoadForFrame
-main frame - didFinishDocumentLoadForFrame
-127.0.0.1:8000 - didReceiveAuthenticationChallenge - Responding with webkit:rocks
-frame "frame" - didCommitLoadForFrame
-frame "frame" - didFinishDocumentLoadForFrame
-frame "frame" - willPerformClientRedirectToURL: http://127.0.0.1:8000/a//b/non-existent-file.html
-frame "frame" - didHandleOnloadEventsForFrame
-main frame - didHandleOnloadEventsForFrame
-frame "frame" - didFinishLoadForFrame
-main frame - didFinishLoadForFrame
-frame "frame" - didStartProvisionalLoadForFrame
-frame "frame" - didCancelClientRedirectForFrame
-frame "frame" - didCommitLoadForFrame
-frame "frame" - didReceiveTitle: 404 Not Found
-frame "frame" - didFinishDocumentLoadForFrame
-frame "frame" - didFailLoadWithError
-PASS did not cause assertion failure.
Modified: trunk/Source/WebCore/ChangeLog (195506 => 195507)
--- trunk/Source/WebCore/ChangeLog 2016-01-23 07:13:03 UTC (rev 195506)
+++ trunk/Source/WebCore/ChangeLog 2016-01-23 07:13:53 UTC (rev 195507)
@@ -1,3 +1,18 @@
+2016-01-22 Commit Queue <[email protected]>
+
+ Unreviewed, rolling out r195493.
+ https://bugs.webkit.org/show_bug.cgi?id=153397
+
+ Broke authenticaiton tests (leaks credentials) (Requested by
+ ap on #webkit).
+
+ Reverted changeset:
+
+ "LayoutTest http/tests/security/xssAuditor/embed-tag-in-path-
+ unterminated.html crashing"
+ https://bugs.webkit.org/show_bug.cgi?id=153250
+ http://trac.webkit.org/changeset/195493
+
2016-01-20 Ryosuke Niwa <[email protected]>
HTMLElement::nodeName should not upper case non-ASCII characters
Modified: trunk/Source/WebCore/platform/network/CredentialStorage.cpp (195506 => 195507)
--- trunk/Source/WebCore/platform/network/CredentialStorage.cpp 2016-01-23 07:13:03 UTC (rev 195506)
+++ trunk/Source/WebCore/platform/network/CredentialStorage.cpp 2016-01-23 07:13:53 UTC (rev 195507)
@@ -123,6 +123,7 @@
ASSERT(index != notFound);
directoryURL = directoryURL.substring(0, (index == directoryURLPathStart) ? index + 1 : index);
ASSERT(directoryURL.length() > directoryURLPathStart);
+ ASSERT(directoryURL.length() == directoryURLPathStart + 1 || directoryURL[directoryURL.length() - 1] != '/');
}
}
