Title: [195514] trunk/LayoutTests
Revision
195514
Author
[email protected]
Date
2016-01-24 12:39:27 -0800 (Sun, 24 Jan 2016)

Log Message

Layout Test displaylists/extent-includes-transforms.html is flaky on mac-wk1
https://bugs.webkit.org/show_bug.cgi?id=153308

Reviewed by Dan Bernstein.

Rather than assuming that a zero-delay timer will fire after the next layer flush,
force a flush with testRunner.display(), which fixes flakiness.

* displaylists/resources/dump-target-display-list.js:
(doTest):

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (195513 => 195514)


--- trunk/LayoutTests/ChangeLog	2016-01-24 17:06:42 UTC (rev 195513)
+++ trunk/LayoutTests/ChangeLog	2016-01-24 20:39:27 UTC (rev 195514)
@@ -1,3 +1,16 @@
+2016-01-23  Simon Fraser  <[email protected]>
+
+        Layout Test displaylists/extent-includes-transforms.html is flaky on mac-wk1
+        https://bugs.webkit.org/show_bug.cgi?id=153308
+
+        Reviewed by Dan Bernstein.
+
+        Rather than assuming that a zero-delay timer will fire after the next layer flush,
+        force a flush with testRunner.display(), which fixes flakiness.
+
+        * displaylists/resources/dump-target-display-list.js:
+        (doTest):
+
 2016-01-23  Wonchul Lee  <[email protected]>
 
         [GTK] Fix media controls displaying without controls attribute

Modified: trunk/LayoutTests/displaylists/resources/dump-target-display-list.js (195513 => 195514)


--- trunk/LayoutTests/displaylists/resources/dump-target-display-list.js	2016-01-24 17:06:42 UTC (rev 195513)
+++ trunk/LayoutTests/displaylists/resources/dump-target-display-list.js	2016-01-24 20:39:27 UTC (rev 195514)
@@ -1,7 +1,5 @@
-if (window.testRunner) {
+if (window.testRunner)
     testRunner.dumpAsText();
-    testRunner.waitUntilDone();
-}
 
 var targetDiv;
 function doTest()
@@ -11,13 +9,12 @@
     if (window.internals)
         internals.setElementUsesDisplayListDrawing(targetDiv, true);
     
-    window.setTimeout(function() {
-        if (window.internals) {
-            var displayList = internals.displayListForElement(targetDiv);
-            document.getElementById('output').textContent = displayList;
-        }
-        if (window.testRunner)
-            testRunner.notifyDone();
-    }, 0);
+    if (window.testRunner)
+        testRunner.display();
+
+    if (window.internals) {
+        var displayList = internals.displayListForElement(targetDiv);
+        document.getElementById('output').textContent = displayList;
+    }
 }
 window.addEventListener('load', doTest, false);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to