Title: [195536] trunk/Source/WebInspectorUI
- Revision
- 195536
- Author
- [email protected]
- Date
- 2016-01-25 08:19:30 -0800 (Mon, 25 Jan 2016)
Log Message
Web Inspector: timelines clear button should be inactive if nothing can be cleared
https://bugs.webkit.org/show_bug.cgi?id=132756
Patch by Johan K. Jensen <[email protected]> on 2016-01-25
Reviewed by Timothy Hatcher.
* UserInterface/Views/TimelineRecordingContentView.js:
(WebInspector.TimelineRecordingContentView.prototype.shown):
Enable clear button if timeline is not readonly and contains data, when switching timelines.
(WebInspector.TimelineRecordingContentView.prototype._capturingStarted):
Enable clear button when a capturing starts.
(WebInspector.TimelineRecordingContentView.prototype._recordingReset):
Disable clear button after resetting recording.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (195535 => 195536)
--- trunk/Source/WebInspectorUI/ChangeLog 2016-01-25 16:18:42 UTC (rev 195535)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-01-25 16:19:30 UTC (rev 195536)
@@ -1,3 +1,18 @@
+2016-01-25 Johan K. Jensen <[email protected]>
+
+ Web Inspector: timelines clear button should be inactive if nothing can be cleared
+ https://bugs.webkit.org/show_bug.cgi?id=132756
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/TimelineRecordingContentView.js:
+ (WebInspector.TimelineRecordingContentView.prototype.shown):
+ Enable clear button if timeline is not readonly and contains data, when switching timelines.
+ (WebInspector.TimelineRecordingContentView.prototype._capturingStarted):
+ Enable clear button when a capturing starts.
+ (WebInspector.TimelineRecordingContentView.prototype._recordingReset):
+ Disable clear button after resetting recording.
+
2016-01-25 Matt Baker <[email protected]>
Web Inspector: Timelines: "Timer Installed150ms delay" — no space before the delay number
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js (195535 => 195536)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js 2016-01-25 16:18:42 UTC (rev 195535)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js 2016-01-25 16:19:30 UTC (rev 195536)
@@ -163,7 +163,7 @@
{
this._currentTimelineOverview.shown();
this._contentViewContainer.shown();
- this._clearTimelineNavigationItem.enabled = !this._recording.readonly;
+ this._clearTimelineNavigationItem.enabled = !this._recording.readonly && !isNaN(this._recording.startTime);
this._currentContentViewDidChange();
@@ -502,6 +502,7 @@
{
if (!this._updating)
this._startUpdatingCurrentTime(event.data.startTime);
+ this._clearTimelineNavigationItem.enabled = !this._recording.readonly;
}
_capturingStopped(event)
@@ -654,6 +655,7 @@
this._overviewTimelineView.reset();
for (var timelineView of this._timelineViewMap.values())
timelineView.reset();
+ this._clearTimelineNavigationItem.enabled = false;
}
_recordingUnloaded(event)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
