Title: [195601] trunk/Source/WebCore
Revision
195601
Author
[email protected]
Date
2016-01-26 11:02:40 -0800 (Tue, 26 Jan 2016)

Log Message

Fix build with ENABLE_DEVICE_ORIENTATION on non-iOS platforms
https://bugs.webkit.org/show_bug.cgi?id=153490

Patch by Olivier Blin <[email protected]> on 2016-01-26
Reviewed by Michael Catanzaro.

This has been broken since r178702, which changed the Page
argument from a pointer to a reference in logCanCachePageDecision().

No new tests since this is a build fix.

* history/PageCache.cpp:
(WebCore::canCachePage):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (195600 => 195601)


--- trunk/Source/WebCore/ChangeLog	2016-01-26 18:56:00 UTC (rev 195600)
+++ trunk/Source/WebCore/ChangeLog	2016-01-26 19:02:40 UTC (rev 195601)
@@ -1,3 +1,18 @@
+2016-01-26  Olivier Blin  <[email protected]>
+
+        Fix build with ENABLE_DEVICE_ORIENTATION on non-iOS platforms
+        https://bugs.webkit.org/show_bug.cgi?id=153490
+
+        Reviewed by Michael Catanzaro.
+
+        This has been broken since r178702, which changed the Page
+        argument from a pointer to a reference in logCanCachePageDecision().
+
+        No new tests since this is a build fix.
+
+        * history/PageCache.cpp:
+        (WebCore::canCachePage):
+
 2016-01-25  Ada Chan  <[email protected]>
 
         Move WebVideoFullscreenManager and related classes from iOS specific folders to cocoa folders

Modified: trunk/Source/WebCore/history/PageCache.cpp (195600 => 195601)


--- trunk/Source/WebCore/history/PageCache.cpp	2016-01-26 18:56:00 UTC (rev 195600)
+++ trunk/Source/WebCore/history/PageCache.cpp	2016-01-26 19:02:40 UTC (rev 195601)
@@ -198,12 +198,12 @@
         isCacheable = false;
     }
 #if ENABLE(DEVICE_ORIENTATION) && !PLATFORM(IOS)
-    if (DeviceMotionController::isActiveAt(page)) {
+    if (DeviceMotionController::isActiveAt(&page)) {
         PCLOG("   -Page is using DeviceMotion");
         logPageCacheFailureDiagnosticMessage(diagnosticLoggingClient, DiagnosticLoggingKeys::deviceMotionKey());
         isCacheable = false;
     }
-    if (DeviceOrientationController::isActiveAt(page)) {
+    if (DeviceOrientationController::isActiveAt(&page)) {
         PCLOG("   -Page is using DeviceOrientation");
         logPageCacheFailureDiagnosticMessage(diagnosticLoggingClient, DiagnosticLoggingKeys::deviceOrientationKey());
         isCacheable = false;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to