Title: [195612] trunk/Source/WebCore
- Revision
- 195612
- Author
- mcatanz...@igalia.com
- Date
- 2016-01-26 13:12:31 -0800 (Tue, 26 Jan 2016)
Log Message
CSSGrammar.y:1742.31-34: warning: unused value: $3
https://bugs.webkit.org/show_bug.cgi?id=153462
Reviewed by Alex Christensen.
This warning indicates that we have a memory leak. From the bison manual:
"Right-hand side symbols of a rule that explicitly triggers a syntax error via YYERROR are
not discarded automatically. As a rule of thumb, destructors are invoked only when user
actions cannot manage the memory."
Arguably a design error, but that's how it is.
* css/CSSGrammar.y.in:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (195611 => 195612)
--- trunk/Source/WebCore/ChangeLog 2016-01-26 21:09:24 UTC (rev 195611)
+++ trunk/Source/WebCore/ChangeLog 2016-01-26 21:12:31 UTC (rev 195612)
@@ -1,3 +1,20 @@
+2016-01-26 Michael Catanzaro <mcatanz...@igalia.com>
+
+ CSSGrammar.y:1742.31-34: warning: unused value: $3
+ https://bugs.webkit.org/show_bug.cgi?id=153462
+
+ Reviewed by Alex Christensen.
+
+ This warning indicates that we have a memory leak. From the bison manual:
+
+ "Right-hand side symbols of a rule that explicitly triggers a syntax error via YYERROR are
+ not discarded automatically. As a rule of thumb, destructors are invoked only when user
+ actions cannot manage the memory."
+
+ Arguably a design error, but that's how it is.
+
+ * css/CSSGrammar.y.in:
+
2016-01-26 Jer Noble <jer.no...@apple.com>
Calling video.controls=true during a scrub operation cancels scrub.
Modified: trunk/Source/WebCore/css/CSSGrammar.y.in (195611 => 195612)
--- trunk/Source/WebCore/css/CSSGrammar.y.in 2016-01-26 21:09:24 UTC (rev 195611)
+++ trunk/Source/WebCore/css/CSSGrammar.y.in 2016-01-26 21:12:31 UTC (rev 195612)
@@ -1824,6 +1824,7 @@
| VARFUNCTION maybe_space expr closing_parenthesis {
$$.id = CSSValueInvalid;
$$.unit = 0;
+ delete $3;
YYERROR;
}
| VARFUNCTION maybe_space expr_recovery closing_parenthesis {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
