Title: [195706] trunk/Source/WebInspectorUI
- Revision
- 195706
- Author
- [email protected]
- Date
- 2016-01-27 16:18:37 -0800 (Wed, 27 Jan 2016)
Log Message
Web Inspector: Regression (r195303) - Changes to TreeOutline break styling of lists in Visual sidebar
https://bugs.webkit.org/show_bug.cgi?id=153563
Patch by Devin Rousso <[email protected]> on 2016-01-27
Reviewed by Timothy Hatcher.
Removed duplicate properties and used new methods of TreeOutline to achieve
the desired styling effects.
* UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.css:
(.visual-style-property-container.comma-separated-keyword-editor > .visual-style-property-value-container > .visual-style-comma-separated-keyword-list > .visual-style-comma-separated-keyword-item.visual-style-font-family-list-item > .visual-style-comma-separated-keyword-item-editor):
(.visual-style-property-container.comma-separated-keyword-editor > .visual-style-property-value-container > .visual-style-comma-separated-keyword-list > .visual-style-comma-separated-keyword-item > .titles): Deleted.
* UserInterface/Views/VisualStyleSelectorSection.js:
(WebInspector.VisualStyleSelectorSection):
* UserInterface/Views/VisualStyleSelectorTreeItem.css:
(.item.visual-style-selector-item > .icon):
(.item.visual-style-selector-item > .titles):
(.item.visual-style-selector-item > .titles > .subtitle):
(.item.visual-style-selector-item.selected > .titles > .subtitle):
(.item.visual-style-selector-item > .titles > .subtitle::before): Deleted.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (195705 => 195706)
--- trunk/Source/WebInspectorUI/ChangeLog 2016-01-28 00:17:20 UTC (rev 195705)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-01-28 00:18:37 UTC (rev 195706)
@@ -1,3 +1,27 @@
+2016-01-27 Devin Rousso <[email protected]>
+
+ Web Inspector: Regression (r195303) - Changes to TreeOutline break styling of lists in Visual sidebar
+ https://bugs.webkit.org/show_bug.cgi?id=153563
+
+ Reviewed by Timothy Hatcher.
+
+ Removed duplicate properties and used new methods of TreeOutline to achieve
+ the desired styling effects.
+
+ * UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.css:
+ (.visual-style-property-container.comma-separated-keyword-editor > .visual-style-property-value-container > .visual-style-comma-separated-keyword-list > .visual-style-comma-separated-keyword-item.visual-style-font-family-list-item > .visual-style-comma-separated-keyword-item-editor):
+ (.visual-style-property-container.comma-separated-keyword-editor > .visual-style-property-value-container > .visual-style-comma-separated-keyword-list > .visual-style-comma-separated-keyword-item > .titles): Deleted.
+
+ * UserInterface/Views/VisualStyleSelectorSection.js:
+ (WebInspector.VisualStyleSelectorSection):
+
+ * UserInterface/Views/VisualStyleSelectorTreeItem.css:
+ (.item.visual-style-selector-item > .icon):
+ (.item.visual-style-selector-item > .titles):
+ (.item.visual-style-selector-item > .titles > .subtitle):
+ (.item.visual-style-selector-item.selected > .titles > .subtitle):
+ (.item.visual-style-selector-item > .titles > .subtitle::before): Deleted.
+
2016-01-27 Simon Fraser <[email protected]>
Support CSS3 Images values for the image-rendering property
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.css (195705 => 195706)
--- trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.css 2016-01-28 00:17:20 UTC (rev 195705)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.css 2016-01-28 00:18:37 UTC (rev 195706)
@@ -65,10 +65,6 @@
display: none;
}
-.visual-style-property-container.comma-separated-keyword-editor > .visual-style-property-value-container > .visual-style-comma-separated-keyword-list > .visual-style-comma-separated-keyword-item > .titles {
- padding-left: 3px;
-}
-
.visual-style-property-container.comma-separated-keyword-editor > .visual-style-property-value-container > .visual-style-comma-separated-keyword-list > .visual-style-comma-separated-keyword-item.visual-style-font-family-list-item.selected:not(.editor-hidden) > .titles > * {
color: transparent;
}
@@ -76,12 +72,12 @@
.visual-style-property-container.comma-separated-keyword-editor > .visual-style-property-value-container > .visual-style-comma-separated-keyword-list > .visual-style-comma-separated-keyword-item.visual-style-font-family-list-item > .visual-style-comma-separated-keyword-item-editor {
position: absolute;
top: 0;
- right: 3px;
+ right: 0;
bottom: 0;
- left: 3px;
+ left: 5px;
margin: 0;
padding: 0;
- line-height: 13px;
+ line-height: 17px;
border: none;
background-color: transparent;
font-family: inherit;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleSelectorSection.js (195705 => 195706)
--- trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleSelectorSection.js 2016-01-28 00:17:20 UTC (rev 195705)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleSelectorSection.js 2016-01-28 00:18:37 UTC (rev 195706)
@@ -55,6 +55,7 @@
selectorSection.element.appendChild(selectorListElement);
this._selectors = new WebInspector.TreeOutline(selectorListElement);
+ this._selectors.disclosureButtons = false;
this._selectors.addEventListener(WebInspector.TreeOutline.Event.SelectionDidChange, this._selectorChanged, this);
this._newInspectorRuleSelector = null;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleSelectorTreeItem.css (195705 => 195706)
--- trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleSelectorTreeItem.css 2016-01-28 00:17:20 UTC (rev 195705)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleSelectorTreeItem.css 2016-01-28 00:18:37 UTC (rev 195706)
@@ -61,7 +61,7 @@
.item.visual-style-selector-item > .icon {
width: 16px;
height: 16px;
- margin-left: 4px;
+ margin: 0 3px 0 4px;
}
.item.visual-style-selector-item.modified > .icon {
@@ -103,10 +103,11 @@
.item.visual-style-selector-item > .titles {
flex: 1;
+ top: 0;
+ line-height: inherit;
overflow: hidden;
white-space: nowrap;
text-overflow: ellipsis;
- padding: 0 2px 0 3px;
}
.item.visual-style-selector-item:not(.dom-element-icon) > .titles > .title {
@@ -128,14 +129,11 @@
box-shadow: hsla(0, 0%, 0%, 0.15) 0 1px 0, 0 0 0 3px hsla(0, 100%, 100%, 0.3);
}
-.item.visual-style-selector-item > .titles > .subtitle::before {
- margin-right: 5px;
- font-size: 11px;
- /* The extra space at the beginning is necessary to prevent the -webkit-user-modify
- cursor bar from displaying at the beginning of the em-dash. */
- content: " \2014"; /* em-dash */
-}
-
.item.visual-style-selector-item > .titles > .subtitle {
+ vertical-align: 1px;
font-size: 9px;
}
+
+.item.visual-style-selector-item.selected > .titles > .subtitle {
+ color: inherit;
+}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
