Title: [195725] trunk
Revision
195725
Author
[email protected]
Date
2016-01-27 18:28:03 -0800 (Wed, 27 Jan 2016)

Log Message

[EFL] Remove unused accessibility related code
https://bugs.webkit.org/show_bug.cgi?id=153543

Reviewed by Darin Adler.

Source/WebKit2:

Do not need to load external library to expose WebKit's
accessibility tree. There have been changes in EFL/Elementary
in terms of support of accessibility and we should follow those.

* WebProcess/efl/WebProcessMainEfl.cpp:
(eailLibraryPath): Deleted.
(eail): Deleted.

Tools:

Removed reference to EAIL library.
It not going to be support anymore. There have been changes in
EFL/Elementary in terms of the accessibility and we should
follow those.

* efl/jhbuild-optional.modules:

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (195724 => 195725)


--- trunk/Source/WebKit2/ChangeLog	2016-01-28 02:21:25 UTC (rev 195724)
+++ trunk/Source/WebKit2/ChangeLog	2016-01-28 02:28:03 UTC (rev 195725)
@@ -1,3 +1,18 @@
+2016-01-27  Krzysztof Czech  <[email protected]>
+
+        [EFL] Remove unused accessibility related code
+        https://bugs.webkit.org/show_bug.cgi?id=153543
+
+        Reviewed by Darin Adler.
+
+        Do not need to load external library to expose WebKit's
+        accessibility tree. There have been changes in EFL/Elementary
+        in terms of support of accessibility and we should follow those.
+
+        * WebProcess/efl/WebProcessMainEfl.cpp:
+        (eailLibraryPath): Deleted.
+        (eail): Deleted.
+
 2016-01-27  Enrica Casucci  <[email protected]>
 
         Cache results of data detection in the UI process when load completes.

Modified: trunk/Source/WebKit2/WebProcess/efl/WebProcessMainEfl.cpp (195724 => 195725)


--- trunk/Source/WebKit2/WebProcess/efl/WebProcessMainEfl.cpp	2016-01-28 02:21:25 UTC (rev 195724)
+++ trunk/Source/WebKit2/WebProcess/efl/WebProcessMainEfl.cpp	2016-01-28 02:28:03 UTC (rev 195725)
@@ -35,28 +35,6 @@
 #include <WebCore/SoupNetworkSession.h>
 #include <libsoup/soup.h>
 
-#if HAVE(ACCESSIBILITY)
-#include "Module.h"
-/*
- * This should be defined and filled in elementary but to avoid undefined reference it's defined here.
- * Setting this variable to nullptr will not cause any trouble to webkit and eail as well.
- */
-Eina_List* _elm_win_list = nullptr;
-
-typedef int (*EailFunction)(void*);
-
-static char* eailLibraryPath()
-{
-    return getenv("ACCESSIBILITY_EAIL_LIBRARY_PATH");
-}
-
-static WebKit::Module& eail()
-{
-    static NeverDestroyed<WebKit::Module> eail(eailLibraryPath());
-    return eail;
-}
-#endif
-
 #ifdef HAVE_ECORE_X
 #include <Ecore_X.h>
 #include <X11/Xlib.h>
@@ -120,14 +98,6 @@
         if (!ecore_main_loop_glib_integrate())
             return false;
 
-#if HAVE(ACCESSIBILITY)
-        // Initialize EAIL module (adding listeners, init atk-bridge)
-        if (eailLibraryPath() && eail().load()) {
-            if (EailFunction eailInit = eail().functionPointer<EailFunction>("elm_modapi_init"))
-                eailInit(nullptr);
-        }
-#endif
-
         SoupNetworkSession::defaultSession().setupHTTPProxyFromEnvironment();
         return true;
     }
@@ -146,13 +116,6 @@
 #endif
         ecore_shutdown();
         eina_shutdown();
-
-#if HAVE(ACCESSIBILITY)
-        if (eailLibraryPath()) {
-            if (EailFunction eailShutdown = eail().functionPointer<EailFunction>("elm_modapi_shutdown"))
-                eailShutdown(nullptr);
-        }
-#endif
     }
 };
 

Modified: trunk/Tools/ChangeLog (195724 => 195725)


--- trunk/Tools/ChangeLog	2016-01-28 02:21:25 UTC (rev 195724)
+++ trunk/Tools/ChangeLog	2016-01-28 02:28:03 UTC (rev 195725)
@@ -1,3 +1,17 @@
+2016-01-27  Krzysztof Czech  <[email protected]>
+
+        [EFL] Remove unused accessibility related code
+        https://bugs.webkit.org/show_bug.cgi?id=153543
+
+        Reviewed by Darin Adler.
+
+        Removed reference to EAIL library.
+        It not going to be support anymore. There have been changes in
+        EFL/Elementary in terms of the accessibility and we should
+        follow those.
+
+        * efl/jhbuild-optional.modules:
+
 2016-01-27  Daniel Bates  <[email protected]>
 
         Remove WebKitSystemInterface for iOS SDK < 9

Modified: trunk/Tools/efl/jhbuild-optional.modules (195724 => 195725)


--- trunk/Tools/efl/jhbuild-optional.modules	2016-01-28 02:21:25 UTC (rev 195724)
+++ trunk/Tools/efl/jhbuild-optional.modules	2016-01-28 02:28:03 UTC (rev 195725)
@@ -5,8 +5,6 @@
 
   <repository type="tarball" name="ftp.gnome.org"
       href=""
-  <repository type="git" name="github"
-     href=""
 
   <autotools id="at-spi2-core"
           autogenargs="--disable-introspection">
@@ -31,8 +29,4 @@
     </dependencies>
   </autotools>
 
-  <autotools id="eail" autogen-sh="autogen.sh">
-    <branch repo="github" module="eail.git" checkoutdir="eail-1.0.0"/>
-</autotools>
-
 </moduleset>
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to