Diff
Modified: trunk/LayoutTests/ChangeLog (195728 => 195729)
--- trunk/LayoutTests/ChangeLog 2016-01-28 05:21:57 UTC (rev 195728)
+++ trunk/LayoutTests/ChangeLog 2016-01-28 05:33:22 UTC (rev 195729)
@@ -1,3 +1,21 @@
+2016-01-27 Chris Dumez <[email protected]>
+
+ Expose ApplicationCache on the global Window object
+ https://bugs.webkit.org/show_bug.cgi?id=153578
+
+ Reviewed by Antti Koivisto.
+
+ Rebaseline test now that ApplicationCache is exposed on the global
+ Window object.
+
+ * js/dom/global-constructors-attributes-expected.txt:
+ * platform/efl/js/dom/global-constructors-attributes-expected.txt:
+ * platform/gtk/js/dom/global-constructors-attributes-expected.txt:
+ * platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
+ * platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
+ * platform/mac/js/dom/global-constructors-attributes-expected.txt:
+ * platform/win/js/dom/global-constructors-attributes-expected.txt:
+
2016-01-27 Ryosuke Niwa <[email protected]>
REGRESSION(r190430): Assertion failure in Text::~Text()
Modified: trunk/LayoutTests/fast/loader/window-properties-restored-from-page-cache-expected.txt (195728 => 195729)
--- trunk/LayoutTests/fast/loader/window-properties-restored-from-page-cache-expected.txt 2016-01-28 05:21:57 UTC (rev 195728)
+++ trunk/LayoutTests/fast/loader/window-properties-restored-from-page-cache-expected.txt 2016-01-28 05:33:22 UTC (rev 195729)
@@ -1,5 +1,5 @@
This test makes sure that various properties on the window object are correctly reconnected after restoring a page from the page cache.
-[object DOMApplicationCache]
+[object ApplicationCache]
[object Console]
[object Crypto]
[object History]
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (195728 => 195729)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2016-01-28 05:21:57 UTC (rev 195728)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-01-28 05:33:22 UTC (rev 195729)
@@ -1,5 +1,16 @@
2016-01-27 Chris Dumez <[email protected]>
+ Expose ApplicationCache on the global Window object
+ https://bugs.webkit.org/show_bug.cgi?id=153578
+
+ Reviewed by Antti Koivisto.
+
+ Rebaseline W3C HTML test now that more checks are passing.
+
+ * web-platform-tests/html/dom/interfaces-expected.txt:
+
+2016-01-27 Chris Dumez <[email protected]>
+
Getting / Setting property on prototype object must throw TypeError
https://bugs.webkit.org/show_bug.cgi?id=153547
<rdar://problem/24370650>
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt (195728 => 195729)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt 2016-01-28 05:21:57 UTC (rev 195728)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt 2016-01-28 05:33:22 UTC (rev 195729)
@@ -4172,37 +4172,37 @@
PASS BeforeUnloadEvent interface: existence and properties of interface prototype object
FAIL BeforeUnloadEvent interface: existence and properties of interface prototype object's "constructor" property assert_true: BeforeUnloadEvent.prototype.constructor is not writable expected true got false
FAIL BeforeUnloadEvent interface: attribute returnValue assert_equals: getter must be Function expected "function" but got "undefined"
-FAIL ApplicationCache interface: existence and properties of interface object assert_own_property: self does not have own property "ApplicationCache" expected property "ApplicationCache" missing
-FAIL ApplicationCache interface object length assert_own_property: self does not have own property "ApplicationCache" expected property "ApplicationCache" missing
-FAIL ApplicationCache interface object name assert_own_property: self does not have own property "ApplicationCache" expected property "ApplicationCache" missing
-FAIL ApplicationCache interface: existence and properties of interface prototype object assert_own_property: self does not have own property "ApplicationCache" expected property "ApplicationCache" missing
-FAIL ApplicationCache interface: existence and properties of interface prototype object's "constructor" property assert_own_property: self does not have own property "ApplicationCache" expected property "ApplicationCache" missing
-FAIL ApplicationCache interface: constant UNCACHED on interface object assert_own_property: self does not have own property "ApplicationCache" expected property "ApplicationCache" missing
-FAIL ApplicationCache interface: constant UNCACHED on interface prototype object assert_own_property: self does not have own property "ApplicationCache" expected property "ApplicationCache" missing
-FAIL ApplicationCache interface: constant IDLE on interface object assert_own_property: self does not have own property "ApplicationCache" expected property "ApplicationCache" missing
-FAIL ApplicationCache interface: constant IDLE on interface prototype object assert_own_property: self does not have own property "ApplicationCache" expected property "ApplicationCache" missing
-FAIL ApplicationCache interface: constant CHECKING on interface object assert_own_property: self does not have own property "ApplicationCache" expected property "ApplicationCache" missing
-FAIL ApplicationCache interface: constant CHECKING on interface prototype object assert_own_property: self does not have own property "ApplicationCache" expected property "ApplicationCache" missing
-FAIL ApplicationCache interface: constant DOWNLOADING on interface object assert_own_property: self does not have own property "ApplicationCache" expected property "ApplicationCache" missing
-FAIL ApplicationCache interface: constant DOWNLOADING on interface prototype object assert_own_property: self does not have own property "ApplicationCache" expected property "ApplicationCache" missing
-FAIL ApplicationCache interface: constant UPDATEREADY on interface object assert_own_property: self does not have own property "ApplicationCache" expected property "ApplicationCache" missing
-FAIL ApplicationCache interface: constant UPDATEREADY on interface prototype object assert_own_property: self does not have own property "ApplicationCache" expected property "ApplicationCache" missing
-FAIL ApplicationCache interface: constant OBSOLETE on interface object assert_own_property: self does not have own property "ApplicationCache" expected property "ApplicationCache" missing
-FAIL ApplicationCache interface: constant OBSOLETE on interface prototype object assert_own_property: self does not have own property "ApplicationCache" expected property "ApplicationCache" missing
-FAIL ApplicationCache interface: attribute status assert_own_property: self does not have own property "ApplicationCache" expected property "ApplicationCache" missing
-FAIL ApplicationCache interface: operation update() assert_own_property: self does not have own property "ApplicationCache" expected property "ApplicationCache" missing
-FAIL ApplicationCache interface: operation abort() assert_own_property: self does not have own property "ApplicationCache" expected property "ApplicationCache" missing
-FAIL ApplicationCache interface: operation swapCache() assert_own_property: self does not have own property "ApplicationCache" expected property "ApplicationCache" missing
-FAIL ApplicationCache interface: attribute onchecking assert_own_property: self does not have own property "ApplicationCache" expected property "ApplicationCache" missing
-FAIL ApplicationCache interface: attribute onerror assert_own_property: self does not have own property "ApplicationCache" expected property "ApplicationCache" missing
-FAIL ApplicationCache interface: attribute onnoupdate assert_own_property: self does not have own property "ApplicationCache" expected property "ApplicationCache" missing
-FAIL ApplicationCache interface: attribute ondownloading assert_own_property: self does not have own property "ApplicationCache" expected property "ApplicationCache" missing
-FAIL ApplicationCache interface: attribute onprogress assert_own_property: self does not have own property "ApplicationCache" expected property "ApplicationCache" missing
-FAIL ApplicationCache interface: attribute onupdateready assert_own_property: self does not have own property "ApplicationCache" expected property "ApplicationCache" missing
-FAIL ApplicationCache interface: attribute oncached assert_own_property: self does not have own property "ApplicationCache" expected property "ApplicationCache" missing
-FAIL ApplicationCache interface: attribute onobsolete assert_own_property: self does not have own property "ApplicationCache" expected property "ApplicationCache" missing
-FAIL ApplicationCache must be primary interface of window.applicationCache assert_own_property: self does not have own property "ApplicationCache" expected property "ApplicationCache" missing
-FAIL Stringification of window.applicationCache assert_equals: class string of window.applicationCache expected "[object ApplicationCache]" but got "[object DOMApplicationCache]"
+FAIL ApplicationCache interface: existence and properties of interface object assert_equals: class string of ApplicationCache expected "[object Function]" but got "[object ApplicationCacheConstructor]"
+PASS ApplicationCache interface object length
+PASS ApplicationCache interface object name
+FAIL ApplicationCache interface: existence and properties of interface prototype object assert_equals: prototype of ApplicationCache.prototype is not EventTarget.prototype expected object "[object EventTargetPrototype]" but got object "[object Object]"
+FAIL ApplicationCache interface: existence and properties of interface prototype object's "constructor" property assert_true: ApplicationCache.prototype.constructor is not writable expected true got false
+PASS ApplicationCache interface: constant UNCACHED on interface object
+PASS ApplicationCache interface: constant UNCACHED on interface prototype object
+PASS ApplicationCache interface: constant IDLE on interface object
+PASS ApplicationCache interface: constant IDLE on interface prototype object
+PASS ApplicationCache interface: constant CHECKING on interface object
+PASS ApplicationCache interface: constant CHECKING on interface prototype object
+PASS ApplicationCache interface: constant DOWNLOADING on interface object
+PASS ApplicationCache interface: constant DOWNLOADING on interface prototype object
+PASS ApplicationCache interface: constant UPDATEREADY on interface object
+PASS ApplicationCache interface: constant UPDATEREADY on interface prototype object
+PASS ApplicationCache interface: constant OBSOLETE on interface object
+PASS ApplicationCache interface: constant OBSOLETE on interface prototype object
+FAIL ApplicationCache interface: attribute status assert_equals: getter must be Function expected "function" but got "undefined"
+PASS ApplicationCache interface: operation update()
+PASS ApplicationCache interface: operation abort()
+PASS ApplicationCache interface: operation swapCache()
+FAIL ApplicationCache interface: attribute onchecking assert_equals: getter must be Function expected "function" but got "undefined"
+FAIL ApplicationCache interface: attribute onerror assert_equals: getter must be Function expected "function" but got "undefined"
+FAIL ApplicationCache interface: attribute onnoupdate assert_equals: getter must be Function expected "function" but got "undefined"
+FAIL ApplicationCache interface: attribute ondownloading assert_equals: getter must be Function expected "function" but got "undefined"
+FAIL ApplicationCache interface: attribute onprogress assert_equals: getter must be Function expected "function" but got "undefined"
+FAIL ApplicationCache interface: attribute onupdateready assert_equals: getter must be Function expected "function" but got "undefined"
+FAIL ApplicationCache interface: attribute oncached assert_equals: getter must be Function expected "function" but got "undefined"
+FAIL ApplicationCache interface: attribute onobsolete assert_equals: getter must be Function expected "function" but got "undefined"
+PASS ApplicationCache must be primary interface of window.applicationCache
+PASS Stringification of window.applicationCache
PASS ApplicationCache interface: window.applicationCache must inherit property "UNCACHED" with the proper type (0)
PASS ApplicationCache interface: window.applicationCache must inherit property "IDLE" with the proper type (1)
PASS ApplicationCache interface: window.applicationCache must inherit property "CHECKING" with the proper type (2)
Modified: trunk/LayoutTests/js/dom/global-constructors-attributes-expected.txt (195728 => 195729)
--- trunk/LayoutTests/js/dom/global-constructors-attributes-expected.txt 2016-01-28 05:21:57 UTC (rev 195728)
+++ trunk/LayoutTests/js/dom/global-constructors-attributes-expected.txt 2016-01-28 05:33:22 UTC (rev 195729)
@@ -13,6 +13,11 @@
PASS Object.getOwnPropertyDescriptor(global, 'AnimationEvent').hasOwnProperty('set') is false
PASS Object.getOwnPropertyDescriptor(global, 'AnimationEvent').enumerable is false
PASS Object.getOwnPropertyDescriptor(global, 'AnimationEvent').configurable is true
+PASS Object.getOwnPropertyDescriptor(global, 'ApplicationCache').value is ApplicationCache
+PASS Object.getOwnPropertyDescriptor(global, 'ApplicationCache').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'ApplicationCache').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'ApplicationCache').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'ApplicationCache').configurable is true
PASS Object.getOwnPropertyDescriptor(global, 'Attr').value is Attr
PASS Object.getOwnPropertyDescriptor(global, 'Attr').hasOwnProperty('get') is false
PASS Object.getOwnPropertyDescriptor(global, 'Attr').hasOwnProperty('set') is false
Modified: trunk/LayoutTests/platform/efl/js/dom/global-constructors-attributes-expected.txt (195728 => 195729)
--- trunk/LayoutTests/platform/efl/js/dom/global-constructors-attributes-expected.txt 2016-01-28 05:21:57 UTC (rev 195728)
+++ trunk/LayoutTests/platform/efl/js/dom/global-constructors-attributes-expected.txt 2016-01-28 05:33:22 UTC (rev 195729)
@@ -13,6 +13,11 @@
PASS Object.getOwnPropertyDescriptor(global, 'AnimationEvent').hasOwnProperty('set') is false
PASS Object.getOwnPropertyDescriptor(global, 'AnimationEvent').enumerable is false
PASS Object.getOwnPropertyDescriptor(global, 'AnimationEvent').configurable is true
+PASS Object.getOwnPropertyDescriptor(global, 'ApplicationCache').value is ApplicationCache
+PASS Object.getOwnPropertyDescriptor(global, 'ApplicationCache').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'ApplicationCache').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'ApplicationCache').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'ApplicationCache').configurable is true
PASS Object.getOwnPropertyDescriptor(global, 'Attr').value is Attr
PASS Object.getOwnPropertyDescriptor(global, 'Attr').hasOwnProperty('get') is false
PASS Object.getOwnPropertyDescriptor(global, 'Attr').hasOwnProperty('set') is false
Modified: trunk/LayoutTests/platform/gtk/js/dom/global-constructors-attributes-expected.txt (195728 => 195729)
--- trunk/LayoutTests/platform/gtk/js/dom/global-constructors-attributes-expected.txt 2016-01-28 05:21:57 UTC (rev 195728)
+++ trunk/LayoutTests/platform/gtk/js/dom/global-constructors-attributes-expected.txt 2016-01-28 05:33:22 UTC (rev 195729)
@@ -13,6 +13,11 @@
PASS Object.getOwnPropertyDescriptor(global, 'AnimationEvent').hasOwnProperty('set') is false
PASS Object.getOwnPropertyDescriptor(global, 'AnimationEvent').enumerable is false
PASS Object.getOwnPropertyDescriptor(global, 'AnimationEvent').configurable is true
+PASS Object.getOwnPropertyDescriptor(global, 'ApplicationCache').value is ApplicationCache
+PASS Object.getOwnPropertyDescriptor(global, 'ApplicationCache').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'ApplicationCache').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'ApplicationCache').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'ApplicationCache').configurable is true
PASS Object.getOwnPropertyDescriptor(global, 'Attr').value is Attr
PASS Object.getOwnPropertyDescriptor(global, 'Attr').hasOwnProperty('get') is false
PASS Object.getOwnPropertyDescriptor(global, 'Attr').hasOwnProperty('set') is false
Modified: trunk/LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt (195728 => 195729)
--- trunk/LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt 2016-01-28 05:21:57 UTC (rev 195728)
+++ trunk/LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt 2016-01-28 05:33:22 UTC (rev 195729)
@@ -13,6 +13,11 @@
PASS Object.getOwnPropertyDescriptor(global, 'AnimationEvent').hasOwnProperty('set') is false
PASS Object.getOwnPropertyDescriptor(global, 'AnimationEvent').enumerable is false
PASS Object.getOwnPropertyDescriptor(global, 'AnimationEvent').configurable is true
+PASS Object.getOwnPropertyDescriptor(global, 'ApplicationCache').value is ApplicationCache
+PASS Object.getOwnPropertyDescriptor(global, 'ApplicationCache').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'ApplicationCache').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'ApplicationCache').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'ApplicationCache').configurable is true
PASS Object.getOwnPropertyDescriptor(global, 'Attr').value is Attr
PASS Object.getOwnPropertyDescriptor(global, 'Attr').hasOwnProperty('get') is false
PASS Object.getOwnPropertyDescriptor(global, 'Attr').hasOwnProperty('set') is false
Modified: trunk/LayoutTests/platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt (195728 => 195729)
--- trunk/LayoutTests/platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt 2016-01-28 05:21:57 UTC (rev 195728)
+++ trunk/LayoutTests/platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt 2016-01-28 05:33:22 UTC (rev 195729)
@@ -13,6 +13,11 @@
PASS Object.getOwnPropertyDescriptor(global, 'AnimationEvent').hasOwnProperty('set') is false
PASS Object.getOwnPropertyDescriptor(global, 'AnimationEvent').enumerable is false
PASS Object.getOwnPropertyDescriptor(global, 'AnimationEvent').configurable is true
+PASS Object.getOwnPropertyDescriptor(global, 'ApplicationCache').value is ApplicationCache
+PASS Object.getOwnPropertyDescriptor(global, 'ApplicationCache').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'ApplicationCache').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'ApplicationCache').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'ApplicationCache').configurable is true
PASS Object.getOwnPropertyDescriptor(global, 'Attr').value is Attr
PASS Object.getOwnPropertyDescriptor(global, 'Attr').hasOwnProperty('get') is false
PASS Object.getOwnPropertyDescriptor(global, 'Attr').hasOwnProperty('set') is false
Modified: trunk/LayoutTests/platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt (195728 => 195729)
--- trunk/LayoutTests/platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt 2016-01-28 05:21:57 UTC (rev 195728)
+++ trunk/LayoutTests/platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt 2016-01-28 05:33:22 UTC (rev 195729)
@@ -13,6 +13,11 @@
PASS Object.getOwnPropertyDescriptor(global, 'AnimationEvent').hasOwnProperty('set') is false
PASS Object.getOwnPropertyDescriptor(global, 'AnimationEvent').enumerable is false
PASS Object.getOwnPropertyDescriptor(global, 'AnimationEvent').configurable is true
+PASS Object.getOwnPropertyDescriptor(global, 'ApplicationCache').value is ApplicationCache
+PASS Object.getOwnPropertyDescriptor(global, 'ApplicationCache').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'ApplicationCache').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'ApplicationCache').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'ApplicationCache').configurable is true
PASS Object.getOwnPropertyDescriptor(global, 'Attr').value is Attr
PASS Object.getOwnPropertyDescriptor(global, 'Attr').hasOwnProperty('get') is false
PASS Object.getOwnPropertyDescriptor(global, 'Attr').hasOwnProperty('set') is false
Modified: trunk/LayoutTests/platform/win/js/dom/global-constructors-attributes-expected.txt (195728 => 195729)
--- trunk/LayoutTests/platform/win/js/dom/global-constructors-attributes-expected.txt 2016-01-28 05:21:57 UTC (rev 195728)
+++ trunk/LayoutTests/platform/win/js/dom/global-constructors-attributes-expected.txt 2016-01-28 05:33:22 UTC (rev 195729)
@@ -8,6 +8,11 @@
PASS Object.getOwnPropertyDescriptor(global, 'AnimationEvent').hasOwnProperty('set') is false
PASS Object.getOwnPropertyDescriptor(global, 'AnimationEvent').enumerable is false
PASS Object.getOwnPropertyDescriptor(global, 'AnimationEvent').configurable is true
+PASS Object.getOwnPropertyDescriptor(global, 'ApplicationCache').value is ApplicationCache
+PASS Object.getOwnPropertyDescriptor(global, 'ApplicationCache').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'ApplicationCache').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'ApplicationCache').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'ApplicationCache').configurable is true
PASS Object.getOwnPropertyDescriptor(global, 'Attr').value is Attr
PASS Object.getOwnPropertyDescriptor(global, 'Attr').hasOwnProperty('get') is false
PASS Object.getOwnPropertyDescriptor(global, 'Attr').hasOwnProperty('set') is false
Modified: trunk/Source/WebCore/ChangeLog (195728 => 195729)
--- trunk/Source/WebCore/ChangeLog 2016-01-28 05:21:57 UTC (rev 195728)
+++ trunk/Source/WebCore/ChangeLog 2016-01-28 05:33:22 UTC (rev 195729)
@@ -1,3 +1,19 @@
+2016-01-27 Chris Dumez <[email protected]>
+
+ Expose ApplicationCache on the global Window object
+ https://bugs.webkit.org/show_bug.cgi?id=153578
+
+ Reviewed by Antti Koivisto.
+
+ Expose ApplicationCache on the global Window object as per:
+ https://html.spec.whatwg.org/#the-storage-interface
+
+ Chrome follows the spec.
+
+ No new tests, already covered by existing test.
+
+ * loader/appcache/DOMApplicationCache.idl:
+
2016-01-27 Ryosuke Niwa <[email protected]>
REGRESSION(r190430): Assertion failure in Text::~Text()
Modified: trunk/Source/WebCore/loader/appcache/DOMApplicationCache.idl (195728 => 195729)
--- trunk/Source/WebCore/loader/appcache/DOMApplicationCache.idl 2016-01-28 05:21:57 UTC (rev 195728)
+++ trunk/Source/WebCore/loader/appcache/DOMApplicationCache.idl 2016-01-28 05:33:22 UTC (rev 195729)
@@ -24,10 +24,10 @@
*/
[
- NoInterfaceObject,
EventTarget,
DoNotCheckConstants,
GenerateIsReachable=ImplFrame,
+ InterfaceName=ApplicationCache,
] interface DOMApplicationCache {
// update status
const unsigned short UNCACHED = 0;
