Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (195759 => 195760)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2016-01-28 18:41:46 UTC (rev 195759)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-01-28 18:55:07 UTC (rev 195760)
@@ -1,3 +1,14 @@
+2016-01-28 Chris Dumez <[email protected]>
+
+ Storage interface's attributes / operations should be enumerable
+ https://bugs.webkit.org/show_bug.cgi?id=153573
+
+ Reviewed by Darin Adler.
+
+ Rebaseline W3C HTML test now that more checks are passing.
+
+ * web-platform-tests/html/dom/interfaces-expected.txt:
+
2016-01-27 Chris Dumez <[email protected]>
Expose ValidityState on the global Window object
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt (195759 => 195760)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt 2016-01-28 18:41:46 UTC (rev 195759)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt 2016-01-28 18:55:07 UTC (rev 195760)
@@ -4543,11 +4543,11 @@
PASS Storage interface: existence and properties of interface prototype object
FAIL Storage interface: existence and properties of interface prototype object's "constructor" property assert_own_property: Storage.prototype does not have own property "constructor" expected property "constructor" missing
FAIL Storage interface: attribute length assert_true: The prototype object must have a property "length" expected true got false
-FAIL Storage interface: operation key(unsigned long) assert_true: property is not enumerable expected true got false
-FAIL Storage interface: operation getItem(DOMString) assert_true: property is not enumerable expected true got false
-FAIL Storage interface: operation setItem(DOMString,DOMString) assert_true: property is not enumerable expected true got false
-FAIL Storage interface: operation removeItem(DOMString) assert_true: property is not enumerable expected true got false
-FAIL Storage interface: operation clear() assert_true: property is not enumerable expected true got false
+PASS Storage interface: operation key(unsigned long)
+PASS Storage interface: operation getItem(DOMString)
+PASS Storage interface: operation setItem(DOMString,DOMString)
+PASS Storage interface: operation removeItem(DOMString)
+PASS Storage interface: operation clear()
FAIL StorageEvent interface: existence and properties of interface object assert_equals: class string of StorageEvent expected "[object Function]" but got "[object StorageEventConstructor]"
PASS StorageEvent interface object length
PASS StorageEvent interface object name
Modified: trunk/LayoutTests/storage/domstorage/localstorage/enumerate-storage-expected.txt (195759 => 195760)
--- trunk/LayoutTests/storage/domstorage/localstorage/enumerate-storage-expected.txt 2016-01-28 18:41:46 UTC (rev 195759)
+++ trunk/LayoutTests/storage/domstorage/localstorage/enumerate-storage-expected.txt 2016-01-28 18:55:07 UTC (rev 195760)
@@ -2,8 +2,14 @@
alpha
bar
batman
+clear
foo
fu
+getItem
+key
+length
prototypeTestKey
+removeItem
+setItem
zeta
Modified: trunk/LayoutTests/storage/domstorage/sessionstorage/enumerate-storage-expected.txt (195759 => 195760)
--- trunk/LayoutTests/storage/domstorage/sessionstorage/enumerate-storage-expected.txt 2016-01-28 18:41:46 UTC (rev 195759)
+++ trunk/LayoutTests/storage/domstorage/sessionstorage/enumerate-storage-expected.txt 2016-01-28 18:55:07 UTC (rev 195760)
@@ -2,8 +2,14 @@
alpha
bar
batman
+clear
foo
fu
+getItem
+key
+length
prototypeTestKey
+removeItem
+setItem
zeta
Modified: trunk/LayoutTests/storage/domstorage/sessionstorage/enumerate-with-length-and-key-expected.txt (195759 => 195760)
--- trunk/LayoutTests/storage/domstorage/sessionstorage/enumerate-with-length-and-key-expected.txt 2016-01-28 18:41:46 UTC (rev 195759)
+++ trunk/LayoutTests/storage/domstorage/sessionstorage/enumerate-with-length-and-key-expected.txt 2016-01-28 18:55:07 UTC (rev 195760)
@@ -2,8 +2,14 @@
alpha
bar
batman
+clear
foo
fu
+getItem
+key
+length
prototypeTestKey
+removeItem
+setItem
zeta
Modified: trunk/Source/WebCore/ChangeLog (195759 => 195760)
--- trunk/Source/WebCore/ChangeLog 2016-01-28 18:41:46 UTC (rev 195759)
+++ trunk/Source/WebCore/ChangeLog 2016-01-28 18:55:07 UTC (rev 195760)
@@ -1,3 +1,19 @@
+2016-01-28 Chris Dumez <[email protected]>
+
+ Storage interface's attributes / operations should be enumerable
+ https://bugs.webkit.org/show_bug.cgi?id=153573
+
+ Reviewed by Darin Adler.
+
+ Storage interface's attributes / operations should be enumerable:
+ - https://html.spec.whatwg.org/#the-storage-interface
+
+ Firefox matches the specification.
+
+ No new tests, already covered by existing test.
+
+ * storage/Storage.idl:
+
2016-01-26 Ada Chan <[email protected]>
Get WebVideoFullscreenManager and related classes to also compile for Mac platform
Modified: trunk/Source/WebCore/storage/Storage.idl (195759 => 195760)
--- trunk/Source/WebCore/storage/Storage.idl 2016-01-28 18:41:46 UTC (rev 195759)
+++ trunk/Source/WebCore/storage/Storage.idl 2016-01-28 18:55:07 UTC (rev 195760)
@@ -30,11 +30,11 @@
CustomNamedSetter,
SkipVTableValidation,
] interface Storage {
- [NotEnumerable, GetterRaisesException] readonly attribute unsigned long length;
- [NotEnumerable, TreatReturnedNullStringAs=Null, RaisesException] DOMString key(unsigned long index);
- [NotEnumerable, TreatReturnedNullStringAs=Null, RaisesException] getter DOMString getItem(DOMString key);
- [NotEnumerable, RaisesException] void setItem(DOMString key, DOMString data);
- [NotEnumerable, RaisesException] void removeItem(DOMString key);
- [NotEnumerable, RaisesException] void clear();
+ [GetterRaisesException] readonly attribute unsigned long length;
+ [TreatReturnedNullStringAs=Null, RaisesException] DOMString key(unsigned long index);
+ [TreatReturnedNullStringAs=Null, RaisesException] getter DOMString getItem(DOMString key);
+ [RaisesException] void setItem(DOMString key, DOMString data);
+ [RaisesException] void removeItem(DOMString key);
+ [RaisesException] void clear();
};
