Title: [195842] trunk/Source/WebInspectorUI
Revision
195842
Author
[email protected]
Date
2016-01-29 14:59:20 -0800 (Fri, 29 Jan 2016)

Log Message

Web Inspector: WebInspector.Setting should not access localStorage if the value did not change
https://bugs.webkit.org/show_bug.cgi?id=153671
<rdar://problem/24417029>

Patch by Joseph Pecoraro <[email protected]> on 2016-01-29
Reviewed by Brian Burg.

* UserInterface/Base/Setting.js:
(WebInspector.Setting.prototype.set value):

Modified Paths

Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (195841 => 195842)


--- trunk/Source/WebInspectorUI/ChangeLog	2016-01-29 22:50:48 UTC (rev 195841)
+++ trunk/Source/WebInspectorUI/ChangeLog	2016-01-29 22:59:20 UTC (rev 195842)
@@ -1,5 +1,16 @@
 2016-01-29  Joseph Pecoraro  <[email protected]>
 
+        Web Inspector: WebInspector.Setting should not access localStorage if the value did not change
+        https://bugs.webkit.org/show_bug.cgi?id=153671
+        <rdar://problem/24417029>
+
+        Reviewed by Brian Burg.
+
+        * UserInterface/Base/Setting.js:
+        (WebInspector.Setting.prototype.set value):
+
+2016-01-29  Joseph Pecoraro  <[email protected]>
+
         Web Inspector: Duplicate tab-types being saved to setting, causing duplicate tabs to be opened
         https://bugs.webkit.org/show_bug.cgi?id=153659
         <rdar://problem/24413157>

Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js (195841 => 195842)


--- trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js	2016-01-29 22:50:48 UTC (rev 195841)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js	2016-01-29 22:59:20 UTC (rev 195842)
@@ -71,6 +71,9 @@
 
     set value(value)
     {
+        if (this._value === value)
+            return;
+
         this._value = value;
 
         if (!window.InspectorTest && window.localStorage) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to