Title: [195863] trunk
- Revision
- 195863
- Author
- rn...@webkit.org
- Date
- 2016-01-29 16:06:48 -0800 (Fri, 29 Jan 2016)
Log Message
fast/shadow-dom/Element-interface-attachShadow.html fails on iOS
https://bugs.webkit.org/show_bug.cgi?id=153681
Reviewed by Antti Koivisto.
Source/WebCore:
The bug was caused by canHaveUserAgentShadowRoot() returning false on a meter element since it's disabled on iOS.
Override HTMLUnknownElement's canHaveUserAgentShadowRoot to return false for compatbility on iOS.
* html/HTMLUnknownElement.h:
(WebCore::HTMLUnknownElement::canHaveUserAgentShadowRoot):
LayoutTests:
Enable shadow DOM and custom elements tests on iOS; matches that's in platform/mac/TestExpectations.
* platform/ios-simulator/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (195862 => 195863)
--- trunk/LayoutTests/ChangeLog 2016-01-30 00:01:48 UTC (rev 195862)
+++ trunk/LayoutTests/ChangeLog 2016-01-30 00:06:48 UTC (rev 195863)
@@ -1,3 +1,14 @@
+2016-01-29 Ryosuke Niwa <rn...@webkit.org>
+
+ fast/shadow-dom/Element-interface-attachShadow.html fails on iOS
+ https://bugs.webkit.org/show_bug.cgi?id=153681
+
+ Reviewed by Antti Koivisto.
+
+ Enable shadow DOM and custom elements tests on iOS; matches that's in platform/mac/TestExpectations.
+
+ * platform/ios-simulator/TestExpectations:
+
2016-01-29 Ryan Haddad <ryanhad...@apple.com>
Missed one rebaseline for ios-simulator after r195740 in the last patch.
Modified: trunk/LayoutTests/platform/ios-simulator/TestExpectations (195862 => 195863)
--- trunk/LayoutTests/platform/ios-simulator/TestExpectations 2016-01-30 00:01:48 UTC (rev 195862)
+++ trunk/LayoutTests/platform/ios-simulator/TestExpectations 2016-01-30 00:06:48 UTC (rev 195863)
@@ -215,6 +215,13 @@
fast/loader/stateobjects/replacestate-frequency-with-user-gesture.html [ Skip ]
fast/loader/stateobjects/pushstate-frequency-with-user-gesture.html [ Skip ]
+webkit.org/b/148695 fast/shadow-dom [ Pass ]
+webkit.org/b/149440 fast/shadow-dom/css-scoping-shadow-host-functional-rule.html [ ImageOnlyFailure ]
+webkit.org/b/149441 fast/shadow-dom/css-scoping-shadow-slotted-rule.html [ ImageOnlyFailure ]
+webkit.org/b/149441 fast/shadow-dom/css-scoping-shadow-slot-display-override.html [ ImageOnlyFailure ]
+
+webkit.org/b/150225 fast/custom-elements [ Pass ]
+
###
# Known failures
##
Modified: trunk/Source/WebCore/ChangeLog (195862 => 195863)
--- trunk/Source/WebCore/ChangeLog 2016-01-30 00:01:48 UTC (rev 195862)
+++ trunk/Source/WebCore/ChangeLog 2016-01-30 00:06:48 UTC (rev 195863)
@@ -1,3 +1,16 @@
+2016-01-29 Ryosuke Niwa <rn...@webkit.org>
+
+ fast/shadow-dom/Element-interface-attachShadow.html fails on iOS
+ https://bugs.webkit.org/show_bug.cgi?id=153681
+
+ Reviewed by Antti Koivisto.
+
+ The bug was caused by canHaveUserAgentShadowRoot() returning false on a meter element since it's disabled on iOS.
+ Override HTMLUnknownElement's canHaveUserAgentShadowRoot to return false for compatbility on iOS.
+
+ * html/HTMLUnknownElement.h:
+ (WebCore::HTMLUnknownElement::canHaveUserAgentShadowRoot):
+
2016-01-29 Brady Eidson <beid...@apple.com>
Modern IDB: Getting records for key ranges with null keys aren't properly handled in SQLite backend
Modified: trunk/Source/WebCore/html/HTMLUnknownElement.h (195862 => 195863)
--- trunk/Source/WebCore/html/HTMLUnknownElement.h 2016-01-30 00:01:48 UTC (rev 195862)
+++ trunk/Source/WebCore/html/HTMLUnknownElement.h 2016-01-30 00:06:48 UTC (rev 195863)
@@ -47,6 +47,12 @@
{
}
+#if ENABLE(METER_ELEMENT)
+ virtual bool canHaveUserAgentShadowRoot() const override final { return false; }
+#else
+ virtual bool canHaveUserAgentShadowRoot() const override final { return localName() == "meter"; }
+#endif
+
virtual bool isHTMLUnknownElement() const override { return true; }
};
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
