[webkit-changes] [195901] trunk/Source

Sat, 30 Jan 2016 11:31:45 -0800

Title: [195901] trunk/Source
Revision
195901
Author
[email protected]
Date
2016-01-30 11:30:49 -0800 (Sat, 30 Jan 2016)

Log Message

Enable VIDEO_PRESENTATION_MODE only in Debug and Release builds on Mac
https://bugs.webkit.org/show_bug.cgi?id=153665

Reviewed by Dan Bernstein.

Source/_javascript_Core:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

Source/WTF:

* wtf/Platform.h:
Remove this as the flag is already defined in FeatureDefines.xcconfig files.

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (195900 => 195901)


--- trunk/Source/_javascript_Core/ChangeLog	2016-01-30 19:22:58 UTC (rev 195900)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-01-30 19:30:49 UTC (rev 195901)
@@ -1,3 +1,12 @@
+2016-01-29  Ada Chan  <[email protected]>
+
+        Enable VIDEO_PRESENTATION_MODE only in Debug and Release builds on Mac
+        https://bugs.webkit.org/show_bug.cgi?id=153665
+
+        Reviewed by Dan Bernstein.
+
+        * Configurations/FeatureDefines.xcconfig:
+
 2016-01-30  Yusuke Suzuki  <[email protected]>
 
         [B3] REGRESSION(r195882): Should break early after modConstant replaceWithNewValue succeeds

Modified: trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig (195900 => 195901)


--- trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig	2016-01-30 19:22:58 UTC (rev 195900)
+++ trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig	2016-01-30 19:30:49 UTC (rev 195901)
@@ -169,10 +169,9 @@
 ENABLE_USERSELECT_ALL = ENABLE_USERSELECT_ALL;
 ENABLE_VIDEO = ENABLE_VIDEO;
 ENABLE_VIDEO_PRESENTATION_MODE[sdk=iphone*] = ENABLE_VIDEO_PRESENTATION_MODE;
-ENABLE_VIDEO_PRESENTATION_MODE[sdk=macosx*] = $(ENABLE_VIDEO_PRESENTATION_MODE_macosx_$(TARGET_MAC_OS_X_VERSION_MAJOR))
-ENABLE_VIDEO_PRESENTATION_MODE_macosx_101000 = ;
-ENABLE_VIDEO_PRESENTATION_MODE_macosx_101100 = ;
-ENABLE_VIDEO_PRESENTATION_MODE_macosx_101200 = ENABLE_VIDEO_PRESENTATION_MODE;
+ENABLE_VIDEO_PRESENTATION_MODE[sdk=macosx*] = $(ENABLE_VIDEO_PRESENTATION_MODE_macosx_$(TARGET_MAC_OS_X_VERSION_MAJOR)_$(CONFIGURATION))
+ENABLE_VIDEO_PRESENTATION_MODE_macosx_101200_Debug = ENABLE_VIDEO_PRESENTATION_MODE;
+ENABLE_VIDEO_PRESENTATION_MODE_macosx_101200_Release = $(ENABLE_VIDEO_PRESENTATION_MODE_macosx_101200_Debug);
 ENABLE_VIDEO_TRACK = ENABLE_VIDEO_TRACK;
 ENABLE_DATACUE_VALUE = ENABLE_DATACUE_VALUE;
 ENABLE_VIEW_MODE_CSS_MEDIA = ;

Modified: trunk/Source/WTF/ChangeLog (195900 => 195901)


--- trunk/Source/WTF/ChangeLog	2016-01-30 19:22:58 UTC (rev 195900)
+++ trunk/Source/WTF/ChangeLog	2016-01-30 19:30:49 UTC (rev 195901)
@@ -1,3 +1,13 @@
+2016-01-29  Ada Chan  <[email protected]>
+
+        Enable VIDEO_PRESENTATION_MODE only in Debug and Release builds on Mac
+        https://bugs.webkit.org/show_bug.cgi?id=153665
+
+        Reviewed by Dan Bernstein.
+
+        * wtf/Platform.h:
+        Remove this as the flag is already defined in FeatureDefines.xcconfig files.
+
 2016-01-30  Yusuke Suzuki  <[email protected]>
 
         Enable SamplingProfiler on POSIX environment

Modified: trunk/Source/WTF/wtf/Platform.h (195900 => 195901)


--- trunk/Source/WTF/wtf/Platform.h	2016-01-30 19:22:58 UTC (rev 195900)
+++ trunk/Source/WTF/wtf/Platform.h	2016-01-30 19:30:49 UTC (rev 195901)
@@ -1144,10 +1144,6 @@
 #define USE_MEDIATOOLBOX 1
 #endif
 
-#if PLATFORM(IOS) || (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101200)
-#define ENABLE_VIDEO_PRESENTATION_MODE 1
-#endif
-
 /* While 10.10 has support for fences, it is missing some API important for our integration of them. */
 #if PLATFORM(IOS) || (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101100)
 #define HAVE_COREANIMATION_FENCES 1

Modified: trunk/Source/WebCore/ChangeLog (195900 => 195901)


--- trunk/Source/WebCore/ChangeLog	2016-01-30 19:22:58 UTC (rev 195900)
+++ trunk/Source/WebCore/ChangeLog	2016-01-30 19:30:49 UTC (rev 195901)
@@ -1,3 +1,12 @@
+2016-01-29  Ada Chan  <[email protected]>
+
+        Enable VIDEO_PRESENTATION_MODE only in Debug and Release builds on Mac
+        https://bugs.webkit.org/show_bug.cgi?id=153665
+
+        Reviewed by Dan Bernstein.
+
+        * Configurations/FeatureDefines.xcconfig:
+
 2016-01-30  David Kilzer  <[email protected]>
 
         [iOS] WebKit1 apps crash in ___ZN7WebCore16DiskCacheMonitorC2ERKNS_15ResourceRequestENS_9SessionIDEPK20_CFCachedURLResponse_block_invoke1

Modified: trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig (195900 => 195901)


--- trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig	2016-01-30 19:22:58 UTC (rev 195900)
+++ trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig	2016-01-30 19:30:49 UTC (rev 195901)
@@ -169,10 +169,9 @@
 ENABLE_USERSELECT_ALL = ENABLE_USERSELECT_ALL;
 ENABLE_VIDEO = ENABLE_VIDEO;
 ENABLE_VIDEO_PRESENTATION_MODE[sdk=iphone*] = ENABLE_VIDEO_PRESENTATION_MODE;
-ENABLE_VIDEO_PRESENTATION_MODE[sdk=macosx*] = $(ENABLE_VIDEO_PRESENTATION_MODE_macosx_$(TARGET_MAC_OS_X_VERSION_MAJOR))
-ENABLE_VIDEO_PRESENTATION_MODE_macosx_101000 = ;
-ENABLE_VIDEO_PRESENTATION_MODE_macosx_101100 = ;
-ENABLE_VIDEO_PRESENTATION_MODE_macosx_101200 = ENABLE_VIDEO_PRESENTATION_MODE;
+ENABLE_VIDEO_PRESENTATION_MODE[sdk=macosx*] = $(ENABLE_VIDEO_PRESENTATION_MODE_macosx_$(TARGET_MAC_OS_X_VERSION_MAJOR)_$(CONFIGURATION))
+ENABLE_VIDEO_PRESENTATION_MODE_macosx_101200_Debug = ENABLE_VIDEO_PRESENTATION_MODE;
+ENABLE_VIDEO_PRESENTATION_MODE_macosx_101200_Release = $(ENABLE_VIDEO_PRESENTATION_MODE_macosx_101200_Debug);
 ENABLE_VIDEO_TRACK = ENABLE_VIDEO_TRACK;
 ENABLE_DATACUE_VALUE = ENABLE_DATACUE_VALUE;
 ENABLE_VIEW_MODE_CSS_MEDIA = ;

Modified: trunk/Source/WebKit/mac/ChangeLog (195900 => 195901)


--- trunk/Source/WebKit/mac/ChangeLog	2016-01-30 19:22:58 UTC (rev 195900)
+++ trunk/Source/WebKit/mac/ChangeLog	2016-01-30 19:30:49 UTC (rev 195901)
@@ -1,3 +1,12 @@
+2016-01-29  Ada Chan  <[email protected]>
+
+        Enable VIDEO_PRESENTATION_MODE only in Debug and Release builds on Mac
+        https://bugs.webkit.org/show_bug.cgi?id=153665
+
+        Reviewed by Dan Bernstein.
+
+        * Configurations/FeatureDefines.xcconfig:
+
 2016-01-28  Darin Adler  <[email protected]>
 
         Remove equalIgnoringCase since all callers really wanted equalIgnoringASCIICase

Modified: trunk/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig (195900 => 195901)


--- trunk/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig	2016-01-30 19:22:58 UTC (rev 195900)
+++ trunk/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig	2016-01-30 19:30:49 UTC (rev 195901)
@@ -169,10 +169,9 @@
 ENABLE_USERSELECT_ALL = ENABLE_USERSELECT_ALL;
 ENABLE_VIDEO = ENABLE_VIDEO;
 ENABLE_VIDEO_PRESENTATION_MODE[sdk=iphone*] = ENABLE_VIDEO_PRESENTATION_MODE;
-ENABLE_VIDEO_PRESENTATION_MODE[sdk=macosx*] = $(ENABLE_VIDEO_PRESENTATION_MODE_macosx_$(TARGET_MAC_OS_X_VERSION_MAJOR))
-ENABLE_VIDEO_PRESENTATION_MODE_macosx_101000 = ;
-ENABLE_VIDEO_PRESENTATION_MODE_macosx_101100 = ;
-ENABLE_VIDEO_PRESENTATION_MODE_macosx_101200 = ENABLE_VIDEO_PRESENTATION_MODE;
+ENABLE_VIDEO_PRESENTATION_MODE[sdk=macosx*] = $(ENABLE_VIDEO_PRESENTATION_MODE_macosx_$(TARGET_MAC_OS_X_VERSION_MAJOR)_$(CONFIGURATION))
+ENABLE_VIDEO_PRESENTATION_MODE_macosx_101200_Debug = ENABLE_VIDEO_PRESENTATION_MODE;
+ENABLE_VIDEO_PRESENTATION_MODE_macosx_101200_Release = $(ENABLE_VIDEO_PRESENTATION_MODE_macosx_101200_Debug);
 ENABLE_VIDEO_TRACK = ENABLE_VIDEO_TRACK;
 ENABLE_DATACUE_VALUE = ENABLE_DATACUE_VALUE;
 ENABLE_VIEW_MODE_CSS_MEDIA = ;

Modified: trunk/Source/WebKit2/ChangeLog (195900 => 195901)


--- trunk/Source/WebKit2/ChangeLog	2016-01-30 19:22:58 UTC (rev 195900)
+++ trunk/Source/WebKit2/ChangeLog	2016-01-30 19:30:49 UTC (rev 195901)
@@ -1,3 +1,12 @@
+2016-01-29  Ada Chan  <[email protected]>
+
+        Enable VIDEO_PRESENTATION_MODE only in Debug and Release builds on Mac
+        https://bugs.webkit.org/show_bug.cgi?id=153665
+
+        Reviewed by Dan Bernstein.
+
+        * Configurations/FeatureDefines.xcconfig:
+
 2016-01-29  Dan Bernstein  <[email protected]>
 
         Don’t use the “.Development” suffix for engineering builds targeting iOS devices, because the XPC cache is only aware of the unsuffixed service identifiers.

Modified: trunk/Source/WebKit2/Configurations/FeatureDefines.xcconfig (195900 => 195901)


--- trunk/Source/WebKit2/Configurations/FeatureDefines.xcconfig	2016-01-30 19:22:58 UTC (rev 195900)
+++ trunk/Source/WebKit2/Configurations/FeatureDefines.xcconfig	2016-01-30 19:30:49 UTC (rev 195901)
@@ -169,10 +169,9 @@
 ENABLE_USERSELECT_ALL = ENABLE_USERSELECT_ALL;
 ENABLE_VIDEO = ENABLE_VIDEO;
 ENABLE_VIDEO_PRESENTATION_MODE[sdk=iphone*] = ENABLE_VIDEO_PRESENTATION_MODE;
-ENABLE_VIDEO_PRESENTATION_MODE[sdk=macosx*] = $(ENABLE_VIDEO_PRESENTATION_MODE_macosx_$(TARGET_MAC_OS_X_VERSION_MAJOR))
-ENABLE_VIDEO_PRESENTATION_MODE_macosx_101000 = ;
-ENABLE_VIDEO_PRESENTATION_MODE_macosx_101100 = ;
-ENABLE_VIDEO_PRESENTATION_MODE_macosx_101200 = ENABLE_VIDEO_PRESENTATION_MODE;
+ENABLE_VIDEO_PRESENTATION_MODE[sdk=macosx*] = $(ENABLE_VIDEO_PRESENTATION_MODE_macosx_$(TARGET_MAC_OS_X_VERSION_MAJOR)_$(CONFIGURATION))
+ENABLE_VIDEO_PRESENTATION_MODE_macosx_101200_Debug = ENABLE_VIDEO_PRESENTATION_MODE;
+ENABLE_VIDEO_PRESENTATION_MODE_macosx_101200_Release = $(ENABLE_VIDEO_PRESENTATION_MODE_macosx_101200_Debug);
 ENABLE_VIDEO_TRACK = ENABLE_VIDEO_TRACK;
 ENABLE_DATACUE_VALUE = ENABLE_DATACUE_VALUE;
 ENABLE_VIEW_MODE_CSS_MEDIA = ;

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to