Title: [196007] trunk/Tools
- Revision
- 196007
- Author
- [email protected]
- Date
- 2016-02-02 04:26:38 -0800 (Tue, 02 Feb 2016)
Log Message
[EFL] Virtual Keyboard overlaps MiniBrowser's WebView
https://bugs.webkit.org/show_bug.cgi?id=153009
Reviewed by Gyuyoung Kim.
On mobile, virtual keyboard represented by ecore_imf module appears on
the top of application layer usually covering bottom part of the screen.
If the web page contains the editable content on the bottom of the page
it will be overlapped by keyboard which prevents user from seeing the
typed text.
Pack MiniBrowser layout into conformant widget to allow EFL to guess
the space that will be required by the keyboard, finally resizing it
to the desired size. As a result, webview gets resized and scrolled
into focused elements which makes the editable elements visible while
typing.
More details about elm_conformant widger can be found at:
https://docs.enlightenment.org/elementary/1.15.0/group__Conformant.html
https://docs.enlightenment.org/elementary/1.15.0/conformant_example.html
* MiniBrowser/efl/main.c:
(window_create): pack a box into conformant widget.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (196006 => 196007)
--- trunk/Tools/ChangeLog 2016-02-02 11:35:33 UTC (rev 196006)
+++ trunk/Tools/ChangeLog 2016-02-02 12:26:38 UTC (rev 196007)
@@ -1,3 +1,29 @@
+2016-01-29 Grzegorz Czajkowski <[email protected]>
+
+ [EFL] Virtual Keyboard overlaps MiniBrowser's WebView
+ https://bugs.webkit.org/show_bug.cgi?id=153009
+
+ Reviewed by Gyuyoung Kim.
+
+ On mobile, virtual keyboard represented by ecore_imf module appears on
+ the top of application layer usually covering bottom part of the screen.
+ If the web page contains the editable content on the bottom of the page
+ it will be overlapped by keyboard which prevents user from seeing the
+ typed text.
+
+ Pack MiniBrowser layout into conformant widget to allow EFL to guess
+ the space that will be required by the keyboard, finally resizing it
+ to the desired size. As a result, webview gets resized and scrolled
+ into focused elements which makes the editable elements visible while
+ typing.
+
+ More details about elm_conformant widger can be found at:
+ https://docs.enlightenment.org/elementary/1.15.0/group__Conformant.html
+ https://docs.enlightenment.org/elementary/1.15.0/conformant_example.html
+
+ * MiniBrowser/efl/main.c:
+ (window_create): pack a box into conformant widget.
+
2016-02-02 Alejandro G. Castro <[email protected]>
[GTK][EFL] Upgrade OpenWebRTC dependency
Modified: trunk/Tools/MiniBrowser/efl/main.c (196006 => 196007)
--- trunk/Tools/MiniBrowser/efl/main.c 2016-02-02 11:35:33 UTC (rev 196006)
+++ trunk/Tools/MiniBrowser/efl/main.c 2016-02-02 12:26:38 UTC (rev 196007)
@@ -2088,11 +2088,17 @@
elm_win_resize_object_add(window->elm_window, bg);
evas_object_show(bg);
+ /* Create conformant widget. */
+ Evas_Object *conformant = elm_conformant_add(window->elm_window);
+ evas_object_size_hint_weight_set(conformant, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
+ elm_win_resize_object_add(window->elm_window, conformant);
+ evas_object_show(conformant);
+
/* Create vertical layout */
window->vertical_layout = elm_box_add(window->elm_window);
+ elm_object_content_set(conformant, window->vertical_layout);
elm_box_padding_set(window->vertical_layout, 0, 2);
evas_object_size_hint_weight_set(window->vertical_layout, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
- elm_win_resize_object_add(window->elm_window, window->vertical_layout);
evas_object_show(window->vertical_layout);
/* Create horizontal layout for top bar */
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes