Title: [196188] trunk/Source/_javascript_Core
- Revision
- 196188
- Author
- sbar...@apple.com
- Date
- 2016-02-05 13:41:24 -0800 (Fri, 05 Feb 2016)
Log Message
follow-up to: JSC Sampling Profiler: (host) is confusing in cases where I would expect to see JS name
https://bugs.webkit.org/show_bug.cgi?id=153663
<rdar://problem/24415092>
Rubber stamped by Joseph Pecoraro.
We were performing operations that required us to
hold the VM lock even when we might not have been holding it.
We now ensure we're holding it.
* inspector/agents/InspectorScriptProfilerAgent.cpp:
(Inspector::InspectorScriptProfilerAgent::trackingComplete):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (196187 => 196188)
--- trunk/Source/_javascript_Core/ChangeLog 2016-02-05 21:38:44 UTC (rev 196187)
+++ trunk/Source/_javascript_Core/ChangeLog 2016-02-05 21:41:24 UTC (rev 196188)
@@ -1,3 +1,18 @@
+2016-02-05 Saam barati <sbar...@apple.com>
+
+ follow-up to: JSC Sampling Profiler: (host) is confusing in cases where I would expect to see JS name
+ https://bugs.webkit.org/show_bug.cgi?id=153663
+ <rdar://problem/24415092>
+
+ Rubber stamped by Joseph Pecoraro.
+
+ We were performing operations that required us to
+ hold the VM lock even when we might not have been holding it.
+ We now ensure we're holding it.
+
+ * inspector/agents/InspectorScriptProfilerAgent.cpp:
+ (Inspector::InspectorScriptProfilerAgent::trackingComplete):
+
2016-02-05 Filip Pizlo <fpi...@apple.com>
Arrayify for a typed array shouldn't create a monster
Modified: trunk/Source/_javascript_Core/inspector/agents/InspectorScriptProfilerAgent.cpp (196187 => 196188)
--- trunk/Source/_javascript_Core/inspector/agents/InspectorScriptProfilerAgent.cpp 2016-02-05 21:38:44 UTC (rev 196187)
+++ trunk/Source/_javascript_Core/inspector/agents/InspectorScriptProfilerAgent.cpp 2016-02-05 21:41:24 UTC (rev 196188)
@@ -190,6 +190,7 @@
{
#if ENABLE(SAMPLING_PROFILER)
if (m_enabledSamplingProfiler) {
+ JSLockHolder lock(m_environment.scriptDebugServer().vm());
SamplingProfiler* samplingProfiler = m_environment.scriptDebugServer().vm().samplingProfiler();
RELEASE_ASSERT(samplingProfiler);
LockHolder locker(samplingProfiler->getLock());
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
