Title: [196512] trunk/Source/WebInspectorUI
Revision
196512
Author
[email protected]
Date
2016-02-12 14:31:08 -0800 (Fri, 12 Feb 2016)

Log Message

Web Inspector: Avoid including ESLint until it is used
https://bugs.webkit.org/show_bug.cgi?id=154196

Patch by Joseph Pecoraro <[email protected]> on 2016-02-12
Reviewed by Timothy Hatcher.

* Scripts/copy-user-interface-resources.pl:
Do not include ESLint in optimized output yet.

* UserInterface/Controllers/AnalyzerManager.js:
Do not reference `eslint` until we use it.

* UserInterface/Main.html:
Remove include to ESLint until we need it.

Modified Paths

Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (196511 => 196512)


--- trunk/Source/WebInspectorUI/ChangeLog	2016-02-12 22:30:37 UTC (rev 196511)
+++ trunk/Source/WebInspectorUI/ChangeLog	2016-02-12 22:31:08 UTC (rev 196512)
@@ -1,5 +1,21 @@
 2016-02-12  Joseph Pecoraro  <[email protected]>
 
+        Web Inspector: Avoid including ESLint until it is used
+        https://bugs.webkit.org/show_bug.cgi?id=154196
+
+        Reviewed by Timothy Hatcher.
+
+        * Scripts/copy-user-interface-resources.pl:
+        Do not include ESLint in optimized output yet.
+
+        * UserInterface/Controllers/AnalyzerManager.js:
+        Do not reference `eslint` until we use it.
+
+        * UserInterface/Main.html:
+        Remove include to ESLint until we need it.
+
+2016-02-12  Joseph Pecoraro  <[email protected]>
+
         Web Inspector: Tabs: Conflicts with multiple Formatters per SourceCode
         https://bugs.webkit.org/show_bug.cgi?id=144717
         <rdar://problem/20845163>

Modified: trunk/Source/WebInspectorUI/Scripts/copy-user-interface-resources.pl (196511 => 196512)


--- trunk/Source/WebInspectorUI/Scripts/copy-user-interface-resources.pl	2016-02-12 22:30:37 UTC (rev 196511)
+++ trunk/Source/WebInspectorUI/Scripts/copy-user-interface-resources.pl	2016-02-12 22:31:08 UTC (rev 196512)
@@ -235,6 +235,9 @@
     # Remove Images/gtk on Mac and Windows builds.
     remove_tree(File::Spec->catdir($targetResourcePath, 'Images', 'gtk')) if defined $ENV{'MAC_OS_X_VERSION_MAJOR'} or defined $ENV{'OFFICIAL_BUILD'};
 
+    # Remove ESLint until needed: <https://webkit.org/b/136515> Web Inspector: _javascript_ source text editor should have a linter
+    unlink $targetESLintJS;
+
     # Copy the Legacy directory.
     ditto(File::Spec->catfile($uiRoot, 'Protocol', 'Legacy'), File::Spec->catfile($protocolDir, 'Legacy'));
 } else {

Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/AnalyzerManager.js (196511 => 196512)


--- trunk/Source/WebInspectorUI/UserInterface/Controllers/AnalyzerManager.js	2016-02-12 22:30:37 UTC (rev 196511)
+++ trunk/Source/WebInspectorUI/UserInterface/Controllers/AnalyzerManager.js	2016-02-12 22:31:08 UTC (rev 196512)
@@ -117,4 +117,6 @@
 };
 
 WebInspector.AnalyzerManager._typeAnalyzerMap = new Map;
-WebInspector.AnalyzerManager._typeAnalyzerMap.set(WebInspector.Resource.Type.Script, eslint);
+
+// <https://webkit.org/b/136515> Web Inspector: _javascript_ source text editor should have a linter
+// WebInspector.AnalyzerManager._typeAnalyzerMap.set(WebInspector.Resource.Type.Script, eslint);

Modified: trunk/Source/WebInspectorUI/UserInterface/Main.html (196511 => 196512)


--- trunk/Source/WebInspectorUI/UserInterface/Main.html	2016-02-12 22:30:37 UTC (rev 196511)
+++ trunk/Source/WebInspectorUI/UserInterface/Main.html	2016-02-12 22:31:08 UTC (rev 196512)
@@ -215,7 +215,6 @@
     <script src=""
 
     <script src=""
-    <script src=""
 
     <script src=""
     <script src=""
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to