Title: [196531] trunk/Source/WebKit/mac
- Revision
- 196531
- Author
- [email protected]
- Date
- 2016-02-12 16:36:19 -0800 (Fri, 12 Feb 2016)
Log Message
Unreviewed, rolling out r196527.
https://bugs.webkit.org/show_bug.cgi?id=154204
"Need to redo as WebCoreThreadViolationCheckRoundThree"
(Requested by mlam on #webkit).
Reverted changeset:
"Add thread violation checks to WebView public APIs."
https://bugs.webkit.org/show_bug.cgi?id=154183
http://trac.webkit.org/changeset/196527
Modified Paths
Diff
Modified: trunk/Source/WebKit/mac/ChangeLog (196530 => 196531)
--- trunk/Source/WebKit/mac/ChangeLog 2016-02-13 00:32:50 UTC (rev 196530)
+++ trunk/Source/WebKit/mac/ChangeLog 2016-02-13 00:36:19 UTC (rev 196531)
@@ -1,3 +1,17 @@
+2016-02-12 Commit Queue <[email protected]>
+
+ Unreviewed, rolling out r196527.
+ https://bugs.webkit.org/show_bug.cgi?id=154204
+
+ "Need to redo as WebCoreThreadViolationCheckRoundThree"
+ (Requested by mlam on #webkit).
+
+ Reverted changeset:
+
+ "Add thread violation checks to WebView public APIs."
+ https://bugs.webkit.org/show_bug.cgi?id=154183
+ http://trac.webkit.org/changeset/196527
+
2016-02-12 Mark Lam <[email protected]>
Add thread violation checks to WebView public APIs.
Modified: trunk/Source/WebKit/mac/WebView/WebView.mm (196530 => 196531)
--- trunk/Source/WebKit/mac/WebView/WebView.mm 2016-02-13 00:32:50 UTC (rev 196530)
+++ trunk/Source/WebKit/mac/WebView/WebView.mm 2016-02-13 00:36:19 UTC (rev 196531)
@@ -5843,8 +5843,6 @@
- (void)setCustomTextEncodingName:(NSString *)encoding
{
- WebCoreThreadViolationCheckRoundTwo();
-
NSString *oldEncoding = [self customTextEncodingName];
if (encoding == oldEncoding || [encoding isEqualToString:oldEncoding])
return;
@@ -5869,8 +5867,6 @@
- (NSString *)stringByEvaluatingJavaScriptFromString:(NSString *)script
{
- WebCoreThreadViolationCheckRoundTwo();
-
#if !PLATFORM(IOS)
// Return statements are only valid in a function but some applications pass in scripts
// prefixed with return (<rdar://problems/5103720&4616860>) since older WebKit versions
@@ -5893,8 +5889,6 @@
- (WebScriptObject *)windowScriptObject
{
- WebCoreThreadViolationCheckRoundTwo();
-
Frame* coreFrame = [self _mainCoreFrame];
if (!coreFrame)
return nil;
@@ -6160,8 +6154,6 @@
- (void)setGroupName:(NSString *)groupName
{
- WebCoreThreadViolationCheckRoundTwo();
-
if (_private->group)
_private->group->removeWebView(self);
@@ -6252,8 +6244,6 @@
- (void)setMainFrameURL:(NSString *)URLString
{
- WebCoreThreadViolationCheckRoundTwo();
-
NSURL *url;
if ([URLString hasPrefix:@"/"])
url = "" fileURLWithPath:URLString];
@@ -6280,8 +6270,6 @@
- (NSString *)mainFrameTitle
{
- WebCoreThreadViolationCheckRoundTwo();
-
NSString *mainFrameTitle = [[[self mainFrame] _dataSource] pageTitle];
return (mainFrameTitle != nil) ? mainFrameTitle : (NSString *)@"";
}
@@ -6289,8 +6277,6 @@
#if !PLATFORM(IOS)
- (NSImage *)mainFrameIcon
{
- WebCoreThreadViolationCheckRoundTwo();
-
return [[WebIconDatabase sharedIconDatabase] iconForURL:[[[[self mainFrame] _dataSource] _URL] _web_originalDataAsString] withSize:WebIconSmallSize];
}
#else
@@ -6317,8 +6303,6 @@
- (void)setDrawsBackground:(BOOL)drawsBackground
{
- WebCoreThreadViolationCheckRoundTwo();
-
if (_private->drawsBackground == drawsBackground)
return;
_private->drawsBackground = drawsBackground;
@@ -6334,8 +6318,6 @@
- (void)setShouldUpdateWhileOffscreen:(BOOL)updateWhileOffscreen
{
- WebCoreThreadViolationCheckRoundTwo();
-
if (_private->shouldUpdateWhileOffscreen == updateWhileOffscreen)
return;
_private->shouldUpdateWhileOffscreen = updateWhileOffscreen;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
