Title: [196741] trunk/Source/WebInspectorUI
- Revision
- 196741
- Author
- [email protected]
- Date
- 2016-02-17 21:27:31 -0800 (Wed, 17 Feb 2016)
Log Message
REGRESSION (r196620): Web Inspector: When the scrollbars are always visible, the console prompt is 1px taller
https://bugs.webkit.org/show_bug.cgi?id=154328
<rdar://problem/24692996>
Introduce a CSS variable to ensure that the quick console is the
same height as the bottom right section of the styles sidebar.
Reviewed by Timothy Hatcher.
* UserInterface/Views/CSSStyleDetailsSidebarPanel.css:
(.sidebar > .panel.details.css-style > .content ~ .options-container):
(.sidebar > .panel.details.css-style > .content ~ .class-list-container):
* UserInterface/Views/QuickConsole.css:
(.quick-console):
* UserInterface/Views/Variables.css:
(:root):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (196740 => 196741)
--- trunk/Source/WebInspectorUI/ChangeLog 2016-02-18 05:16:54 UTC (rev 196740)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-02-18 05:27:31 UTC (rev 196741)
@@ -1,3 +1,22 @@
+2016-02-17 Nikita Vasilyev <[email protected]>
+
+ REGRESSION (r196620): Web Inspector: When the scrollbars are always visible, the console prompt is 1px taller
+ https://bugs.webkit.org/show_bug.cgi?id=154328
+ <rdar://problem/24692996>
+
+ Introduce a CSS variable to ensure that the quick console is the
+ same height as the bottom right section of the styles sidebar.
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/CSSStyleDetailsSidebarPanel.css:
+ (.sidebar > .panel.details.css-style > .content ~ .options-container):
+ (.sidebar > .panel.details.css-style > .content ~ .class-list-container):
+ * UserInterface/Views/QuickConsole.css:
+ (.quick-console):
+ * UserInterface/Views/Variables.css:
+ (:root):
+
2016-02-17 Devin Rousso <[email protected]>
Web Inspector: Add Context menu separators to Styles sidebar
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.css (196740 => 196741)
--- trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.css 2016-02-18 05:16:54 UTC (rev 196740)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.css 2016-02-18 05:27:31 UTC (rev 196741)
@@ -76,7 +76,7 @@
.sidebar > .panel.details.css-style > .content ~ .options-container {
bottom: 0;
- height: 29px;
+ height: var(--console-prompt-min-height);
}
.sidebar > .panel.details.css-style > .content:not(.supports-new-rule, .has-filter-bar) ~ :matches(.options-container, .class-list-container) {
@@ -123,7 +123,7 @@
.sidebar > .panel.details.css-style > .content ~ .class-list-container {
flex-wrap: wrap;
- bottom: 29px;
+ bottom: var(--console-prompt-min-height);
max-height: 65px;
padding: 3px 2px;
overflow-y: scroll;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/QuickConsole.css (196740 => 196741)
--- trunk/Source/WebInspectorUI/UserInterface/Views/QuickConsole.css 2016-02-18 05:16:54 UTC (rev 196740)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/QuickConsole.css 2016-02-18 05:27:31 UTC (rev 196741)
@@ -25,6 +25,7 @@
.quick-console {
position: relative;
+ min-height: var(--console-prompt-min-height);
display: flex;
align-items: flex-end;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/Variables.css (196740 => 196741)
--- trunk/Source/WebInspectorUI/UserInterface/Views/Variables.css 2016-02-18 05:16:54 UTC (rev 196740)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/Variables.css 2016-02-18 05:27:31 UTC (rev 196741)
@@ -36,6 +36,7 @@
--panel-background-color: hsl(0, 0%, 94%);
--console-secondary-text-color: hsla(0, 0%, 0%, 0.33);
+ --console-prompt-min-height: 30px;
--syntax-highlight-number-color: hsl(248, 100%, 40%);
--syntax-highlight-boolean-color: hsl(309, 85%, 35%);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
